You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/03/03 11:35:46 UTC

Review Request 57280: While Comparing versions, value in latest version is not shown for custom property

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57280/
-----------------------------------------------------------

Review request for Ambari and Alexandr Antonenko.


Bugs: AMBARI-20286
    https://issues.apache.org/jira/browse/AMBARI-20286


Repository: ambari


Description
-------

Difftool which shows the comparison between 2versions doesnt show custom properties added to a service


Diffs
-----

  ambari-web/app/mixins/common/configs/configs_comparator.js 4adc5ae 
  ambari-web/app/models/configs/objects/service_config_property.js ed72dc3 
  ambari-web/app/templates/common/configs/service_config_category.hbs c9bedc5 
  ambari-web/app/utils/config.js 8eeca5f 
  ambari-web/test/views/common/table_view_test.js dd289b0 


Diff: https://reviews.apache.org/r/57280/diff/1/


Testing
-------

20574 passing (22s)
  153 pending


Thanks,

Oleg Nechiporenko


Re: Review Request 57280: While Comparing versions, value in latest version is not shown for custom property

Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57280/#review167810
-----------------------------------------------------------


Ship it!




Ship It!

- Alexandr Antonenko


On March 3, 2017, 11:35 a.m., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57280/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 11:35 a.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-20286
>     https://issues.apache.org/jira/browse/AMBARI-20286
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Difftool which shows the comparison between 2versions doesnt show custom properties added to a service
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/mixins/common/configs/configs_comparator.js 4adc5ae 
>   ambari-web/app/models/configs/objects/service_config_property.js ed72dc3 
>   ambari-web/app/templates/common/configs/service_config_category.hbs c9bedc5 
>   ambari-web/app/utils/config.js 8eeca5f 
>   ambari-web/test/views/common/table_view_test.js dd289b0 
> 
> 
> Diff: https://reviews.apache.org/r/57280/diff/1/
> 
> 
> Testing
> -------
> 
> 20574 passing (22s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>