You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (JIRA)" <ji...@apache.org> on 2012/11/26 03:34:58 UTC
[jira] [Created] (HBASE-7215) Put/Delete/Increment still implement
Writable
Lars Hofhansl created HBASE-7215:
------------------------------------
Summary: Put/Delete/Increment still implement Writable
Key: HBASE-7215
URL: https://issues.apache.org/jira/browse/HBASE-7215
Project: HBase
Issue Type: Bug
Reporter: Lars Hofhansl
Priority: Blocker
Fix For: 0.96.0
Making blocker as suggested by Stack.
At least the following still use Put/Delete as writables.
* IdentityTableReduce.java
* MultiPut.java
* HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (HBASE-7215) Put, Delete, Increment, and
Result still implement Writable
Posted by Gary Helmling <gh...@gmail.com>.
For coprocessor endpoints, we have
https://issues.apache.org/jira/browse/HBASE-6895 as an umbrella issue for
removing the Writable based CoprocessorProtocol support.
There are still a few subtasks to work through to get there, but once done
we can pull out CoprocessorProtocol, Exec, ExecResult,
HTable.coprocessorProxy(), HTable.coprocessorExec() and any other
supporting code.
On Tue, Nov 27, 2012 at 11:37 AM, Gregory Chanan (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504866#comment-13504866]
>
> Gregory Chanan commented on HBASE-7215:
> ---------------------------------------
>
> I think your rant is justified, no need to apologize :). I removed the
> writable code from Append, Get, RowMutations, and Scan because it was on
> the path of what I was working on (converting Filters), but it looks like
> we never circled back to make sure this was done in all areas.
>
> You mind posting this on review board, Lars?
>
> One thing I noticed scanning the patch is that there are still no-arg
> constructors for Writables that could probably be removed, e.g.
> {code}
> /** Constructor for Writable. DO NOT USE */
> public Delete() {
> this((byte [])null);
> {code}
>
>
>
> > Put, Delete, Increment, and Result still implement Writable
> > -----------------------------------------------------------
> >
> > Key: HBASE-7215
> > URL: https://issues.apache.org/jira/browse/HBASE-7215
> > Project: HBase
> > Issue Type: Bug
> > Reporter: Lars Hofhansl
> > Assignee: Lars Hofhansl
> > Priority: Blocker
> > Fix For: 0.96.0
> >
> > Attachments: 7215-v2.txt, 7251-SKETCH.txt
> >
> >
> > Making blocker as suggested by Stack.
> > At least the following still use Put/Delete as writables.
> > * IdentityTableReduce.java
> > * MultiPut.java
> > * HRegionServer.checkAndMutate
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506704#comment-13506704 ]
Hadoop QA commented on HBASE-7215:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555249/7215v7.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 25 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3420//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3420//console
This message is automatically generated.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506055#comment-13506055 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
HadoopQA is on holiday it seems.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Summary: Put, Delete, Increment, and Result still implement Writable (was: Put, Delete, and Increment still implement Writable)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505147#comment-13505147 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
I see. Result.kvs could have never been null before.
Is this:
{code}
+ this.row = this.kvs == null? null: this.kvs.length == 0? null: this.kvs[0].getRow();
{code}
Easier on the eyes when expressed like this?
{code}
+ this.row = this.kvs == null || this.kvs.length == 0 ? null : this.kvs[0].getRow();
{code}
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, Result, all
all HBase M/R classes still implement/use Writable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506969#comment-13506969 ]
Hudson commented on HBASE-7215:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #280 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/280/])
HBASE-7215 Put, Delete, Increment, Result, all all HBase M/R classes still implement/use Writable (Revision 1415412)
Result = FAILURE
larsh :
Files :
* /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/mapreduce/IndexBuilder.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Action.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Append.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Delete.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/MultiPut.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/MultiPutResponse.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/OperationWithAttributes.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Put.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Result.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Scan.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMap.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReaderImpl.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableReduce.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/IdentityTableReducer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableOutputFormat.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MutationSerialization.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ResultSerialization.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableReducer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAttributes.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTimestampsFilter.java
> Put, Delete, Increment, Result, all all HBase M/R classes still implement/use Writable
> --------------------------------------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505042#comment-13505042 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
bq. next used to overwrite the Result you passed in
For that I added a copyFrom(Result) method to Result. It's a problem with Mapred, MapReduce does not do this nonsense.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7215:
-------------------------
Attachment: 7215v3_mutableresult.txt
Maybe we should keep Result immutable and have a MutableResult in the mapred package where its needed? Here is patch showing what it'd look like. Then we could keep Result immutable.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504025#comment-13504025 ]
stack commented on HBASE-7215:
------------------------------
I thought the MR requirement that we do Writables was undone by HBASE-7024? My guess is there is more work to be done there still
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Attachment: 7215v7.txt
Addressed Stacks comments.
Will wait for test results, if that looks good I'll post to RB.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505264#comment-13505264 ]
stack commented on HBASE-7215:
------------------------------
I changed my mind about MutateResult. We are already going to be pissing people off. We can let Result as is w/ its copyFrom for mapred.
Will do as you suggest.
Will have a go at the MR stuff tomorrow too... (looks ugly).
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Attachment: 7215v7.txt
Maybe re-attaching will do it?
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505122#comment-13505122 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
Did you forget to include MutableResult? :)
(I assume it's just a wrapper delegating to Result delegate)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506245#comment-13506245 ]
stack commented on HBASE-7215:
------------------------------
Ugh. These tests fail w/o this patch. These are the only ones that fail. I think you should commit the patch because I need it committed so I can purge other Writable stuff.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504967#comment-13504967 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
[~gchanan] Yep, need to remove the constructors too. I'll post of RB.
[~saint.ack@gmail.com] I expect there to be a lot of test failures :)
Lemme do another pass.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put and Delete still implement
Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Summary: Put and Delete still implement Writable (was: Put/Delete/Increment still implement Writable)
> Put and Delete still implement Writable
> ---------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, Result, all
all HBase M/R classes still implement/use Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Summary: Put, Delete, Increment, Result, all all HBase M/R classes still implement/use Writable (was: Put, Delete, Increment, and Result still implement Writable)
> Put, Delete, Increment, Result, all all HBase M/R classes still implement/use Writable
> --------------------------------------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506720#comment-13506720 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
That looks pretty good!
Should probably still upload to RB for easier review.
Two sticky points I know about:
# Result deserialization used to do 8k chunked reading from the input stream to avoid OOM'ing on the JVMs direct memory. I have no idea how protobufs reads from the stream when deserializing so we may get that problem back.
# The size metric in ScannerCallable was broken when protobufs were introduced, because that just measured the size of the bytes stream (that is no longer filled with protobufs). This patch just comments that part, because it was broken anyway.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505192#comment-13505192 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
The M/R tests fail because:
# for mapred I forgot to setup the Serilization
# the IdentyReducers still user Writables (and still something else I haven't figured out, yet).
#2 actually poses an interesting problem. Right now we use Writable as a common super class to declare the M/R jobs. Now each class we use there needs its own serializer. For example for Import we'd have to add a serializer for KeyValue (which means KeyValues need to be supported directly by protobufs).
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Attachment: 7215-v2.txt
Patch that at least passes TestFromClientSide. Also removes Writable from Action, MultiAction, and MultiResponse.
In general I am quite disappointed about the current state of protobuf'ing work.
This looks unprofessional, where somebody just lost interest in finishing the cleanup work. We can do better than this.
The Writable stuff is still *all over* the place, sometimes mixed together with the protobuf stuff (as in the case that I fixed where the Result was serialized as a Writable inside the protobuf response).
Why is HBaseObjectWritable still around?
I will only believe that we protobuf'ed everything when HBaseObjectWritable is gone for good.
(Sorry for the rant)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505299#comment-13505299 ]
Hadoop QA commented on HBASE-7215:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555130/7215v4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 15 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 22 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultipleTimestamps
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.regionserver.TestHRegion
org.apache.hadoop.hbase.mapreduce.TestWALPlayer
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
org.apache.hadoop.hbase.regionserver.TestBlocksRead
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3417//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3417//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3417//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3417//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3417//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3417//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3417//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3417//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3417//console
This message is automatically generated.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504928#comment-13504928 ]
stack commented on HBASE-7215:
------------------------------
I have a few test failures when I run the patch. Let me try and fix and address Gregory's comment.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506739#comment-13506739 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
Filed two sub tasks. OK will commit in the next hour without an extra RB review unless I hear objections.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505196#comment-13505196 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
Or more to the point. In order to support both Put/Delete/Mutation and KeyValue, a TableReducer needs to also declare its output value type (it can no longer be set to Writable) (see TableReducer.java)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506733#comment-13506733 ]
stack commented on HBASE-7215:
------------------------------
Make new issues for the two probs above?
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504817#comment-13504817 ]
stack commented on HBASE-7215:
------------------------------
I started to review but it is going to take a while and it looks like could go deeper still. I'll be back....
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7215:
-------------------------
Attachment: MutableResult.java
Should have included this in the last patch posted.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504385#comment-13504385 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
This makes TestFromClientSide time out, apparently it can no longer contact the master.
I do not think I'll have a lot of time in the coming weeks to track that down.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506246#comment-13506246 ]
stack commented on HBASE-7215:
------------------------------
I spent time looking at the failure. For TestMasterReplication adding a pause in putAndWait after we put and before we cycle on the gets waiting five seconds makes it pass. Not sure what this about. In logs I can see the replication of the edit so it should be picking it up. Will ask j-d in morning now he's back.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Status: Patch Available (was: Open)
Not sure why HadoopQA is not picking this up. Trying again.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505043#comment-13505043 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
Do you have a list of failing tests, maybe we can divvy that up.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505134#comment-13505134 ]
stack commented on HBASE-7215:
------------------------------
I'll redo the patch w/ MutableResult included. Will also take a look see at MR failures. They are fun to look at (all the datanodes, regionservers, and tasktrackers all spinning in the one little heap)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl reassigned HBASE-7215:
------------------------------------
Assignee: Lars Hofhansl
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504431#comment-13504431 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
Tracked it down anyway. In HRegionServer.doBatchOp we used to build protobuf parameters using the real Result object. That worked by pure accident, because Result happened to be a Writable.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, and Increment still
implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503612#comment-13503612 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
Result.java also still implements Writable.
The sticky part is that M/R expects Writables. So if we have Put/Delete not as Writable they cannot be used in M/R, but if we keep them as Writable we are not using protobufs everywhere and hence we do not have wire compatibility.
Maybe readFields and write could be implemented in terms of protobuf, so that we still have Writables, but all encoding/decoding is done by protobuf.
> Put, Delete, and Increment still implement Writable
> ---------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Status: Open (was: Patch Available)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7215:
-------------------------
Status: Patch Available (was: Open)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504157#comment-13504157 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
I see, cool. Makes we want to delete my comment above, but I'll refrain :)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505126#comment-13505126 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
All the M/R tests fail... I'll have a look at that as soon as I get a chance.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Status: Open (was: Patch Available)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505059#comment-13505059 ]
stack commented on HBASE-7215:
------------------------------
[~lhofhansl] I see that now. Its ugly but works (smile).... it makes the Result mutable unfortunately... but hey. Let me put up my patch removing null Constructors w/ fixes in TestMultiParallel which was failing if empty Result. Ditto TestTimestampsFilter.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, Result, all
all HBase M/R classes still implement/use Writable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506961#comment-13506961 ]
Hudson commented on HBASE-7215:
-------------------------------
Integrated in HBase-TRUNK #3580 (See [https://builds.apache.org/job/HBase-TRUNK/3580/])
HBASE-7215 Put, Delete, Increment, Result, all all HBase M/R classes still implement/use Writable (Revision 1415412)
Result = FAILURE
larsh :
Files :
* /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/mapreduce/IndexBuilder.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Action.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Append.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Delete.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/MultiPut.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/MultiPutResponse.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/OperationWithAttributes.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Put.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Result.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Scan.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMap.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReaderImpl.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableReduce.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/IdentityTableReducer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableOutputFormat.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MutationSerialization.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ResultSerialization.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableReducer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAttributes.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTimestampsFilter.java
> Put, Delete, Increment, Result, all all HBase M/R classes still implement/use Writable
> --------------------------------------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504879#comment-13504879 ]
Gary Helmling commented on HBASE-7215:
--------------------------------------
For coprocessor endpoints, we have
https://issues.apache.org/jira/browse/HBASE-6895 as an umbrella issue for
removing the Writable based CoprocessorProtocol support.
There are still a few subtasks to work through to get there, but once done
we can pull out CoprocessorProtocol, Exec, ExecResult,
HTable.coprocessorProxy(), HTable.coprocessorExec() and any other
supporting code.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Attachment: (was: 7215v3.txt)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506662#comment-13506662 ]
stack commented on HBASE-7215:
------------------------------
I'm running hadoopqa manually. Rerunning again after the above inconclusive test result.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Attachment: 7251-SKETCH.txt
Sketch of a patch. The only testing I have done is making sure it compiles.
* adds Serialization for Mutation and Result
* rejigger out M/R support to use that
* remove all Writable stuff from Put, Delete, Increment, and Result.
Please have a careful look, this is new'ish territory for me.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7215:
-------------------------
Status: Patch Available (was: Open)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504866#comment-13504866 ]
Gregory Chanan commented on HBASE-7215:
---------------------------------------
I think your rant is justified, no need to apologize :). I removed the writable code from Append, Get, RowMutations, and Scan because it was on the path of what I was working on (converting Filters), but it looks like we never circled back to make sure this was done in all areas.
You mind posting this on review board, Lars?
One thing I noticed scanning the patch is that there are still no-arg constructors for Writables that could probably be removed, e.g.
{code}
/** Constructor for Writable. DO NOT USE */
public Delete() {
this((byte [])null);
{code}
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505124#comment-13505124 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
Let's do that instead (MutableResult)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504023#comment-13504023 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
How about I make a patch with that, and then we can see how to improve it. I assume we want to avoid importing generated protobuf classes in Put/Delete (because they are in the client interface), which complicates things further.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504998#comment-13504998 ]
stack commented on HBASE-7215:
------------------------------
[~lhofhansl] I'm on it
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505143#comment-13505143 ]
Hadoop QA commented on HBASE-7215:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555088/7215v3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 15 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 22 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
org.apache.hadoop.hbase.regionserver.TestBlocksRead
org.apache.hadoop.hbase.mapreduce.TestWALPlayer
org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
org.apache.hadoop.hbase.client.TestMultipleTimestamps
org.apache.hadoop.hbase.regionserver.TestHRegion
org.apache.hadoop.hbase.mapreduce.TestImportExport
org.apache.hadoop.hbase.TestDrainingServer
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3412//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3412//console
This message is automatically generated.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506586#comment-13506586 ]
Hadoop QA commented on HBASE-7215:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555249/7215v7.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 25 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3419//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3419//console
This message is automatically generated.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505078#comment-13505078 ]
Hadoop QA commented on HBASE-7215:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555084/7215v3_mutableresult.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3411//console
This message is automatically generated.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, and Increment still
implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503624#comment-13503624 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
After some looking... If we want continue to support Put/Delete/Result in M/R, using protobufs to implement readFields and write is the only way out.
In Writable.write(DataOutput) we'd create the write Mutate protobuf object, write that to a bytearray and then write that byte array into the DataOutput. It's too bad we only have a DataOutut here and not an OutputStream, othewise we could just stream the protobuf object through that stream, saving one copy of all the data.
In Writable.readFields we do something akin to ProtoBufutil.toDelete after we read the Mutate object from the stream.
That means the data is not streamed, but instead materialized in memory three(!) times in these cases (the object itself, its protobuf representation, and the byte array to be sent across the wire).
I'd welcome any better ideas!
> Put, Delete, and Increment still implement Writable
> ---------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506721#comment-13506721 ]
stack commented on HBASE-7215:
------------------------------
+1 on commit
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505102#comment-13505102 ]
Hadoop QA commented on HBASE-7215:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555081/7215v3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 15 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 22 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
org.apache.hadoop.hbase.regionserver.TestHRegion
org.apache.hadoop.hbase.client.TestMultipleTimestamps
org.apache.hadoop.hbase.mapreduce.TestWALPlayer
org.apache.hadoop.hbase.regionserver.TestBlocksRead
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapreduce.TestImportExport
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3410//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3410//console
This message is automatically generated.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504128#comment-13504128 ]
stack commented on HBASE-7215:
------------------------------
In hadoop, there is a http://hadoop.apache.org/docs/r1.0.4/api/org/apache/hadoop/io/serializer/SerializationFactory.html It defaults Writables. We'd make it default pb in 0.96.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504387#comment-13504387 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
TestFromClientSide passed without the changes to Result.java. Hmm.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Attachment: 7215v6.txt
Fix for ImportTsv (needed to setup the Serialization, because it's not using TableMapReduceUtil in all cases)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504888#comment-13504888 ]
Andrew Purtell commented on HBASE-7215:
---------------------------------------
bq. I will only believe that we protobuf'ed everything when HBaseObjectWritable is gone for good.
+1, could start with removing HBaseObjectWritable and commit the result when everything works again.
Easy to say, hard to find the time.
But I agree with the sentiment we shouldn't ship 0.96 in this half-state.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, Result, all
all HBase M/R classes still implement/use Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk.
Thanks for the help and review Stack.
> Put, Delete, Increment, Result, all all HBase M/R classes still implement/use Writable
> --------------------------------------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, and Increment still
implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Summary: Put, Delete, and Increment still implement Writable (was: Put and Delete still implement Writable)
> Put, Delete, and Increment still implement Writable
> ---------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505815#comment-13505815 ]
stack commented on HBASE-7215:
------------------------------
The changes in 'hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java' seem unnecessary (might be my fault)
We still have to get rid of WritableComparable. Can do in another JIRA.
hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java adds imports but doesn't seem to use them (bleed from another patch?)
ResultSerialization is missing license
Patch looking good.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Status: Patch Available (was: Open)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504750#comment-13504750 ]
stack commented on HBASE-7215:
------------------------------
[~lhofhansl] We can't release 0.96 till all Writables are gone. Mind ranting over on dev list? Perhaps on hbase 0.96 thread?
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506196#comment-13506196 ]
stack commented on HBASE-7215:
------------------------------
These failed on me:
{code}
Results :
Failed tests: testCyclicReplication(org.apache.hadoop.hbase.replication.TestMasterReplication): Waited too much time for put replication
testSimplePutDelete(org.apache.hadoop.hbase.replication.TestMasterReplication): Waited too much time for put replication
testMultiSlaveReplication(org.apache.hadoop.hbase.replication.TestMultiSlaveReplication): Waited too much time for put replication
testDeleteTypes(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for put replication
queueFailover(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for queueFailover replication. Waited 40172ms.
{code}
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Attachment: 7215v4.txt
Starting to feel a bit better about this now.
(In nothing else this was a good exercise to dive into the depth of M/R serialization and protobufs) :)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504999#comment-13504999 ]
stack commented on HBASE-7215:
------------------------------
[~lhofhansl] Currently trying to figure out how to make MR work; next used to overwrite the Result you passed in. You can't do that w/ our pb'ing.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7215:
-------------------------
Attachment: 7215v3.txt
Lars' patch w/ some null constructor's removed and some fixes in tests to deal better w/ Result that has no kvs.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3.txt, 7251-SKETCH.txt
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7215:
---------------------------------
Attachment: 7215v5.txt
Fixes a few more wrinkles.
TestImportTsv still fails.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7215:
-------------------------
Attachment: 7215v3.txt
Retry (assume hadoopqa picked up my sketch patch)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505269#comment-13505269 ]
Lars Hofhansl commented on HBASE-7215:
--------------------------------------
I have found the problem with M/R. protobuf's parseFrom apparently wants to read until EOF. But in this case many messages are serialized over the same stream. So needed to use parseDelimitedFrom and writeDelimitedTo. Also had to change TableOutputFormat to accept Mutations instead of Writables.
I also changed the generics signature of TableReducer and IdentityReducer. It might not be as bad as we think as these always only supported Put and Delete, so instead of Writable they just need to be declared with Mutation.
New patch coming up momentarily.
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result
still implement Writable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7215:
-------------------------
Status: Open (was: Patch Available)
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
> Key: HBASE-7215
> URL: https://issues.apache.org/jira/browse/HBASE-7215
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira