[jira] [Resolved] (SSHD-316) DefaultSshFuture waits for ever

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SSHD-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved SSHD-316.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.12.0
         Assignee: Guillaume Nodet

https://git-wip-us.apache.org/repos/asf?p=mina-sshd.git;a=commit;h=6499aa9a68f5ba2448c9d88efc5049c01f287eb4

> DefaultSshFuture waits for ever
> -------------------------------
>
>                 Key: SSHD-316
>                 URL: https://issues.apache.org/jira/browse/SSHD-316
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 0.10.1
>            Reporter: Haim Sh
>            Assignee: Guillaume Nodet
>             Fix For: 0.12.0
>
>
> the code for DefaultSshFuture.await0(long timeoutMillis, boolean interruptable) may wait forever.
> This happens when curTime == endTime in the main loop.
> The loop will not break since it checks: curTime > endTime
> and it will re-enter the main loop and call wait(0).
> see: 
> http://www.javamex.com/tutorials/synchronization_wait_notify_3.shtml
> I believe we should change the code DefaultSshFuture:143 to:
> curTime >= endTime



--
This message was sent by Atlassian JIRA
(v6.2#6252)