[GitHub] sebbASF commented on issue #406: DurationUtils - methods for rounding duration

[GitBox <gi...@apache.org>]

sebbASF commented on issue #406: DurationUtils - methods for rounding duration 
URL: https://github.com/apache/commons-lang/pull/406#issuecomment-462998862
 
 
   Thanks.
   
   However, the class Javadoc does not make it clear that there are two types of rounding involved, nor does do the methods explain what rounding is done, particularly for the roundDays etc methods.
   
   What about supporting Banker's rounding?
   This rounds to the nearest even number, e.g. 0.5 => 0 and 1.5 => 2
   
   I think it might be better to have a single round method for each time unit, with a parameter to specify the rounding type: up, half-up, bankers (are there any more rounding methods?)
   
   Or even a single method for all time units.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services