You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mark Struberg (JIRA)" <de...@myfaces.apache.org> on 2011/08/30 16:03:38 UTC
[jira] [Created] (EXTCDI-219) ConversationAware must either be made
public and moved to api or completely removed
ConversationAware must either be made public and moved to api or completely removed
-----------------------------------------------------------------------------------
Key: EXTCDI-219
URL: https://issues.apache.org/jira/browse/EXTCDI-219
Project: MyFaces CODI
Issue Type: Bug
Components: Core
Affects Versions: 1.0.1
Reporter: Mark Struberg
Assignee: Mark Struberg
ConversationAware is currently used internally for hardcoded casts. Either we make this interface public or drop it completely and add/subclass the functionality to ConversationExpirationEvaluator
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (EXTCDI-219) ConversationAware must either be
made public and moved to api or completely removed
Posted by "Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTCDI-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek resolved EXTCDI-219.
-------------------------------------
Resolution: Won't Fix
this interface is just needed as workaround for EXTCDI-49. if we move the method to ConversationExpirationEvaluator, it won't make any difference from the functional point of view. ConversationAware clearly documents which ConversationExpirationEvaluator needs to know its conversation. it doesn't impact the intended extension points (see http://cwiki.apache.org/confluence/display/EXTCDI/JSF+DevDoc)
> ConversationAware must either be made public and moved to api or completely removed
> -----------------------------------------------------------------------------------
>
> Key: EXTCDI-219
> URL: https://issues.apache.org/jira/browse/EXTCDI-219
> Project: MyFaces CODI
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.1
> Reporter: Mark Struberg
> Assignee: Gerhard Petracek
> Priority: Minor
>
> ConversationAware is currently used internally for hardcoded casts. Either we make this interface public or drop it completely and add/subclass the functionality to ConversationExpirationEvaluator
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (EXTCDI-219) ConversationAware must either be
made public and moved to api or completely removed
Posted by "Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTCDI-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek resolved EXTCDI-219.
-------------------------------------
Resolution: Won't Fix
if you need to write an add-on which changes the behaviour of one of the scopes, you have to use the public spi like ConversationFactory, EditableConversation, ConversationKey and ConversationConfig everything else is internal and not intended to be used because it can change at any time
> ConversationAware must either be made public and moved to api or completely removed
> -----------------------------------------------------------------------------------
>
> Key: EXTCDI-219
> URL: https://issues.apache.org/jira/browse/EXTCDI-219
> Project: MyFaces CODI
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.1
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> ConversationAware is currently used internally for hardcoded casts. Either we make this interface public or drop it completely and add/subclass the functionality to ConversationExpirationEvaluator
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (EXTCDI-219) ConversationAware must either be
made public and moved to api or completely removed
Posted by "Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTCDI-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093837#comment-13093837 ]
Gerhard Petracek commented on EXTCDI-219:
-----------------------------------------
it isn't allowed to extend DefaultConversation and ConversationExpirationEvaluator is also an internal interface therefore the internal usage of ConversationAware is ok
> ConversationAware must either be made public and moved to api or completely removed
> -----------------------------------------------------------------------------------
>
> Key: EXTCDI-219
> URL: https://issues.apache.org/jira/browse/EXTCDI-219
> Project: MyFaces CODI
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.1
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> ConversationAware is currently used internally for hardcoded casts. Either we make this interface public or drop it completely and add/subclass the functionality to ConversationExpirationEvaluator
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (EXTCDI-219) ConversationAware must either be
made public and moved to api or completely removed
Posted by "Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTCDI-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek reopened EXTCDI-219:
-------------------------------------
Assignee: Gerhard Petracek (was: Mark Struberg)
we can move #setConversation to ConversationExpirationEvaluator but it doesn't make any difference because ConversationExpirationEvaluator is internal as well and not every ConversationExpirationEvaluator needs access to the conversation itself
> ConversationAware must either be made public and moved to api or completely removed
> -----------------------------------------------------------------------------------
>
> Key: EXTCDI-219
> URL: https://issues.apache.org/jira/browse/EXTCDI-219
> Project: MyFaces CODI
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.1
> Reporter: Mark Struberg
> Assignee: Gerhard Petracek
> Priority: Minor
>
> ConversationAware is currently used internally for hardcoded casts. Either we make this interface public or drop it completely and add/subclass the functionality to ConversationExpirationEvaluator
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (EXTCDI-219) ConversationAware must
either be made public and moved to api or completely removed
Posted by "Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/EXTCDI-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093854#comment-13093854 ]
Gerhard Petracek edited comment on EXTCDI-219 at 8/30/11 4:12 PM:
------------------------------------------------------------------
we can move #setConversation to ConversationExpirationEvaluator but it doesn't make any difference because ConversationExpirationEvaluator is internal as well and not every ConversationExpirationEvaluator needs access to the conversation itself
this internal interface just exists because the conversation is needed in observeRenderedView which is a workaround to fix EXTCDI-49. all other conversation types don't need a ConversationExpirationEvaluator which is aware of the conversation.
was (Author: gpetracek):
we can move #setConversation to ConversationExpirationEvaluator but it doesn't make any difference because ConversationExpirationEvaluator is internal as well and not every ConversationExpirationEvaluator needs access to the conversation itself
> ConversationAware must either be made public and moved to api or completely removed
> -----------------------------------------------------------------------------------
>
> Key: EXTCDI-219
> URL: https://issues.apache.org/jira/browse/EXTCDI-219
> Project: MyFaces CODI
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.1
> Reporter: Mark Struberg
> Assignee: Gerhard Petracek
> Priority: Minor
>
> ConversationAware is currently used internally for hardcoded casts. Either we make this interface public or drop it completely and add/subclass the functionality to ConversationExpirationEvaluator
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira