You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/09 23:00:40 UTC

[GitHub] tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API

tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack Transformation API
URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r216173212
 
 

 ##########
 File path: include/mxnet/tensor_blob.h
 ##########
 @@ -89,7 +92,8 @@ class TBlob {
   template<typename DType>
   TBlob(DType *dptr, const TShape &shape, int dev_mask, int dev_id = -1)
       : dptr_(dptr), shape_(shape),
-        type_flag_(mshadow::DataType<DType>::kFlag) {
+        type_flag_(mshadow::DataType<DType>::kFlag),
+        deleter_(nullptr) {
 
 Review comment:
   We cannot introduce deleter to the TBlob

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services