You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/07 07:22:35 UTC
[GitHub] [dubbo] karlchan-cn opened a new issue, #10887: 动态超时控制
karlchan-cn opened a new issue, #10887:
URL: https://github.com/apache/dubbo/issues/10887
Proposal说明-
从consumer端,动态控制请求provider的超时时间。
再DubboInvoker当中,calculateTimeout通过RpcContext获取time参数控制超时.
问题-
1. 由于time参数再2.7.8等2.x版本会隐式传参导致污染下游provider的参数。
2. 希望通过增加动态参数用完即焚的方式,避免参数污染下游。
解决方案request
1. 通过增加【动态超时参数】【dynamic-timeout】,优先级比timeout参数高,有限读取动态超时参数
2. 【动态超时参数】读取完毕,就进行参数删除
实现如截图
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #10887: 【动态超时控制】提议
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on issue #10887:
URL: https://github.com/apache/dubbo/issues/10887#issuecomment-1305318806
修改 getTimeout 的逻辑并不能从根本上解决问题。这个问题本质还是下游无条件透传导致的，最好是看下怎么解决这个问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] karlchan-cn commented on issue #10887: 【动态超时控制】提议
Posted by GitBox <gi...@apache.org>.
karlchan-cn commented on issue #10887:
URL: https://github.com/apache/dubbo/issues/10887#issuecomment-1305355185
> 
>
> 修改 getTimeout 的逻辑并不能从根本上解决问题。这个问题本质还是下游无条件透传导致的，最好是看下怎么解决这个问题。
Hello，非常感谢回答。
我这边调整的还是按照2.7.8.没有看最新3.x版本也就传参了。
关于超时控制这块,还是按照你们的设计思想来执行。
这边刚刚确定了一下，**下游的dubbo worker线程在本次请求退出后,context将会被清除。**
考虑到已经满足需求【请求超时染色】，可以不考虑本次Proposal.
谢谢Albumen的回答。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] karlchan-cn closed issue #10887: 【动态超时控制】提议
Posted by GitBox <gi...@apache.org>.
karlchan-cn closed issue #10887: 【动态超时控制】提议
URL: https://github.com/apache/dubbo/issues/10887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org