You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sgrebnov <gi...@git.apache.org> on 2015/06/15 14:18:39 UTC
[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/91
CB-9159 Fix Windows Phone 8.1 deploy when 'window-target-version' is 10
Jira issue: https://issues.apache.org/jira/browse/CB-9159
* Don't duplicate target processing logic in Run and Build scripts.
* Run should use first available build target returned by Build script
* Added additional tests for `--appx` parameter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-9159
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit 526c9f6b07e58a5795bb6e2fec98f6bbd186b586
Author: sgrebnov <v-...@microsoft.com>
Date: 2015-06-15T10:11:26Z
CB-9159 Fix Windows Phone 8.1 deploy when 'window-target-version' is 10.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/91#issuecomment-122286092
I'll see if this is still actual and will do rebase on Monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/91#issuecomment-113861921
@robpaveza could you please review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/91#issuecomment-116763083
In general LGTM.
I would prefer that we examine the pipeline here. We had been talking about making the build process be module-based for Windows (for example, the Windows build step provides a set of require()-able modules that then executes from cordova-lib). In such a world, we could just parse the CLI arguments once up-front, instead of making each individual step parse them, which seems to have increased the complexity as we talk about build vs run vs prepare. I'd like to see us go that direction in the long-term, but in the short-term, I think this will be adequate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/91#issuecomment-123306596
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/91#discussion_r34892373
--- Diff: template/cordova/lib/run.js ---
@@ -169,20 +135,10 @@ module.exports.help = function () {
process.exit(0);
};
-
-function getWindowsTargetVersion() {
--- End diff --
This is not required anymore as we rely on build - we run the first build target.
var buildTargets = build.getBuildTargets(args.win, args.phone, args.appx);
..
+ if (!buildTargets || buildTargets.lenght <= 0) {
+ return Q.reject('Unable to determine deploy target.');
+ }
+
+ // we deploy the first build target so we use buildTargets[0] to determine
+ // what project type we should deploy
+ var projectType = projFileToType(buildTargets[0]);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/91#discussion_r33486397
--- Diff: template/cordova/lib/run.js ---
@@ -169,20 +135,10 @@ module.exports.help = function () {
process.exit(0);
};
-
-function getWindowsTargetVersion() {
--- End diff --
I'm confused about why this function is being removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/91#issuecomment-116753933
@robpaveza Ping..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org