You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Niall Pemberton (JIRA)" <ji...@apache.org> on 2008/05/22 01:37:56 UTC
[jira] Created: (COMMONSSITE-30) Add Module profiles to parent poms
Add Module profiles to parent poms
----------------------------------
Key: COMMONSSITE-30
URL: https://issues.apache.org/jira/browse/COMMONSSITE-30
Project: Commons All
Issue Type: Improvement
Components: Commons Parent Pom
Reporter: Niall Pemberton
Attachments: COMMONSSITE-30-module-profiles.patch
Seeing the felix project's pom with different modules in profiles made me think this might be useful for commons - with "trunks-proper" or "trunks-sandbox".
I tried it out, but running mvn -Ptrunks-proper site failed bizarely:
* on commons-io it objected to JDK 1.5 features saying the source option was 1.3 - so it seemed to be using the commons-parent default, rather than the individual property setting for projects
* on lang though it objected to enum - so seemed to ignore those settings.
Perhaps someone else knows how to get it working properly - at the least its useful for cleaning up all the modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COMMONSSITE-30) Add Module profiles to parent poms
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMMONSSITE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated COMMONSSITE-30:
---------------------------------------
Attachment: COMMONSSITE-30-module-profiles.patch
Attaching a patch in case anyone else wants to play with it
> Add Module profiles to parent poms
> ----------------------------------
>
> Key: COMMONSSITE-30
> URL: https://issues.apache.org/jira/browse/COMMONSSITE-30
> Project: Commons All
> Issue Type: Improvement
> Components: Commons Parent Pom
> Reporter: Niall Pemberton
> Attachments: COMMONSSITE-30-module-profiles.patch
>
>
> Seeing the felix project's pom with different modules in profiles made me think this might be useful for commons - with "trunks-proper" or "trunks-sandbox".
> I tried it out, but running mvn -Ptrunks-proper site failed bizarely:
> * on commons-io it objected to JDK 1.5 features saying the source option was 1.3 - so it seemed to be using the commons-parent default, rather than the individual property setting for projects
> * on lang though it objected to enum - so seemed to ignore those settings.
> Perhaps someone else knows how to get it working properly - at the least its useful for cleaning up all the modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COMMONSSITE-30) Add Module profiles to parent poms
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMMONSSITE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated COMMONSSITE-30:
---------------------------------------
Attachment: COMMONSSITE-30-module-profiles-v4.patch
Updating patch to include a trunks-sandbox profile in the commons-sandbox-parent pom
> Add Module profiles to parent poms
> ----------------------------------
>
> Key: COMMONSSITE-30
> URL: https://issues.apache.org/jira/browse/COMMONSSITE-30
> Project: Commons All
> Issue Type: Improvement
> Components: Commons Parent Pom
> Reporter: Niall Pemberton
> Attachments: COMMONSSITE-30-module-profiles-v4.patch
>
>
> Seeing the felix project's pom with different modules in profiles made me think this might be useful for commons - with "trunks-proper" or "trunks-sandbox".
> I tried it out, but running mvn -Ptrunks-proper site failed bizarely:
> * on commons-io it objected to JDK 1.5 features saying the source option was 1.3 - so it seemed to be using the commons-parent default, rather than the individual property setting for projects
> * on lang though it objected to enum - so seemed to ignore those settings.
> Perhaps someone else knows how to get it working properly - at the least its useful for cleaning up all the modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COMMONSSITE-30) Add Module profiles to parent poms
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMMONSSITE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated COMMONSSITE-30:
---------------------------------------
Attachment: (was: COMMONSSITE-30-module-profiles-v2.patch)
> Add Module profiles to parent poms
> ----------------------------------
>
> Key: COMMONSSITE-30
> URL: https://issues.apache.org/jira/browse/COMMONSSITE-30
> Project: Commons All
> Issue Type: Improvement
> Components: Commons Parent Pom
> Reporter: Niall Pemberton
> Attachments: COMMONSSITE-30-module-profiles-v3.patch
>
>
> Seeing the felix project's pom with different modules in profiles made me think this might be useful for commons - with "trunks-proper" or "trunks-sandbox".
> I tried it out, but running mvn -Ptrunks-proper site failed bizarely:
> * on commons-io it objected to JDK 1.5 features saying the source option was 1.3 - so it seemed to be using the commons-parent default, rather than the individual property setting for projects
> * on lang though it objected to enum - so seemed to ignore those settings.
> Perhaps someone else knows how to get it working properly - at the least its useful for cleaning up all the modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COMMONSSITE-30) Add Module profiles to parent
poms
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMMONSSITE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599283#action_12599283 ]
Niall Pemberton commented on COMMONSSITE-30:
--------------------------------------------
The checkstyle configuration in component poms was the next problem to cause this to fail - I've fixed all the components that use checkstyle:
http://svn.apache.org/viewvc?view=rev&revision=659438
> Add Module profiles to parent poms
> ----------------------------------
>
> Key: COMMONSSITE-30
> URL: https://issues.apache.org/jira/browse/COMMONSSITE-30
> Project: Commons All
> Issue Type: Improvement
> Components: Commons Parent Pom
> Reporter: Niall Pemberton
> Attachments: COMMONSSITE-30-module-profiles-v2.patch
>
>
> Seeing the felix project's pom with different modules in profiles made me think this might be useful for commons - with "trunks-proper" or "trunks-sandbox".
> I tried it out, but running mvn -Ptrunks-proper site failed bizarely:
> * on commons-io it objected to JDK 1.5 features saying the source option was 1.3 - so it seemed to be using the commons-parent default, rather than the individual property setting for projects
> * on lang though it objected to enum - so seemed to ignore those settings.
> Perhaps someone else knows how to get it working properly - at the least its useful for cleaning up all the modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COMMONSSITE-30) Add Module profiles to parent poms
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMMONSSITE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated COMMONSSITE-30:
---------------------------------------
Attachment: (was: COMMONSSITE-30-module-profiles-v3.patch)
> Add Module profiles to parent poms
> ----------------------------------
>
> Key: COMMONSSITE-30
> URL: https://issues.apache.org/jira/browse/COMMONSSITE-30
> Project: Commons All
> Issue Type: Improvement
> Components: Commons Parent Pom
> Reporter: Niall Pemberton
> Attachments: COMMONSSITE-30-module-profiles-v4.patch
>
>
> Seeing the felix project's pom with different modules in profiles made me think this might be useful for commons - with "trunks-proper" or "trunks-sandbox".
> I tried it out, but running mvn -Ptrunks-proper site failed bizarely:
> * on commons-io it objected to JDK 1.5 features saying the source option was 1.3 - so it seemed to be using the commons-parent default, rather than the individual property setting for projects
> * on lang though it objected to enum - so seemed to ignore those settings.
> Perhaps someone else knows how to get it working properly - at the least its useful for cleaning up all the modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COMMONSSITE-30) Add Module profiles to parent poms
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMMONSSITE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated COMMONSSITE-30:
---------------------------------------
Attachment: COMMONSSITE-30-module-profiles-v2.patch
The JavaDoc problems can be fixed by upgrading to the latest maven-javadoc-plugin and setting aggregate to false.
Attaching a revised patch for commons-parent:
* COMMONSSITE-30-module-profiles-v2.patch
We have a couple of multi-moduie projects (JCI and VFS from memory) - so would probably need to configure the maven-javadoc-plugin with aggregate set to true in their component poms.
> Add Module profiles to parent poms
> ----------------------------------
>
> Key: COMMONSSITE-30
> URL: https://issues.apache.org/jira/browse/COMMONSSITE-30
> Project: Commons All
> Issue Type: Improvement
> Components: Commons Parent Pom
> Reporter: Niall Pemberton
> Attachments: COMMONSSITE-30-module-profiles-v2.patch, COMMONSSITE-30-module-profiles.patch
>
>
> Seeing the felix project's pom with different modules in profiles made me think this might be useful for commons - with "trunks-proper" or "trunks-sandbox".
> I tried it out, but running mvn -Ptrunks-proper site failed bizarely:
> * on commons-io it objected to JDK 1.5 features saying the source option was 1.3 - so it seemed to be using the commons-parent default, rather than the individual property setting for projects
> * on lang though it objected to enum - so seemed to ignore those settings.
> Perhaps someone else knows how to get it working properly - at the least its useful for cleaning up all the modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COMMONSSITE-30) Add Module profiles to parent poms
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMMONSSITE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated COMMONSSITE-30:
---------------------------------------
Attachment: (was: COMMONSSITE-30-module-profiles.patch)
> Add Module profiles to parent poms
> ----------------------------------
>
> Key: COMMONSSITE-30
> URL: https://issues.apache.org/jira/browse/COMMONSSITE-30
> Project: Commons All
> Issue Type: Improvement
> Components: Commons Parent Pom
> Reporter: Niall Pemberton
> Attachments: COMMONSSITE-30-module-profiles-v2.patch
>
>
> Seeing the felix project's pom with different modules in profiles made me think this might be useful for commons - with "trunks-proper" or "trunks-sandbox".
> I tried it out, but running mvn -Ptrunks-proper site failed bizarely:
> * on commons-io it objected to JDK 1.5 features saying the source option was 1.3 - so it seemed to be using the commons-parent default, rather than the individual property setting for projects
> * on lang though it objected to enum - so seemed to ignore those settings.
> Perhaps someone else knows how to get it working properly - at the least its useful for cleaning up all the modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COMMONSSITE-30) Add Module profiles to parent poms
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COMMONSSITE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated COMMONSSITE-30:
---------------------------------------
Attachment: COMMONSSITE-30-module-profiles-v3.patch
Attaching v2 of the patch: COMMONSSITE-30-module-profiles-v3.patch
All seems to work OK now except for the following:
* The source and test xref's don't get generated for individual components
* The individual sites don't have their own custom menus at the top - uses the standard commons one
So atm its no good for re-generating/deploying all the component sites - but its useful for cleaning, testing and testing commons-parent pom changes (e.g. upgrading a plugin version and seeing if it affects any components). So I think this change should be applied - its non-invasive since its in a separate profile - if you don't activate that profile, then it doesn't affect anyone. If no-one objects I'll commit this.
> Add Module profiles to parent poms
> ----------------------------------
>
> Key: COMMONSSITE-30
> URL: https://issues.apache.org/jira/browse/COMMONSSITE-30
> Project: Commons All
> Issue Type: Improvement
> Components: Commons Parent Pom
> Reporter: Niall Pemberton
> Attachments: COMMONSSITE-30-module-profiles-v2.patch, COMMONSSITE-30-module-profiles-v3.patch
>
>
> Seeing the felix project's pom with different modules in profiles made me think this might be useful for commons - with "trunks-proper" or "trunks-sandbox".
> I tried it out, but running mvn -Ptrunks-proper site failed bizarely:
> * on commons-io it objected to JDK 1.5 features saying the source option was 1.3 - so it seemed to be using the commons-parent default, rather than the individual property setting for projects
> * on lang though it objected to enum - so seemed to ignore those settings.
> Perhaps someone else knows how to get it working properly - at the least its useful for cleaning up all the modules.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.