You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/18 20:13:02 UTC

[GitHub] [beam] jkff opened a new pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

jkff opened a new pull request #12619:
URL: https://github.com/apache/beam/pull/12619


   Also adds a Julia set test on portable local runner, which uses a
   setup.py and hence exercises the artifact staging codepath.
   
   This is a squashed cherrypick of https://github.com/apache/beam/pull/12571 + a change to CHANGES.md.
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
   --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
   Java | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/i
 con)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](htt
 ps://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
   Python | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_
 Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_P
 ostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
   XLang | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website
   --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/be
 am_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
   Portable | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   ![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn commented on a change in pull request #12619: [BEAM-10702, BEAM-10757] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #12619:
URL: https://github.com/apache/beam/pull/12619#discussion_r472556534



##########
File path: sdks/python/container/license_scripts/dep_urls_py.yaml
##########
@@ -48,7 +48,9 @@ pip_dependencies:
   cython:
     license: "https://raw.githubusercontent.com/cython/cython/master/LICENSE.txt"
   enum34:
-    license: "https://bitbucket.org/stoneleaf/enum34/raw/c208549a93b71b948ff7bbdfd29dce8f85527916/enum/LICENSE"
+    # The original repo is down. This license taken from somebody's clone:
+    # https://github.com/jamespharaoh/python-enum34/blob/master/enum/LICENSE
+    license: "file:///tmp/license_scripts/manual_licenses/enum34/LICENSE"

Review comment:
       did you `git add` the LICENSE file? Also, it would be great if you send a PR for master with these commit(s). Thanks! 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675758420


   note that precommit IT tests will fail until Dataflow containers for the release branch are built. This change does not affect Dataflow codepath.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] youngoli commented on pull request #12619: [BEAM-10702, BEAM-10757] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
youngoli commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675821375






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675768399


   ```
   ERROR:root:Error occurred when pull license for enum34 from {'license': 'https://bitbucket.org/stoneleaf/enum34/raw/c208549a93b71b948ff7bbdfd29dce8f85527916/enum/LICENSE'}.
   16:06:02 Traceback (most recent call last):
   16:06:02   File "/tmp/license_scripts/pull_licenses_py.py", line 94, in pull_from_url
   16:06:02     url_read = urlopen(config['license'])
   16:06:02   File "/usr/local/lib/python2.7/urllib2.py", line 154, in urlopen
   16:06:02     return opener.open(url, data, timeout)
   16:06:02   File "/usr/local/lib/python2.7/urllib2.py", line 435, in open
   16:06:02     response = meth(req, response)
   16:06:02   File "/usr/local/lib/python2.7/urllib2.py", line 548, in http_response
   16:06:02     'http', request, response, code, msg, hdrs)
   16:06:02   File "/usr/local/lib/python2.7/urllib2.py", line 473, in error
   16:06:02     return self._call_chain(*args)
   16:06:02   File "/usr/local/lib/python2.7/urllib2.py", line 407, in _call_chain
   16:06:02     result = func(*args)
   16:06:02   File "/usr/local/lib/python2.7/urllib2.py", line 556, in http_error_default
   ```
   We would need to change how we fetch the license for enum34. This must be blocking precommits now on master as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] jkff commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
jkff commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675771341


   Yeah it'll have to be added to manual_licenses. I'll do that in this PR in a moment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn removed a comment on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn removed a comment on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675727207


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] youngoli merged pull request #12619: [BEAM-10702, BEAM-10757] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
youngoli merged pull request #12619:
URL: https://github.com/apache/beam/pull/12619


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675771710


   Opened https://issues.apache.org/jira/browse/BEAM-10757


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] jkff commented on a change in pull request #12619: [BEAM-10702, BEAM-10757] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
jkff commented on a change in pull request #12619:
URL: https://github.com/apache/beam/pull/12619#discussion_r472557824



##########
File path: sdks/python/container/license_scripts/dep_urls_py.yaml
##########
@@ -48,7 +48,9 @@ pip_dependencies:
   cython:
     license: "https://raw.githubusercontent.com/cython/cython/master/LICENSE.txt"
   enum34:
-    license: "https://bitbucket.org/stoneleaf/enum34/raw/c208549a93b71b948ff7bbdfd29dce8f85527916/enum/LICENSE"
+    # The original repo is down. This license taken from somebody's clone:
+    # https://github.com/jamespharaoh/python-enum34/blob/master/enum/LICENSE
+    license: "file:///tmp/license_scripts/manual_licenses/enum34/LICENSE"

Review comment:
       https://github.com/apache/beam/pull/12624




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675727385


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] jkff commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
jkff commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675759606


   Retesting cause https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Commit/12849/consoleFull shows an error in `:sdks:python:container:py2:docker` but it passes when I run this target locally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn edited a comment on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn edited a comment on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675758420


   @youngoli note that precommit IT tests will fail until Dataflow containers for the release branch are built. This change does not affect Dataflow codepath.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] jkff commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
jkff commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675759470


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] jkff commented on pull request #12619: [BEAM-10702, BEAM-10757] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
jkff commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-676569143


   Alright, we now have 2 failing precommits both due to known issues: Python with BEAM-10697, and PythonDocs because it doesn't exist at 2.24. Looks like BEAM-10697 is resolved, I'm gonna rebase on latest 2.24 and see if that fixes it for the current PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] jkff commented on a change in pull request #12619: [BEAM-10702, BEAM-10757] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
jkff commented on a change in pull request #12619:
URL: https://github.com/apache/beam/pull/12619#discussion_r472556970



##########
File path: sdks/python/container/license_scripts/dep_urls_py.yaml
##########
@@ -48,7 +48,9 @@ pip_dependencies:
   cython:
     license: "https://raw.githubusercontent.com/cython/cython/master/LICENSE.txt"
   enum34:
-    license: "https://bitbucket.org/stoneleaf/enum34/raw/c208549a93b71b948ff7bbdfd29dce8f85527916/enum/LICENSE"
+    # The original repo is down. This license taken from somebody's clone:
+    # https://github.com/jamespharaoh/python-enum34/blob/master/enum/LICENSE
+    license: "file:///tmp/license_scripts/manual_licenses/enum34/LICENSE"

Review comment:
       Oops, added now, thanks! Will send a separate PR to master. Do you prefer if I remove it from here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675771871


   thanks, @jkff, will assign that to you then.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] jkff commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
jkff commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675725302


   Hmm all the builds are pending apparently cause something's going on with Jenkins - eg https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Commit/ says "Jenkins is going to shut down". Haven't seen this before. Do I need to do anything?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] youngoli commented on pull request #12619: [BEAM-10702, BEAM-10757] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
youngoli commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-676813086


   Yeah, I think it's safe to ignore the Python precommit error here. I'll merge it in.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675727168






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675767547


   Run PythonDocker PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn commented on pull request #12619: [BEAM-10702] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675769679


   @ethanfurman FYI, the project homepage link (https://bitbucket.org/stoneleaf/enum34)  at https://pypi.org/project/enum34/ is now broken.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tvalentyn commented on a change in pull request #12619: [BEAM-10702, BEAM-10757] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #12619:
URL: https://github.com/apache/beam/pull/12619#discussion_r472557379



##########
File path: sdks/python/container/license_scripts/dep_urls_py.yaml
##########
@@ -48,7 +48,9 @@ pip_dependencies:
   cython:
     license: "https://raw.githubusercontent.com/cython/cython/master/LICENSE.txt"
   enum34:
-    license: "https://bitbucket.org/stoneleaf/enum34/raw/c208549a93b71b948ff7bbdfd29dce8f85527916/enum/LICENSE"
+    # The original repo is down. This license taken from somebody's clone:
+    # https://github.com/jamespharaoh/python-enum34/blob/master/enum/LICENSE
+    license: "file:///tmp/license_scripts/manual_licenses/enum34/LICENSE"

Review comment:
       Feel free to keep it here as well, we can merge these into 2.24.0 as two separate commits. Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] jkff edited a comment on pull request #12619: [BEAM-10702, BEAM-10757] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
jkff edited a comment on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-676569143


   Alright, we now have 2 failing precommits both due to known issues: Python with BEAM-10697, and PythonDocs because it doesn't exist at 2.24. Looks like BEAM-10697 is resolved, but not cherrypicked into 2.24. @youngoli  Do you want to ignore it for this PR or should we wait for someone to cherrypick a fix and rebase on that?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] jkff commented on pull request #12619: [BEAM-10702, BEAM-10757] Cherrypick #12571: Do not implicitly decompress artifacts

Posted by GitBox <gi...@apache.org>.
jkff commented on pull request #12619:
URL: https://github.com/apache/beam/pull/12619#issuecomment-675776304


   The PythonDocs precommit is failing because it was only added at master in https://github.com/apache/beam/pull/12575 and isn't present in the 2.24 branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org