You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/16 07:34:45 UTC
[GitHub] [shardingsphere] isHuangXin opened a new pull request, #22203: test(issue-21463): ClearReadwriteSplittingHintStatement
isHuangXin opened a new pull request, #22203:
URL: https://github.com/apache/shardingsphere/pull/22203
For #21463.
Changes proposed in this pull request:
- Add test unit for ClearReadwriteSplittingHintStatement.
Particularly Notes: SQL statement `<distsql-case id="clear-readwrite-splitting-hint-source" value="CLEAR READWRITE_SPLITTING HINT" />`has already been in the XML file `hint.xml`
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #22203: test(issue-21463): ClearReadwriteSplittingHintStatement
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22203:
URL: https://github.com/apache/shardingsphere/pull/22203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22203: test(issue-21463): ClearReadwriteSplittingHintStatement
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22203:
URL: https://github.com/apache/shardingsphere/pull/22203#issuecomment-1316564380
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22203](https://codecov.io/gh/apache/shardingsphere/pull/22203?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc853e9) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e5c8dc7778f79d544935803a7093aee53ea91bf2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e5c8dc7) will **increase** coverage by `0.00%`.
> The diff coverage is `66.66%`.
```diff
@@ Coverage Diff @@
## master #22203 +/- ##
=========================================
Coverage 61.00% 61.00%
- Complexity 2548 2550 +2
=========================================
Files 4125 4126 +1
Lines 57465 57471 +6
Branches 9733 9734 +1
=========================================
+ Hits 35055 35059 +4
- Misses 19448 19449 +1
- Partials 2962 2963 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nt/ClearReadwriteSplittingHintStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/22203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9hc3NlcnRzL3N0YXRlbWVudC9kaXN0c3FsL3JhbC9pbXBsL2hpbnQvQ2xlYXJSZWFkd3JpdGVTcGxpdHRpbmdIaW50U3RhdGVtZW50QXNzZXJ0LmphdmE=) | `50.00% <50.00%> (ø)` | |
| [...ement/distsql/ral/impl/HintRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/22203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9hc3NlcnRzL3N0YXRlbWVudC9kaXN0c3FsL3JhbC9pbXBsL0hpbnRSQUxTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org