You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Norman Maurer <nm...@byteaction.de> on 2006/04/17 10:07:48 UTC
Re: svn commit: r394514 - in
/james/server/trunk/src/java/org/apache/james/smtpserver:
EhloCmdHandler.java HeloCmdHandler.java MailCmdHandler.java
SMTPHandler.java SMTPSession.java
Not notice that solution :-(
Thx...
bye
Norman
Am Montag, den 17.04.2006, 03:15 +0200 schrieb Stefano Bagnara:
> I reverted this patch and changed RSET adding a get/set of the
> CURRENT_HELO_MODE around the session.reset as we also do in SMTPHandler
> after a message has been received.
>
> Less code changed and a common way to solve the same problem in multiple
> classes seems a better solution to me.
>
> Stefano
>
> noel@apache.org wrote:
> > Author: noel
> > Date: Sun Apr 16 10:22:35 2006
> > New Revision: 394514
> >
> > URL: http://svn.apache.org/viewcvs?rev=394514&view=rev
> > Log:
> > Fix JAMES-479, so that RSET no longer invalidates HELO/EHLO check. Also fix line endings in SMTPSession.java
> >
> > Modified:
> > james/server/trunk/src/java/org/apache/james/smtpserver/EhloCmdHandler.java
> > james/server/trunk/src/java/org/apache/james/smtpserver/HeloCmdHandler.java
> > james/server/trunk/src/java/org/apache/james/smtpserver/MailCmdHandler.java
> > james/server/trunk/src/java/org/apache/james/smtpserver/SMTPHandler.java
> > james/server/trunk/src/java/org/apache/james/smtpserver/SMTPSession.java
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
> !EXCUBATOR:1,4442eccc37026128182523!
Re: svn commit: r394514 - in /james/server/trunk/src/java/org/apache/james/smtpserver:
EhloCmdHandler.java HeloCmdHandler.java MailCmdHandler.java SMTPHandler.java
SMTPSession.java
Posted by Stefano Bagnara <ap...@bago.org>.
Norman Maurer wrote:
> Not notice that solution :-(
> Thx...
Don't worry, we're here to review ;-)
Thank you, anyway, for your fast patch to the bug!
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: svn commit: r394514 -
in /james/server/trunk/src/java/org/apache/james/smtpserver:
EhloCmdHandler.java HeloCmdHandler.java
MailCmdHandler.java SMTPHandler.java SMTPSession.java
Posted by Norman Maurer <nm...@byteaction.de>.
Am Montag, den 17.04.2006, 16:25 +0200 schrieb Stefano Bagnara:
> Norman Maurer wrote:
> > Not notice that solution :-(
> > Thx...
>
> Don't worry, we're here to review ;-)
> Thank you, anyway, for your fast patch to the bug!
Im glad to help. James is a great project. Im happy to contribute and
fix bugs.
bye