You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jelmerk (via GitHub)" <gi...@apache.org> on 2023/03/01 07:31:03 UTC

[GitHub] [spark] jelmerk commented on a diff in pull request #40219: [SPARK-42622][CORE] Disable substitution in values

jelmerk commented on code in PR #40219:
URL: https://github.com/apache/spark/pull/40219#discussion_r1121269562


##########
core/src/main/scala/org/apache/spark/ErrorClassesJSONReader.scala:
##########
@@ -47,6 +47,7 @@ class ErrorClassesJsonReader(jsonFileURLs: Seq[URL]) {
     val messageTemplate = getMessageTemplate(errorClass)
     val sub = new StringSubstitutor(messageParameters.asJava)
     sub.setEnableUndefinedVariableException(true)
+    sub.setDisableSubstitutionInValues(true)

Review Comment:
   I added a test in SparkThrowableSuite



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org