You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/29 18:55:02 UTC

[GitHub] [incubator-nuttx] v01d opened a new pull request #2442: [BACKPORT] Documentation: support versioned docs

v01d opened a new pull request #2442:
URL: https://github.com/apache/incubator-nuttx/pull/2442


   ## Summary
   
   10.0 misses this change, which will make 10.x documentation not populate version selector correctly on documentation website
   
   ## Impact
   
   Documentation
   
   ## Testing
   
   CI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2442: [BACKPORT] Documentation: support versioned docs

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2442:
URL: https://github.com/apache/incubator-nuttx/pull/2442#issuecomment-735457974


   Sure we can leave this open for now.  I am about 95% sure we will have our first patch release which we can include this in some time in December.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2442: [BACKPORT] Documentation: support versioned docs

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2442:
URL: https://github.com/apache/incubator-nuttx/pull/2442#issuecomment-735455128


   But if 10.0.1 never sees the day we would just have a dangling commit.  I don't think that's harmful (especially with this change), but I personally find it better and less confusing when the final tag matches the head of the branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #2442: [BACKPORT] Documentation: support versioned docs

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2442:
URL: https://github.com/apache/incubator-nuttx/pull/2442#issuecomment-735438602


   I added this just in case there will be an RC1. But if not, it is really a minor issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton merged pull request #2442: [BACKPORT] Documentation: support versioned docs

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2442:
URL: https://github.com/apache/incubator-nuttx/pull/2442


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2442: [BACKPORT] Documentation: support versioned docs

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2442:
URL: https://github.com/apache/incubator-nuttx/pull/2442#issuecomment-735446515


   I don't think there is a problem merging it here. It just means it would already be staged for 10.0.1 even if 10.0.0-RC0 becomes a release version.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2442: [BACKPORT] Documentation: support versioned docs

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2442:
URL: https://github.com/apache/incubator-nuttx/pull/2442#issuecomment-735442088


   @v01d please make it a draft to avoid an accidental merge that I think will force us to cancel the current RC.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org