[jira] [Resolved] (ARROW-2144) [JS] Don't repeat dictionary lookups in DataFrame ops

["Brian Hulette (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARROW-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Hulette resolved ARROW-2144.
----------------------------------
       Resolution: Fixed
    Fix Version/s: JS-0.3.0

Issue resolved by pull request 1599
[https://github.com/apache/arrow/pull/1599]

> [JS] Don't repeat dictionary lookups in DataFrame ops
> -----------------------------------------------------
>
>                 Key: ARROW-2144
>                 URL: https://issues.apache.org/jira/browse/ARROW-2144
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: JavaScript
>            Reporter: Brian Hulette
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: JS-0.3.0
>
>
> Currently we repeat dictionary lookups every time we bind a new record batch when doing an equality check in a DataFrame op (https://github.com/apache/arrow/blob/master/js/src/predicate.ts#L143).
> In most cases the dictionary won't be changing between record batches, so we should remember these reverse dictionary lookups, either permanently, or at least for the duration of the current operation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)