You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2016/03/17 23:54:33 UTC
[jira] [Comment Edited] (SPARK-13986) Make `DeveloperApi`-annotated
things public
[ https://issues.apache.org/jira/browse/SPARK-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200559#comment-15200559 ]
Dongjoon Hyun edited comment on SPARK-13986 at 3/17/16 10:53 PM:
-----------------------------------------------------------------
Oh, that's a great idea. For this, I found them by just regular-expression search in IntelliJ.
For style checking, we need to add a `ScalaStyle` rule and Maven CheckStyle rule since I've seen some `@DeveloperApi` in Java code, too.
By the way, Maven CheckStyle checking is not ran automatically as of today.
was (Author: dongjoon):
Oh, that's a great idea. For this, I found just regular-expression search in IntelliJ.
For style checking, we need to add a `ScalaStyle` rule and Maven CheckStyle rule since I've seen some `@DeveloperApi` in Java code, too.
By the way, Maven CheckStyle checking is not ran automatically as of today.
> Make `DeveloperApi`-annotated things public
> -------------------------------------------
>
> Key: SPARK-13986
> URL: https://issues.apache.org/jira/browse/SPARK-13986
> Project: Spark
> Issue Type: Improvement
> Components: MLlib, Spark Core
> Reporter: Dongjoon Hyun
> Priority: Minor
>
> Spark uses `@DeveloperApi` annotation, but sometimes it seems to conflict with its visibility. This issue proposes to fix those conflict. The following is the example.
> {code:title=JobResult.scala|borderStyle=solid}
> @DeveloperApi
> sealed trait JobResult
> @DeveloperApi
> case object JobSucceeded extends JobResult
> @DeveloperApi
> -private[spark] case class JobFailed(exception: Exception) extends JobResult
> +case class JobFailed(exception: Exception) extends JobResult
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org