You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mark Wang <ma...@gmail.com> on 2015/07/06 17:04:57 UTC
Re: Review Request 35287: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (stout)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
-----------------------------------------------------------
(Updated July 6, 2015, 3:04 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
rebase
Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800
Repository: mesos
Description
-------
Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (stout)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9
3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp c8d30d8c193eb14f7accfde4fe02ce0710cd1817
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp f1ae80ab881ccfcefda69d5bfee2d969d171f1b9
Diff: https://reviews.apache.org/r/35287/diff/
Testing
-------
make check
Thanks,
Mark Wang
Re: Review Request 35287: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (stout)
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review90536
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On July 6, 2015, 6:46 p.m., Mark Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35287/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 6:46 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-2800
> https://issues.apache.org/jira/browse/MESOS-2800
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (stout)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 3d9b7a7568de6734097733f4e6d59acba629b849
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 784104f26ceee2ef90709056a5f4428d48390c36
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp d87cf22dbb98e1ac99f129668ad984a1542e4ec9
>
> Diff: https://reviews.apache.org/r/35287/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Mark Wang
>
>
Re: Review Request 35287: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (stout)
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review90545
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 6, 2015, 6:46 p.m., Mark Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35287/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 6:46 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-2800
> https://issues.apache.org/jira/browse/MESOS-2800
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (stout)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 3d9b7a7568de6734097733f4e6d59acba629b849
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 784104f26ceee2ef90709056a5f4428d48390c36
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp d87cf22dbb98e1ac99f129668ad984a1542e4ec9
>
> Diff: https://reviews.apache.org/r/35287/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Mark Wang
>
>
Re: Review Request 35287: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (stout)
Posted by Mark Wang <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
-----------------------------------------------------------
(Updated July 6, 2015, 6:46 p.m.)
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800
Repository: mesos
Description
-------
Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (stout)
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 3d9b7a7568de6734097733f4e6d59acba629b849
3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 784104f26ceee2ef90709056a5f4428d48390c36
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp d87cf22dbb98e1ac99f129668ad984a1542e4ec9
Diff: https://reviews.apache.org/r/35287/diff/
Testing
-------
make check
Thanks,
Mark Wang
Re: Review Request 35287: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (stout)
Posted by Mark Wang <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
-----------------------------------------------------------
(Updated July 6, 2015, 6:45 p.m.)
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800
Repository: mesos
Description
-------
Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (stout)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 3d9b7a7568de6734097733f4e6d59acba629b849
3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 784104f26ceee2ef90709056a5f4428d48390c36
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp d87cf22dbb98e1ac99f129668ad984a1542e4ec9
Diff: https://reviews.apache.org/r/35287/diff/
Testing
-------
make check
Thanks,
Mark Wang
Re: Review Request 35287: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (stout)
Posted by Mark Wang <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
-----------------------------------------------------------
(Updated July 6, 2015, 6:32 p.m.)
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800
Repository: mesos
Description
-------
Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (stout)
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 3d9b7a7568de6734097733f4e6d59acba629b849
3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 784104f26ceee2ef90709056a5f4428d48390c36
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp d87cf22dbb98e1ac99f129668ad984a1542e4ec9
3rdparty/libprocess/src/subprocess.cpp 5b41f0d88fcab93d51d5c503f69faccedc210868
Diff: https://reviews.apache.org/r/35287/diff/
Testing
-------
make check
Thanks,
Mark Wang
Re: Review Request 35287: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (stout)
Posted by Mark Wang <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
-----------------------------------------------------------
(Updated July 6, 2015, 6 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
merge conflict
Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800
Repository: mesos
Description
-------
Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (stout)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 3d9b7a7568de6734097733f4e6d59acba629b849
3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 784104f26ceee2ef90709056a5f4428d48390c36
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp d87cf22dbb98e1ac99f129668ad984a1542e4ec9
3rdparty/libprocess/src/subprocess.cpp 5b41f0d88fcab93d51d5c503f69faccedc210868
Diff: https://reviews.apache.org/r/35287/diff/
Testing
-------
make check
Thanks,
Mark Wang
Re: Review Request 35287: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (stout)
Posted by Michael Park <mc...@gmail.com>.
Hey Mark,
First off, thanks for these patches! I appreciate you taking the time to
fix this.
Second, I think the review chain is reversed currently. The *stout* changes
should be the start of the chain, as it has the introduction of
*getOrElse* function.
So if you could flip it around to be *stout -> libprocess -> mesos*, I
think ReviewBot will be happier :)
Thanks,
MPark.
On Mon, Jul 6, 2015 at 1:08 PM Mesos ReviewBot <re...@mesos.apache.org>
wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35287/#review90499
> -----------------------------------------------------------
>
>
> Bad patch!
>
> Reviews applied: [35285, 35286]
>
> Failed command: ./support/apply-review.sh -n -r 35286
>
> Error:
> 2015-07-06 17:08:20 URL:https://reviews.apache.org/r/35286/diff/raw/
> [1598/1598] -> "35286.patch" [1]
> error: patch failed: 3rdparty/libprocess/src/subprocess.cpp:327
> error: 3rdparty/libprocess/src/subprocess.cpp: patch does not apply
> Failed to apply patch
>
> - Mesos ReviewBot
>
>
> On July 6, 2015, 3:04 p.m., Mark Wang wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/35287/
> > -----------------------------------------------------------
> >
> > (Updated July 6, 2015, 3:04 p.m.)
> >
> >
> > Review request for mesos and Joris Van Remoortere.
> >
> >
> > Bugs: MESOS-2800
> > https://issues.apache.org/jira/browse/MESOS-2800
> >
> >
> > Repository: mesos
> >
> >
> > Description
> > -------
> >
> > Rename Option<T>::get(const T& _t) to getOrElse() and refactor original
> functions (stout)
> >
> >
> > Diffs
> > -----
> >
> > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp
> 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp
> c8d30d8c193eb14f7accfde4fe02ce0710cd1817
> > 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp
> f1ae80ab881ccfcefda69d5bfee2d969d171f1b9
> >
> > Diff: https://reviews.apache.org/r/35287/diff/
> >
> >
> > Testing
> > -------
> >
> > make check
> >
> >
> > Thanks,
> >
> > Mark Wang
> >
> >
>
>
Re: Review Request 35287: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (stout)
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review90499
-----------------------------------------------------------
Bad patch!
Reviews applied: [35285, 35286]
Failed command: ./support/apply-review.sh -n -r 35286
Error:
2015-07-06 17:08:20 URL:https://reviews.apache.org/r/35286/diff/raw/ [1598/1598] -> "35286.patch" [1]
error: patch failed: 3rdparty/libprocess/src/subprocess.cpp:327
error: 3rdparty/libprocess/src/subprocess.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On July 6, 2015, 3:04 p.m., Mark Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35287/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 3:04 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-2800
> https://issues.apache.org/jira/browse/MESOS-2800
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (stout)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp c8d30d8c193eb14f7accfde4fe02ce0710cd1817
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp f1ae80ab881ccfcefda69d5bfee2d969d171f1b9
>
> Diff: https://reviews.apache.org/r/35287/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Mark Wang
>
>
Re: Review Request 35287: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (stout)
Posted by Mark Wang <ma...@gmail.com>.
> On July 6, 2015, 5:23 p.m., Joris Van Remoortere wrote:
> > Hi Mark,
> > Can you please make sure to rebase and post-review all of the patches in the dependency chain? The build bot will keep reporting this conflict until it can apply the patches in the order it reports in its review.
Yea, I resolved the conflict.
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review90504
-----------------------------------------------------------
On July 6, 2015, 6 p.m., Mark Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35287/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 6 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-2800
> https://issues.apache.org/jira/browse/MESOS-2800
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (stout)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 3d9b7a7568de6734097733f4e6d59acba629b849
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 784104f26ceee2ef90709056a5f4428d48390c36
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp d87cf22dbb98e1ac99f129668ad984a1542e4ec9
> 3rdparty/libprocess/src/subprocess.cpp 5b41f0d88fcab93d51d5c503f69faccedc210868
>
> Diff: https://reviews.apache.org/r/35287/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Mark Wang
>
>
Re: Review Request 35287: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (stout)
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review90504
-----------------------------------------------------------
Hi Mark,
Can you please make sure to rebase and post-review all of the patches in the dependency chain? The build bot will keep reporting this conflict until it can apply the patches in the order it reports in its review.
- Joris Van Remoortere
On July 6, 2015, 3:04 p.m., Mark Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35287/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 3:04 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-2800
> https://issues.apache.org/jira/browse/MESOS-2800
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (stout)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp c8d30d8c193eb14f7accfde4fe02ce0710cd1817
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp f1ae80ab881ccfcefda69d5bfee2d969d171f1b9
>
> Diff: https://reviews.apache.org/r/35287/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Mark Wang
>
>