[GitHub] [hive] cnauroth commented on pull request #3873: HIVE-26869 : Backport of HIVE-25250: Fix TestHS2ImpersonationWithRemoteMS.testImpersonation

[GitBox <gi...@apache.org>]

cnauroth commented on PR #3873:
URL: https://github.com/apache/hive/pull/3873#issuecomment-1370361462

   @amanraj2520 , I don't think [HDFS-13408](https://issues.apache.org/jira/browse/HDFS-13408) would be related, because I think that was a problem specific to Windows, and this test seems to be having a problem handling the parameterized warehouse directory, not the base testing directory.
   
   I think I figured it out. [`MetaStoreTestUtils#startMetaStoreWithRetry`](https://github.com/apache/hive/blob/branch-3/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/MetaStoreTestUtils.java#L108) sets the warehouse directory as the new `metastore.warehouse.dir` property. [`AbstractHiveService#get/setWareHouseDir`](https://github.com/apache/hive/blob/branch-3/itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java#L92-L100) later works with the deprecated `hive.metastore.warehouse.dir` property. `MetastoreConf` will take care of resolving requests for the new property to values under the old property, but not vice versa.
   
   I found that on master, [HIVE-19104](https://issues.apache.org/jira/browse/HIVE-19104) included an additional line in [MiniHs2](https://github.com/apache/hive/blob/master/itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java#L378) to make sure these 2 properties would stay in sync for test runs. I can get `TestHS2ImpersonationWithRemoteMS` to pass after applying a slightly modified version of that patch.
   
   I'll let you know when I have a pull request ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org