You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/09/29 11:34:05 UTC
[GitHub] [phoenix-connectors] stoty commented on a change in pull request #31: PHOENIX-6161 Update the building part of documentation for Phoenix Co…
stoty commented on a change in pull request #31:
URL: https://github.com/apache/phoenix-connectors/pull/31#discussion_r496632599
##########
File path: README.md
##########
@@ -20,3 +20,45 @@ limitations under the License.
<b>[Apache Phoenix](http://phoenix.apache.org/)</b> enables OLTP and operational analytics in Hadoop for low latency applications. Visit the Apache Phoenix website <b>[here](http://phoenix.apache.org/)</b>. This repo contains connectors for third party libraries to access data stored in Phoenix/HBase.
Copyright ©2019 [Apache Software Foundation](http://www.apache.org/). All Rights Reserved.
+
Review comment:
Our convention is to put this information BUILDING.md, not README.md
##########
File path: README.md
##########
@@ -20,3 +20,45 @@ limitations under the License.
<b>[Apache Phoenix](http://phoenix.apache.org/)</b> enables OLTP and operational analytics in Hadoop for low latency applications. Visit the Apache Phoenix website <b>[here](http://phoenix.apache.org/)</b>. This repo contains connectors for third party libraries to access data stored in Phoenix/HBase.
Copyright ©2019 [Apache Software Foundation](http://www.apache.org/). All Rights Reserved.
+
+## Introduction
+This repo contains Flume, Pig, Kafka, Spark and Hive connectors for Phoenix 4 and for Phoenix 5.
Review comment:
This repo contains the Flume, Pig, Kafka, Spark and Hive connectors for Phoenix.
##########
File path: README.md
##########
@@ -20,3 +20,45 @@ limitations under the License.
<b>[Apache Phoenix](http://phoenix.apache.org/)</b> enables OLTP and operational analytics in Hadoop for low latency applications. Visit the Apache Phoenix website <b>[here](http://phoenix.apache.org/)</b>. This repo contains connectors for third party libraries to access data stored in Phoenix/HBase.
Copyright ©2019 [Apache Software Foundation](http://www.apache.org/). All Rights Reserved.
+
+## Introduction
+This repo contains Flume, Pig, Kafka, Spark and Hive connectors for Phoenix 4 and for Phoenix 5.
+
+
+## Building
+
+This repository will build jars for the different phoenix connectors.
+Connectors for Phoenix 4 use Hadoop 2 and HBase 4 meanwhile Phoenix 5 provides compatibility for Hadoop 3 and Hbase 5.
+All Phoenix 4 and Phoenix 5 connectros are built in succession.
+
+```
+$ mvn package
+```
+
+### Building against specific Phoenix version
+To build a release of Phoenix Connectors`` which packages a specific version of Phoenix, specify the `phoenix-four.version` or the `phoenix-five.version` system property to indicate a specific Phoenix version.
Review comment:
the double backtick is not necessary
##########
File path: README.md
##########
@@ -20,3 +20,45 @@ limitations under the License.
<b>[Apache Phoenix](http://phoenix.apache.org/)</b> enables OLTP and operational analytics in Hadoop for low latency applications. Visit the Apache Phoenix website <b>[here](http://phoenix.apache.org/)</b>. This repo contains connectors for third party libraries to access data stored in Phoenix/HBase.
Copyright ©2019 [Apache Software Foundation](http://www.apache.org/). All Rights Reserved.
+
+## Introduction
+This repo contains Flume, Pig, Kafka, Spark and Hive connectors for Phoenix 4 and for Phoenix 5.
+
+
+## Building
+
+This repository will build jars for the different phoenix connectors.
+Connectors for Phoenix 4 use Hadoop 2 and HBase 4 meanwhile Phoenix 5 provides compatibility for Hadoop 3 and Hbase 5.
+All Phoenix 4 and Phoenix 5 connectros are built in succession.
+
+```
+$ mvn package
+```
+
+### Building against specific Phoenix version
+To build a release of Phoenix Connectors`` which packages a specific version of Phoenix, specify the `phoenix-four.version` or the `phoenix-five.version` system property to indicate a specific Phoenix version.
+
+Phoenix Connectos will package the same version of Phoenix used for build/test. This version is controlled by the
Review comment:
typo. Can you run a spell check on this ?
##########
File path: README.md
##########
@@ -20,3 +20,45 @@ limitations under the License.
<b>[Apache Phoenix](http://phoenix.apache.org/)</b> enables OLTP and operational analytics in Hadoop for low latency applications. Visit the Apache Phoenix website <b>[here](http://phoenix.apache.org/)</b>. This repo contains connectors for third party libraries to access data stored in Phoenix/HBase.
Copyright ©2019 [Apache Software Foundation](http://www.apache.org/). All Rights Reserved.
+
+## Introduction
+This repo contains Flume, Pig, Kafka, Spark and Hive connectors for Phoenix 4 and for Phoenix 5.
+
+
+## Building
+
+This repository will build jars for the different phoenix connectors.
+Connectors for Phoenix 4 use Hadoop 2 and HBase 4 meanwhile Phoenix 5 provides compatibility for Hadoop 3 and Hbase 5.
+All Phoenix 4 and Phoenix 5 connectros are built in succession.
Review comment:
I'd prefer:
The standard build process builds the connectors both for Phoenix 4 and Phoenix 5.
##########
File path: README.md
##########
@@ -20,3 +20,45 @@ limitations under the License.
<b>[Apache Phoenix](http://phoenix.apache.org/)</b> enables OLTP and operational analytics in Hadoop for low latency applications. Visit the Apache Phoenix website <b>[here](http://phoenix.apache.org/)</b>. This repo contains connectors for third party libraries to access data stored in Phoenix/HBase.
Copyright ©2019 [Apache Software Foundation](http://www.apache.org/). All Rights Reserved.
+
+## Introduction
+This repo contains Flume, Pig, Kafka, Spark and Hive connectors for Phoenix 4 and for Phoenix 5.
+
+
+## Building
+
+This repository will build jars for the different phoenix connectors.
+Connectors for Phoenix 4 use Hadoop 2 and HBase 4 meanwhile Phoenix 5 provides compatibility for Hadoop 3 and Hbase 5.
Review comment:
Phoenix 4 and Phoenix 5 versions use different Hadoop and HBase versions, and require separate versions of the connectors.
Phoenix 4 requires Hadoop 2.x and HBase 1.x, while Phoenix 5 requires Hadoop 3.x and HBase 2.x
##########
File path: README.md
##########
@@ -20,3 +20,45 @@ limitations under the License.
<b>[Apache Phoenix](http://phoenix.apache.org/)</b> enables OLTP and operational analytics in Hadoop for low latency applications. Visit the Apache Phoenix website <b>[here](http://phoenix.apache.org/)</b>. This repo contains connectors for third party libraries to access data stored in Phoenix/HBase.
Copyright ©2019 [Apache Software Foundation](http://www.apache.org/). All Rights Reserved.
+
+## Introduction
+This repo contains Flume, Pig, Kafka, Spark and Hive connectors for Phoenix 4 and for Phoenix 5.
+
+
+## Building
+
+This repository will build jars for the different phoenix connectors.
Review comment:
Phoenix capitalization
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org