You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/14 20:34:09 UTC

[GitHub] [spark] dongjoon-hyun commented on pull request #25252: [SPARK-28510][SQL] Implement Spark's own GetFunctionsOperation

dongjoon-hyun commented on pull request #25252:
URL: https://github.com/apache/spark/pull/25252#issuecomment-993958624


   It sounds like you have a different meaning of a **breaking** change. When a function suddenly returns different values, it is considered a breaking change to me.
   > This results in hundreds of thousands of rows that slow down the UI. That being said, it doesn't look like a breaking change to me, 
   
   BTW, I agree with your requirements. You might introduce a new internal configuration to add the behavior you want. The default should be the legacy behavior at least for one release, e.g., Apache Spark 3.3, and we need to add it to the SQL migration guide.
   
   WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org