[GitHub] [incubator-superset] mistercrunch commented on pull request #9794: feat: implement create view as functionality in Sqllab

[GitBox <gi...@apache.org>]

mistercrunch commented on pull request #9794:
URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-646155585


   Quick note that SIP-34 does not take CTAS into account. It's probably been missed since it's behind a feature flag (a database configuration flag really...).
   
   <img width="1509" alt="Screen Shot 2020-06-18 at 9 36 13 AM" src="https://user-images.githubusercontent.com/487433/85047848-3f3d5580-b147-11ea-985b-8eef26777151.png">
   
   Personally my incline would be - for now - to expand the current `SAVE` button with a btn-`dropdown` that goes `Save Query` (the default), `CREATE TABLE AS`, and `CREATE VIEW AS`. If picking option 2 or 3 it needs to prompt for a name.
   
   @Steejay what do you think? Also it would be good to find the longer term solution and incorporate to the Figma designs


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org