You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by jiazhai <gi...@git.apache.org> on 2017/06/25 08:51:37 UTC

[GitHub] bookkeeper pull request #213: Issue 212: change github PR template to adjust...

GitHub user jiazhai opened a pull request:

    https://github.com/apache/bookkeeper/pull/213

    Issue 212: change github PR template to adjust both issue# and jira#

    Descriptions of the changes in this PR:
    Change PR template to adjust both issue# and jira#
    
    ---
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
    - [x] Make sure the PR title is formatted like:
        `<Issue #>: Description of pull request`
        `e.g. Issue 123: Description ...`
    - [x] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`.
    - [x] Replace `<Issue #>` in the title with the actual Issue number, if there is one.
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jiazhai/bookkeeper-1 change_template

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #213
    
----
commit ee571dd6ffcef50cd4eef3df88ac08e66dd62f09
Author: jiazhai <zh...@live.com>
Date:   2017-06-25T08:42:19Z

    change PR template to adjust both issue# and jira#

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper pull request #213: Issue 212: change github PR template to adjust...

Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli closed the pull request at:

    https://github.com/apache/bookkeeper/pull/213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper issue #213: Issue 212: change github PR template to adjust both i...

Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:

    https://github.com/apache/bookkeeper/pull/213
  
    LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper issue #213: Issue 212: change github PR template to adjust both i...

Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:

    https://github.com/apache/bookkeeper/pull/213
  
    this closes issue #212


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---