You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/17 02:23:02 UTC

[GitHub] [skywalking-eyes] kezhenxu94 commented on pull request #87: Add MPL-2.0 header template

kezhenxu94 commented on pull request #87:
URL: https://github.com/apache/skywalking-eyes/pull/87#issuecomment-1014079627


   Thank you @steveklabnik for opening this PR and @MoGuGuai-hzr for reviewing!!!
   
   The changes looks good to me. As for the tests, now we just want to test the mechanism that finding license header and comparing the header works, adding tests for each license might be boring and duplicating so I don't require (nor reject) it if anyone would like to add.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org