You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/11/05 00:09:06 UTC
[GitHub] incubator-brooklyn pull request: Fix more integration tests
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/300
Fix more integration tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/IntegrationTests-20141104b
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #300
----
commit 1a9636ac9e2eec4cfa6486320befe82fe2b0d8ca
Author: Aled Sage <al...@gmail.com>
Date: 2014-11-04T22:31:17Z
Add comment to RebindCatalogEntityTest about failure
- Non-deterministic failure seen once on jenkins
commit 00dd84c5b6dcd031ded199810160e10532470849
Author: Aled Sage <al...@gmail.com>
Date: 2014-11-04T22:31:58Z
Fix MonitIntegrationTest
- monitmysqlwithrestart.monitrc was previously hard-coding OS X!
commit 467b9f7a685335d6b7134dba1a07b55b6c2ece09
Author: Aled Sage <al...@gmail.com>
Date: 2014-11-04T22:33:40Z
NodeJs: test tidy
commit 5f4cc2d3b7c66b5dde0939d0e9a9aefb62f366cb
Author: Aled Sage <al...@gmail.com>
Date: 2014-11-04T22:56:15Z
DynamicSequentialTask: handle queue() when task failed
- Previously, in NodeJs’s test detectFailureIfNodeJsBindToPort, it
would fail non-deterministically because of wrong exception being
propagated.
- If an error occurred in a sub-task, and then the main task’s thread
called queue(), that call would fail. That failure would be
propagated instead of the more interesting child exception.
commit 3eb86535f4b507c892a8912febf0574ec9851df7
Author: Aled Sage <al...@gmail.com>
Date: 2014-11-04T23:06:58Z
On rmi registry port not available, log what config said
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix more integration tests
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/300#issuecomment-61737978
@aledsage :frog:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix more integration tests
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/300#issuecomment-61738007
Good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix more integration tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix more integration tests
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/300#issuecomment-61739817
Failed jenkins was due to `DynamicWebAppClusterTest.testTestJavaWebAppEntityStarts`. That is now fixed in latest commit.
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix more integration tests
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/300#discussion_r19846569
--- Diff: software/monitoring/src/test/java/brooklyn/entity/monitoring/monit/MonitIntegrationTest.java ---
@@ -117,7 +119,21 @@ public void run() {
}
@Test(groups = "Integration")
- public void test_monitorMySqlAutoRestart() throws InterruptedException {
+ public void test_monitorMySqlAutoRestart() throws Exception {
+ // This runs on localhost; free to obtain another machine with impunity.
+ final String osFlavor;
+ MachineDetails machineDetails = app.getExecutionContext().submit(new Callable<MachineDetails>() {
+ public MachineDetails call() throws Exception {
+ return loc.obtain().getMachineDetails();
+ }}).get();
+ if (machineDetails.getOsDetails().isMac()) {
+ osFlavor = "osx10.6-x86_64";
--- End diff --
A little bit arbitrary? Or is 10.6 the only version _monit_ is available for?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---