You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@crunch.apache.org by Michael Linthicum <mp...@gmail.com> on 2018/01/18 20:09:06 UTC
DataBaseSource.Builder methods are not public
I was trying to set up a DataBaseSource object [1] and ran into an issue.
None of the methods for the builder are marked public except for
inputClass, so none of the methods except for that are accessible. I was
wondering if this was expected behavior due to a reason that isn't
immediately apparent or if this is a bug. At first glance it just looks
like a simple mistake.
My current workaround is to set up my package namespace as the same as the
DataBaseSource namespace. The type seems to function as intended, so I
don't think keeping the methods private was done to close off some
incomplete code. Thanks.
[1] https://git-wip-us.apache.org/repos/asf?p=crunch.git;a=
blob;f=crunch-contrib/src/main/java/org/apache/crunch/contrib/io/jdbc/
DataBaseSource.java;h=2c5d8d55a2812dcfbc32a341f6198eae3a1612dd;hb=
590943eaaa75f2297b7a50ab3442c82702cfe131
Re: DataBaseSource.Builder methods are not public
Posted by Josh Wills <jo...@gmail.com>.
https://issues.apache.org/jira/browse/CRUNCH-661 for this; I'm going to run
tests and then merge to master. Thanks for the heads up Michael!
On Thu, Jan 18, 2018 at 1:08 PM, Josh Wills <jo...@gmail.com> wrote:
> Ack, totally possible that it's a mistake; lemme take a look.
>
> J
>
> On Thu, Jan 18, 2018 at 12:09 PM, Michael Linthicum <mplinthicum@gmail.com
> > wrote:
>
>> I was trying to set up a DataBaseSource object [1] and ran into an
>> issue. None of the methods for the builder are marked public except for
>> inputClass, so none of the methods except for that are accessible. I was
>> wondering if this was expected behavior due to a reason that isn't
>> immediately apparent or if this is a bug. At first glance it just looks
>> like a simple mistake.
>>
>> My current workaround is to set up my package namespace as the same as
>> the DataBaseSource namespace. The type seems to function as intended, so I
>> don't think keeping the methods private was done to close off some
>> incomplete code. Thanks.
>>
>> [1] https://git-wip-us.apache.org/repos/asf?p=crunch.git;a=b
>> lob;f=crunch-contrib/src/main/java/org/apache/crunch/contrib
>> /io/jdbc/DataBaseSource.java;h=2c5d8d55a2812dcfbc32a341f6198
>> eae3a1612dd;hb=590943eaaa75f2297b7a50ab3442c82702cfe131
>>
>>
>
Re: DataBaseSource.Builder methods are not public
Posted by Josh Wills <jo...@gmail.com>.
Ack, totally possible that it's a mistake; lemme take a look.
J
On Thu, Jan 18, 2018 at 12:09 PM, Michael Linthicum <mp...@gmail.com>
wrote:
> I was trying to set up a DataBaseSource object [1] and ran into an issue.
> None of the methods for the builder are marked public except for
> inputClass, so none of the methods except for that are accessible. I was
> wondering if this was expected behavior due to a reason that isn't
> immediately apparent or if this is a bug. At first glance it just looks
> like a simple mistake.
>
> My current workaround is to set up my package namespace as the same as the
> DataBaseSource namespace. The type seems to function as intended, so I
> don't think keeping the methods private was done to close off some
> incomplete code. Thanks.
>
> [1] https://git-wip-us.apache.org/repos/asf?p=crunch.git;a=b
> lob;f=crunch-contrib/src/main/java/org/apache/crunch/contrib
> /io/jdbc/DataBaseSource.java;h=2c5d8d55a2812dcfbc32a341f619
> 8eae3a1612dd;hb=590943eaaa75f2297b7a50ab3442c82702cfe131
>
>