You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/16 12:57:45 UTC
[GitHub] [airflow] uranusjr opened a new pull request #19616: Declare data interval fields as serializable
uranusjr opened a new pull request #19616:
URL: https://github.com/apache/airflow/pull/19616
So they are available in PythonVirtualenvOperator. Also added a few more keys that are trivially serializable but was missing previously.
A test is added to make sure we declare all keys so this does not happen again in the future.
See #9394
I’m not really sure why exactly `ti` and `task_instance` are not being serialised. Those exist back when #9394 was implemented so they seem to be omitted intentionally? But I didn’t see any discussion on the decision.
`ds` was also omitted for some reason, but it’s just a string so I just added it.
cc @eladkal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19616: Declare data interval fields as serializable
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19616:
URL: https://github.com/apache/airflow/pull/19616#issuecomment-970359068
Isn't that the same case here: https://github.com/apache/airflow/issues/19618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19616: Declare data interval fields as serializable
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19616:
URL: https://github.com/apache/airflow/pull/19616#issuecomment-970360111
> Isn't that the same case here: #19618
Doesn't look like - as execution_date was alredy there ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #19616: Declare data interval fields as serializable
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19616:
URL: https://github.com/apache/airflow/pull/19616#issuecomment-970365759
Yeah that one is a different issue, probably due to we changing the variable to a lazy proxy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #19616: Declare data interval fields as serializable
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19616:
URL: https://github.com/apache/airflow/pull/19616#issuecomment-970271091
#12985 is another issue related to the `ti` key. If we end up adding it to the list of serialisable fields, we can close that issue as fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19616: Declare data interval fields as serializable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19616:
URL: https://github.com/apache/airflow/pull/19616#issuecomment-970261411
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #19616: Declare data interval fields as serializable
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #19616:
URL: https://github.com/apache/airflow/pull/19616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org