You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2019/09/30 19:40:57 UTC
[isis] branch v2 updated: ISIS-2158: minor polishing
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch v2
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/v2 by this push:
new 3cf4a33 ISIS-2158: minor polishing
3cf4a33 is described below
commit 3cf4a33bb9d71724cdd81d5521091aadea1328d1
Author: Andi Huber <ah...@apache.org>
AuthorDate: Mon Sep 30 21:40:48 2019 +0200
ISIS-2158: minor polishing
---
.../isis/runtime/system/context/session/RuntimeEventService.java | 2 +-
.../isis/runtime/system/session/IsisSessionFactoryDefault.java | 7 ++-----
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/core/runtime/src/main/java/org/apache/isis/runtime/system/context/session/RuntimeEventService.java b/core/runtime/src/main/java/org/apache/isis/runtime/system/context/session/RuntimeEventService.java
index 6d9f885..02d557a 100644
--- a/core/runtime/src/main/java/org/apache/isis/runtime/system/context/session/RuntimeEventService.java
+++ b/core/runtime/src/main/java/org/apache/isis/runtime/system/context/session/RuntimeEventService.java
@@ -28,7 +28,7 @@ import org.apache.isis.runtime.system.session.IsisSession;
/**
*
* @since 2.0
- * @implNote Listeners to runtime events can only reliably receive this after the
+ * @implNote Listeners to runtime events can only reliably receive these after the
* post-construct phase has finished!
*/
@Service
diff --git a/core/runtime/src/main/java/org/apache/isis/runtime/system/session/IsisSessionFactoryDefault.java b/core/runtime/src/main/java/org/apache/isis/runtime/system/session/IsisSessionFactoryDefault.java
index d74d59e..5dc5554 100644
--- a/core/runtime/src/main/java/org/apache/isis/runtime/system/session/IsisSessionFactoryDefault.java
+++ b/core/runtime/src/main/java/org/apache/isis/runtime/system/session/IsisSessionFactoryDefault.java
@@ -99,16 +99,13 @@ public class IsisSessionFactoryDefault implements IsisSessionFactory {
localeInitializer.initLocale(configuration);
timeZoneInitializer.initTimeZone(configuration);
- val runtimeEventService = serviceRegistry.lookupServiceElseFail(RuntimeEventService.class);
-
// ... and make IsisSessionFactory available via the IsisContext static for those
// places where we cannot yet inject.
-
_Context.putSingleton(IsisSessionFactory.class, this); //TODO[2112] should no longer be required, since Spring manages this instance
runtimeEventService.fireAppPreMetamodel();
- val taskList = _ConcurrentTaskList.named("IsisSessionFactoryDefault Concurrent Tasks");
+ val taskList = _ConcurrentTaskList.named("IsisSessionFactoryDefault Init");
taskList.addRunnable("SpecificationLoader.init()", this::initMetamodel);
taskList.addRunnable("ChangesDtoUtils.init()", ChangesDtoUtils::init);
@@ -153,7 +150,7 @@ public class IsisSessionFactoryDefault implements IsisSessionFactory {
}
private void validateMetamodel() {
- //TODO[2158] these are all validations, hence should be implemented as validation refiners!
+ //TODO[2158] these are all validations, hence should be implemented as validation refiners?!
//
// translateServicesAndEnumConstants