[GitHub] [airflow] potiuk commented on pull request #29143: Demonstrate usage of the PythonSensor

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on PR #29143:
URL: https://github.com/apache/airflow/pull/29143#issuecomment-1450811879

   @BasPH  Also one more case why having example_dags as "executable" and separate python file here: https://github.com/apache/airflow/pull/28325
   
   Our example dags are actually imported at tested during the CI. Originally the taskflow example dag has failed  when submitted and required some fixes in the test code. So it was a test issue not "airflow core" issue, however it could also be "core" issue, regression that could have been missed in unit tests and only surface at the moment real DAG is parsed/serialized. And IMHO it underlines how important it is to have the example dags as separate python files that can be both - run manually very easily and testsd automatically with every PR.
   
   In Polish, we have the idiom "wylać dziecko z kąpielą" - which freely translated means "to throw away the baby together with the bathing water". Trying to move example_dags to be just part of the docs IMHO is a very good example of that - by trying to improve the docs - the attempt here is to remove example python files that are giving us extra test harness that adds yet another level of making sure our code does what it should do. I'd say we should find a way to improve the docs while keeping the baby.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org