You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/13 17:34:20 UTC
[GitHub] [airflow] match-gabeflores opened a new pull request, #25027: include logical_date in table
match-gabeflores opened a new pull request, #25027:
URL: https://github.com/apache/airflow/pull/25027
surprised logical_date isn't explicitly included in the table, only `{{ ds }}`.
considering the deprecation warning of `{{execution_date}}` says:
> 'execution_date' from the template is deprecated and will be removed in a future version. Please use 'data_interval_start' or 'logical_date' instead.
I looked at the templates documentation and couldn't find 'logical_date'
also updated the jinja filters section to use logical_date
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #25027: include logical_date in table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #25027: include logical_date in table
URL: https://github.com/apache/airflow/pull/25027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25027: include logical_date in table
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25027:
URL: https://github.com/apache/airflow/pull/25027#issuecomment-1183547029
I will leave it to @uranusjr to comment :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #25027: include logical_date in table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #25027:
URL: https://github.com/apache/airflow/pull/25027#issuecomment-1233578724
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #25027: include logical_date in table
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #25027:
URL: https://github.com/apache/airflow/pull/25027#discussion_r922897076
##########
docs/apache-airflow/templates-ref.rst:
##########
@@ -38,6 +38,7 @@ Variable Description
========================================== ====================================
``{{ data_interval_start }}`` Start of the data interval (`pendulum.DateTime`_).
``{{ data_interval_end }}`` End of the data interval (`pendulum.DateTime`_).
+``{{ logical_date }}`` The DAG run's logical date as ``YYYY-MM-DD``.
Review Comment:
This is not right, I believe the value is a DateTime object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #25027: include logical_date in table
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #25027:
URL: https://github.com/apache/airflow/pull/25027#discussion_r922897076
##########
docs/apache-airflow/templates-ref.rst:
##########
@@ -38,6 +38,7 @@ Variable Description
========================================== ====================================
``{{ data_interval_start }}`` Start of the data interval (`pendulum.DateTime`_).
``{{ data_interval_end }}`` End of the data interval (`pendulum.DateTime`_).
+``{{ logical_date }}`` The DAG run's logical date as ``YYYY-MM-DD``.
Review Comment:
This is not right, I believe the value is a DateTime object. Also it should be mentioned this is the same value as both `dag_run.logical_date` and `ti.logical_date`, those two are more explicit names and thus preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25027: include logical_date in table
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25027:
URL: https://github.com/apache/airflow/pull/25027#issuecomment-1183503824
Have you seen "dag_run" and "dag_run.logical_date" everywhere ? Could you please correct the place where the warning is emitted and specify "dag_run.logical_date" instead of "logical_date" ? This seems to be much better fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] match-gabeflores commented on pull request #25027: include logical_date in table
Posted by GitBox <gi...@apache.org>.
match-gabeflores commented on PR #25027:
URL: https://github.com/apache/airflow/pull/25027#issuecomment-1183517243
Oh, interesting. Previously, documentation mentioned` {{ execution_date }}` (without dag_run prefix). There's prob a technical reason for this, but curious why for logical date, it can't similarly be `{{logical_date}}`?
I definitely think we should have this important logical_date/dag_run.logical_date explicitly listed in the Variable column in this table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org