You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/06/29 12:24:10 UTC
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20141
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
KUDU-2724 build macOS mini_cluster binaries on newer macOS
This patch adds cmake flags -DCMAKE_OSX_SYSROOT=macosx
and -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 to build
mini_cluster binaries which can be on macOS 10.13, to
remove the need of building the binaries on the old version
of macOS.
Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
---
M RELEASING.adoc
M build-support/mini-cluster/build_mini_cluster_binaries.sh
2 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/20141/1
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20141 )
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
Patch Set 6:
(1 comment)
> Patch Set 5:
>
> > Patch Set 5:
> >
> > (1 comment)
> >
> > > Patch Set 5:
> > >
> > > build_mini_cluster_binaries.sh seems to fail on ARM macs. (both with and without this patch)
> > > I tried running it, however in relocate_binaries_for_mini_cluster.py it fails with:
> > > IOError: [Errno 2] No such file or directory: u'/usr/lib/libc++abi.dylib'
> > >
> > > I tried the following:
> > >
> > > diff --git a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
> > > index b2028955a..c184e7713 100755
> > > --- a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
> > > +++ b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
> > > @@ -98,7 +98,7 @@ PAT_MACOS_LIB_EXCLUDE = re.compile(r"""(AppleFSCompression$|
> > > libSystem|
> > > libapple_nghttp2|
> > > libarchive|
> > > - libc\+\+\.|
> > > + libc\+\+|
> > > libenergytrace|
> > > libicucore|
> > > libncurses|
> > >
> > > However in this case the prepared binaries have runtime issues.
> > >
> > > For the record I did not run build_mini_cluster_binaries.sh on intel mac, so this might be an ARM issue. Or it is a new macOS/Xcode version issue (things tend to get moved around) Just thought it might be in scope for this patch.
> > >
> > > Can somebody verify that build_mini_cluster_binaries.sh works on Intel? (to make sure that this is an ARM issue)
> >
> >
> > The library '/usr/lib/libc++abi.dylib' seems not found on macOS 12 and 13, but I can find it on macOS 10.15, I'm not sure if there is a update to remove this library of macOS new versions.
>
> Just saw that we already have a ticket to track this issue: KUDU-3436, so this is not the responsibility of this patch. Thanks for clarifying!
Many thanks for your information!
http://gerrit.cloudera.org:8080/#/c/20141/5/build-support/mini-cluster/build_mini_cluster_binaries.sh
File build-support/mini-cluster/build_mini_cluster_binaries.sh:
http://gerrit.cloudera.org:8080/#/c/20141/5/build-support/mini-cluster/build_mini_cluster_binaries.sh@115
PS5, Line 115: -DCMAKE_OSX_DEPLOYMENT_TAR
> Yes, I'll update this later.
Done
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Jul 2023 08:36:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20141 )
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Jul 2023 08:28:19 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yuqi Du, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20141
to look at the new patch set (#4).
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
KUDU-2724 build macOS mini_cluster binaries on newer macOS
This patch adds cmake flags -DCMAKE_OSX_SYSROOT=macosx
and -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13, C and CXX flag
-mmacosx-version-min=10.13 to build mini_cluster binaries
which can be on macOS 10.13, to remove the need of building
the binaries on the old version of macOS.
Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
---
M RELEASING.adoc
M build-support/mini-cluster/build_mini_cluster_binaries.sh
2 files changed, 14 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/20141/4
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/20141 )
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
Patch Set 3: Verified+1 Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Jun 2023 10:40:32 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20141 )
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
Patch Set 6: Code-Review-1
Don't merge, please review this patch instead https://gerrit.cloudera.org/c/20185/
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Jul 2023 12:29:57 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20141
to look at the new patch set (#5).
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
KUDU-2724 build macOS mini_cluster binaries on newer macOS
This patch adds cmake flags -DCMAKE_OSX_SYSROOT=macosx
and -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13, C and CXX flag
-mmacosx-version-min=10.13 to build mini_cluster binaries
which can be on macOS 10.13, to remove the need of building
the binaries on the old version of macOS.
Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
---
M RELEASING.adoc
M build-support/mini-cluster/build_mini_cluster_binaries.sh
2 files changed, 14 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/20141/5
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20141 )
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
Patch Set 5:
> Patch Set 5:
>
> (1 comment)
>
> > Patch Set 5:
> >
> > build_mini_cluster_binaries.sh seems to fail on ARM macs. (both with and without this patch)
> > I tried running it, however in relocate_binaries_for_mini_cluster.py it fails with:
> > IOError: [Errno 2] No such file or directory: u'/usr/lib/libc++abi.dylib'
> >
> > I tried the following:
> >
> > diff --git a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
> > index b2028955a..c184e7713 100755
> > --- a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
> > +++ b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
> > @@ -98,7 +98,7 @@ PAT_MACOS_LIB_EXCLUDE = re.compile(r"""(AppleFSCompression$|
> > libSystem|
> > libapple_nghttp2|
> > libarchive|
> > - libc\+\+\.|
> > + libc\+\+|
> > libenergytrace|
> > libicucore|
> > libncurses|
> >
> > However in this case the prepared binaries have runtime issues.
> >
> > For the record I did not run build_mini_cluster_binaries.sh on intel mac, so this might be an ARM issue. Or it is a new macOS/Xcode version issue (things tend to get moved around) Just thought it might be in scope for this patch.
> >
> > Can somebody verify that build_mini_cluster_binaries.sh works on Intel? (to make sure that this is an ARM issue)
>
>
> The library '/usr/lib/libc++abi.dylib' seems not found on macOS 12 and 13, but I can find it on macOS 10.15, I'm not sure if there is a update to remove this library of macOS new versions.
Just saw that we already have a ticket to track this issue: KUDU-3436, so this is not the responsibility of this patch. Thanks for clarifying!
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Jul 2023 08:28:52 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20141 )
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Jul 2023 11:30:42 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zmartonka@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20141 )
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20141/5/build-support/mini-cluster/build_mini_cluster_binaries.sh
File build-support/mini-cluster/build_mini_cluster_binaries.sh:
http://gerrit.cloudera.org:8080/#/c/20141/5/build-support/mini-cluster/build_mini_cluster_binaries.sh@115
PS5, Line 115: -DCMAKE_OSX_SYSROOT=macosx
Why is the -DCMAKE_OSX_SYSROOT=macosx part needed?
Shouldn't the cmake_osx_deployement_target be sufficient (unless something bad is defined in the SDKROOT env variable)?
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Jul 2023 11:07:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20141
to look at the new patch set (#3).
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
KUDU-2724 build macOS mini_cluster binaries on newer macOS
This patch adds cmake flags -DCMAKE_OSX_SYSROOT=macosx
and -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13, C and CXX flag
-mmacosx-version-min=10.13 to build mini_cluster binaries
which can be on macOS 10.13, to remove the need of building
the binaries on the old version of macOS.
Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
---
M RELEASING.adoc
M build-support/mini-cluster/build_mini_cluster_binaries.sh
2 files changed, 14 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/20141/3
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20141 )
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
Patch Set 5:
build_mini_cluster_binaries.sh seems to fail on ARM macs. (both with and without this patch)
I tried running it, however in relocate_binaries_for_mini_cluster.py it fails with:
IOError: [Errno 2] No such file or directory: u'/usr/lib/libc++abi.dylib'
I tried the following:
diff --git a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
index b2028955a..c184e7713 100755
--- a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
+++ b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
@@ -98,7 +98,7 @@ PAT_MACOS_LIB_EXCLUDE = re.compile(r"""(AppleFSCompression$|
libSystem|
libapple_nghttp2|
libarchive|
- libc\+\+\.|
+ libc\+\+|
libenergytrace|
libicucore|
libncurses|
However in this case the prepared binaries have runtime issues.
For the record I did not run build_mini_cluster_binaries.sh on intel mac, so this might be an ARM issue. Or it is a new macOS/Xcode version issue (things tend to get moved around) Just thought it might be in scope for this patch.
Can somebody verify that build_mini_cluster_binaries.sh works on Intel? (to make sure that this is an ARM issue)
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Jul 2023 12:09:20 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20141 )
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
Patch Set 5:
(1 comment)
> Patch Set 5:
>
> build_mini_cluster_binaries.sh seems to fail on ARM macs. (both with and without this patch)
> I tried running it, however in relocate_binaries_for_mini_cluster.py it fails with:
> IOError: [Errno 2] No such file or directory: u'/usr/lib/libc++abi.dylib'
>
> I tried the following:
>
> diff --git a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
> index b2028955a..c184e7713 100755
> --- a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
> +++ b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
> @@ -98,7 +98,7 @@ PAT_MACOS_LIB_EXCLUDE = re.compile(r"""(AppleFSCompression$|
> libSystem|
> libapple_nghttp2|
> libarchive|
> - libc\+\+\.|
> + libc\+\+|
> libenergytrace|
> libicucore|
> libncurses|
>
> However in this case the prepared binaries have runtime issues.
>
> For the record I did not run build_mini_cluster_binaries.sh on intel mac, so this might be an ARM issue. Or it is a new macOS/Xcode version issue (things tend to get moved around) Just thought it might be in scope for this patch.
>
> Can somebody verify that build_mini_cluster_binaries.sh works on Intel? (to make sure that this is an ARM issue)
The library '/usr/lib/libc++abi.dylib' seems not found on macOS 12 and 13, but I can find it on macOS 10.15, I'm not sure if there is a update to remove this library of macOS new versions.
http://gerrit.cloudera.org:8080/#/c/20141/5/build-support/mini-cluster/build_mini_cluster_binaries.sh
File build-support/mini-cluster/build_mini_cluster_binaries.sh:
http://gerrit.cloudera.org:8080/#/c/20141/5/build-support/mini-cluster/build_mini_cluster_binaries.sh@115
PS5, Line 115: -DCMAKE_OSX_SYSROOT=macosx
> Why is the -DCMAKE_OSX_SYSROOT=macosx part needed?
Yes, I'll update this later.
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Jul 2023 12:49:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20141
to look at the new patch set (#2).
Change subject: WIP KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
WIP KUDU-2724 build macOS mini_cluster binaries on newer macOS
This patch adds cmake flags -DCMAKE_OSX_SYSROOT=macosx
and -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 to build
mini_cluster binaries which can be on macOS 10.13, to
remove the need of building the binaries on the old version
of macOS.
Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
---
M RELEASING.adoc
M build-support/mini-cluster/build_mini_cluster_binaries.sh
2 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/20141/2
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20141 )
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
Patch Set 5: Verified+1
Remove the un-related failed test ConcurrentRebalancersTest.TwoConcurrentRebalancers/0.
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Jul 2023 08:24:13 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2724 build macOS mini cluster binaries on newer macOS
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Yuqi Du, zmartonka@cloudera.com, Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20141
to look at the new patch set (#6).
Change subject: KUDU-2724 build macOS mini_cluster binaries on newer macOS
......................................................................
KUDU-2724 build macOS mini_cluster binaries on newer macOS
This patch adds cmake flags -DCMAKE_OSX_SYSROOT=macosx
and -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13, C and CXX flag
-mmacosx-version-min=10.13 to build mini_cluster binaries
which can be on macOS 10.13, to remove the need of building
the binaries on the old version of macOS.
Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
---
M RELEASING.adoc
M build-support/mini-cluster/build_mini_cluster_binaries.sh
2 files changed, 14 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/20141/6
--
To view, visit http://gerrit.cloudera.org:8080/20141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id7d7ae2c55ffeac2ebc11513e6909bf6b0b8d6d7
Gerrit-Change-Number: 20141
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>