You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by wo...@apache.org on 2004/03/09 15:55:39 UTC
cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler HTTPSampler.java
woolfel 2004/03/09 06:55:39
Modified: src/protocol/http/org/apache/jmeter/protocol/http/sampler
HTTPSampler.java
Log:
when there's an IOException, the URL should still be set. Found this
difference in the process of writing the monitor. I use the URL as
the unique key for each individual serverpanel.
peter lin
Revision Changes Path
1.88 +3 -2 jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java
Index: HTTPSampler.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java,v
retrieving revision 1.87
retrieving revision 1.88
diff -u -r1.87 -r1.88
--- HTTPSampler.java 22 Feb 2004 19:21:41 -0000 1.87
+++ HTTPSampler.java 9 Mar 2004 14:55:39 -0000 1.88
@@ -1164,6 +1164,7 @@
catch (IOException e)
{
res.sampleEnd();
+ res.setURL(url);
return errorResult(e, url.toString(), res.getTime());
}
finally
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler HTTPSampler.java
Posted by se...@apache.org.
The URL is stored in setupConnection(), but only after the connection has been opened. Likewise various other fields in the result.
Perhaps these should be done before opening the connection - or indeed, perhaps the setup of these fields belongs in the calling
module, as setupConnection() may be retried a few times, and the values won't change.
S.
----- Original Message -----
From: <wo...@apache.org>
To: <ja...@apache.org>
Sent: Tuesday, March 09, 2004 2:55 PM
Subject: cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler HTTPSampler.java
woolfel 2004/03/09 06:55:39
Modified: src/protocol/http/org/apache/jmeter/protocol/http/sampler
HTTPSampler.java
Log:
when there's an IOException, the URL should still be set. Found this
difference in the process of writing the monitor. I use the URL as
the unique key for each individual serverpanel.
peter lin
Revision Changes Path
1.88 +3 -2 jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java
Index: HTTPSampler.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java,v
retrieving revision 1.87
retrieving revision 1.88
diff -u -r1.87 -r1.88
--- HTTPSampler.java 22 Feb 2004 19:21:41 -0000 1.87
+++ HTTPSampler.java 9 Mar 2004 14:55:39 -0000 1.88
@@ -1164,6 +1164,7 @@
catch (IOException e)
{
res.sampleEnd();
+ res.setURL(url);
return errorResult(e, url.toString(), res.getTime());
}
finally
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org