You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/02 21:47:00 UTC

[GitHub] [beam] robertwb commented on a change in pull request #13739: [BEAM-11629] Don't attach window info to cached batch PCollections.

robertwb commented on a change in pull request #13739:
URL: https://github.com/apache/beam/pull/13739#discussion_r568953085



##########
File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
##########
@@ -655,9 +660,13 @@ def process(
             t=beam.DoFn.TimestampParam):
           yield test_stream.WindowedValueHolder(WindowedValue(e, t, [w], p))
 
+      extended_target = pcoll
+      if self._is_streaming_pcollection(pcoll):

Review comment:
       Windowing can be present (and matter) in batch pipelines. Conversely, streaming pipelines can use the Global windows. The correct thing to do is always store this information in the cache, and conditionally strip it out in `ib.collect` if it's "not interesting."




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org