You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sis.apache.org by "Martin Desruisseaux (Jira)" <ji...@apache.org> on 2023/05/06 22:21:00 UTC

[jira] [Updated] (SIS-579) Do not extend JUnit Assert class

     [ https://issues.apache.org/jira/browse/SIS-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Desruisseaux updated SIS-579:
------------------------------------
    Description: 
SIS extents {{org.junit.Assert}} class for adding our own assertion methods as an addition to JUnit's ones. It was no longer possible in early version of JUnit 5, where the {{Assertions}} class became final. Later JUnit 5 versions allow extensibility again, but we may be better to avoid it.

* [JUnit 5 Javadoc|https://junit.org/junit5/docs/current/api/org.junit.jupiter.api/org/junit/jupiter/api/Assertions.html]

  was:
SIS was running tests not by letting JUnit discovers the test classes itself, but by providing an explicit {{TestSuite}} class for each module. The intend was to control test execution order. It was not really because the tests require a specific execution order for passing, but rather for trying to make easier to identify the root cause of test failures, by running simpler tests before more complex ones.

We should remove {{TestSuite}} in order to simplify the build. This is for making easier a future migration to JUnit 5. Build simplification is also desirable before to work on Jigsaw modules.

        Summary: Do not extend JUnit Assert class  (was: Remove TestSuite classes)

> Do not extend JUnit Assert class
> --------------------------------
>
>                 Key: SIS-579
>                 URL: https://issues.apache.org/jira/browse/SIS-579
>             Project: Spatial Information Systems
>          Issue Type: Task
>          Components: Build process
>    Affects Versions: 1.3
>            Reporter: Martin Desruisseaux
>            Assignee: Martin Desruisseaux
>            Priority: Major
>             Fix For: 1.4
>
>
> SIS extents {{org.junit.Assert}} class for adding our own assertion methods as an addition to JUnit's ones. It was no longer possible in early version of JUnit 5, where the {{Assertions}} class became final. Later JUnit 5 versions allow extensibility again, but we may be better to avoid it.
> * [JUnit 5 Javadoc|https://junit.org/junit5/docs/current/api/org.junit.jupiter.api/org/junit/jupiter/api/Assertions.html]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)