[GitHub] [superset] john-bodley commented on pull request #22065: Revert "feat: support None operand in EQUAL operator (#21713)"

[GitBox <gi...@apache.org>]

john-bodley commented on PR #22065:
URL: https://github.com/apache/superset/pull/22065#issuecomment-1307753762

   @villebro thanks for the context, however that's not clear from the description of the original PR. I mostly agree that rolling forward is often easier than rolling back, I do sense there are a number of shortcomings with the existing logic and having said logic merged—albeit a month ago—shouldn't imply precedence over potential short comings with the implementation. 
   
   Granted reverting this feature will likely churn existing deployments, but equally deployments moving forward with this SHA are equally likely going to negatively impact their users. Personally a change like this (though simply in nature) though potentially profound in terms of impact should likely be placed behind a feature flag to ensure i) the necessary wrinkles can be ironed out, and ii) deployments can coordinate their messaging and/or one off migrations to remedy charts which may be impacted by said change.  
      


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org