You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/29 15:05:00 UTC

[GitHub] [flink] zhengcanbin opened a new pull request #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.

zhengcanbin opened a new pull request #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
URL: https://github.com/apache/flink/pull/10963
 
 
   ## What is the purpose of the change
   
   It's likely that one would pull images from the private image registries, credentials can be passed with the Pod specification through the `imagePullSecrets` parameter,
   which refers to the k8s secret by name. Implementation wise we expose a new configuration option to the users and then pass it along to the K8S.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-579814507
 
 
   <!--
   Meta data
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   -->
   ## CI report:
   
   * b687d5e1835912c7866547f19fe4aec7c1399433 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] TisonKun commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-584412625
 
 
   Thanks for your contribution @zhengcanbin . Changes LGTM.
   
   Would you please rebase on master and retest since it fails above? Ping me on tests pass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhengcanbin commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.

Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-582212069
 
 
   cc @wangyang0918 @TisonKun 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhengcanbin closed pull request #10963: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.

Posted by GitBox <gi...@apache.org>.
zhengcanbin closed pull request #10963: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/10963
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhengcanbin commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.

Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-580066293
 
 
   cc @wangyang0918 @TisonKun

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10963: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10963: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-579814507
 
 
   <!--
   Meta data
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146612052 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   Hash:876ba140fa47ade2f628818d97e5a41ad18afeb3 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5035 TriggerType:PUSH TriggerID:876ba140fa47ade2f628818d97e5a41ad18afeb3
   Hash:876ba140fa47ade2f628818d97e5a41ad18afeb3 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/148304674 TriggerType:PUSH TriggerID:876ba140fa47ade2f628818d97e5a41ad18afeb3
   -->
   ## CI report:
   
   * b687d5e1835912c7866547f19fe4aec7c1399433 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146612052) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658) 
   * 876ba140fa47ade2f628818d97e5a41ad18afeb3 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/148304674) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5035) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhengcanbin removed a comment on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.

Posted by GitBox <gi...@apache.org>.
zhengcanbin removed a comment on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-582212069
 
 
   cc @wangyang0918 @TisonKun 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-579814507
 
 
   <!--
   Meta data
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146612052 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   -->
   ## CI report:
   
   * b687d5e1835912c7866547f19fe4aec7c1399433 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146612052) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-579798188
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit b687d5e1835912c7866547f19fe4aec7c1399433 (Wed Jan 29 15:07:23 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15652).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-579814507
 
 
   <!--
   Meta data
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146612052 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   -->
   ## CI report:
   
   * b687d5e1835912c7866547f19fe4aec7c1399433 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146612052) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-579814507
 
 
   <!--
   Meta data
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146612052 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   -->
   ## CI report:
   
   * b687d5e1835912c7866547f19fe4aec7c1399433 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146612052) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10963: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10963: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-579814507
 
 
   <!--
   Meta data
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146612052 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   Hash:876ba140fa47ade2f628818d97e5a41ad18afeb3 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:876ba140fa47ade2f628818d97e5a41ad18afeb3
   -->
   ## CI report:
   
   * b687d5e1835912c7866547f19fe4aec7c1399433 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146612052) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658) 
   * 876ba140fa47ade2f628818d97e5a41ad18afeb3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10963: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10963: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/10963#issuecomment-579814507
 
 
   <!--
   Meta data
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146612052 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   Hash:b687d5e1835912c7866547f19fe4aec7c1399433 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658 TriggerType:PUSH TriggerID:b687d5e1835912c7866547f19fe4aec7c1399433
   Hash:876ba140fa47ade2f628818d97e5a41ad18afeb3 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5035 TriggerType:PUSH TriggerID:876ba140fa47ade2f628818d97e5a41ad18afeb3
   Hash:876ba140fa47ade2f628818d97e5a41ad18afeb3 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148304674 TriggerType:PUSH TriggerID:876ba140fa47ade2f628818d97e5a41ad18afeb3
   -->
   ## CI report:
   
   * b687d5e1835912c7866547f19fe4aec7c1399433 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146612052) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658) 
   * 876ba140fa47ade2f628818d97e5a41ad18afeb3 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148304674) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5035) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services