[GitHub] [incubator-seatunnel] ic4y commented on a diff in pull request #4616: [Doc][Connector-v2][JdbcSource] Redshift add defaultRowFetchSize

["ic4y (via GitHub)" <gi...@apache.org>]

ic4y commented on code in PR #4616:
URL: https://github.com/apache/incubator-seatunnel/pull/4616#discussion_r1178686066


##########
docs/en/connector-v2/source/Jdbc.md:
##########
@@ -150,6 +150,26 @@ Jdbc {
 }
 ```
 
+redshift:
+
+```
+Jdbc {
+    url = "jdbc:redshift://localhost:5439/testdb?defaultRowFetchSize=1000"
+    driver = "com.amazon.redshift.jdbc42.Driver"
+    connection_check_timeout_sec = 100
+    user = "root"
+    password = "123456"
+    query = "select * from type_bin"
+}
+```
+
+:::tip
+
+defaultRowFetchSize param is very import for JDBC Source to read data from Redshift use Redshift driver.
+If defaultRowFetchSize is not set , the Redshift will return all data to seatunnel source reader and the source may oom.
+
+:::
+

Review Comment:
   I think adding defaultRowFetchSize to the appendix URL is enough, and it's not necessary to add it here. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org