You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Pranav Lodha (Code Review)" <ge...@cloudera.org> on 2025/10/30 04:56:16 UTC
[Impala-ASF-CR] IMPALA-14515: Update mysql-connector-j to always get the latest version
Pranav Lodha has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23610
Change subject: IMPALA-14515: Update mysql-connector-j to always get the latest version
......................................................................
IMPALA-14515: Update mysql-connector-j to always get the latest version
The patch focuses on updating mysql-connector-j to
always get the latest version to avoid getting
flagged by CVE scanners.
Change-Id: I6f4881d31d46c381abc9cdbb0694bbbbeaa9ede2
---
M testdata/bin/setup-mysql-env.sh
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/23610/2
--
To view, visit http://gerrit.cloudera.org:8080/23610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f4881d31d46c381abc9cdbb0694bbbbeaa9ede2
Gerrit-Change-Number: 23610
Gerrit-PatchSet: 2
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-14515: Update mysql-connector-j to always get the latest version
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/23610 )
Change subject: IMPALA-14515: Update mysql-connector-j to always get the latest version
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23610/2/testdata/bin/setup-mysql-env.sh
File testdata/bin/setup-mysql-env.sh:
http://gerrit.cloudera.org:8080/#/c/23610/2/testdata/bin/setup-mysql-env.sh@248
PS2, Line 248: /tmp/mysql-connector-j-${LATEST}/mysql-connector-j-${LATEST}.jar \
This is just for tests but regularly gets picked up by scanners scanning code. I don't think the jar is packaged as part of the build?
It's up to us to use LATEST or any version (mysql-connector-j-{mysql_version}.tar.gz) as long as we don't hardcode a version? I suspect that should prevent it from being flagged?
--
To view, visit http://gerrit.cloudera.org:8080/23610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f4881d31d46c381abc9cdbb0694bbbbeaa9ede2
Gerrit-Change-Number: 23610
Gerrit-PatchSet: 2
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Nov 2025 18:11:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14515: Update mysql-connector-j to always get the latest version
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23610 )
Change subject: IMPALA-14515: Update mysql-connector-j to always get the latest version
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23610/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23610/2//COMMIT_MSG@11
PS2, Line 11: flagged by CVE scanners.
What scanners are hitting this?
I would not want to do this for builds anyway, as it makes builds impossible to reproduce. It's probably ok for tests.
--
To view, visit http://gerrit.cloudera.org:8080/23610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f4881d31d46c381abc9cdbb0694bbbbeaa9ede2
Gerrit-Change-Number: 23610
Gerrit-PatchSet: 2
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Nov 2025 23:09:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14515: Update mysql-connector-j to always get the latest version
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23610 )
Change subject: IMPALA-14515: Update mysql-connector-j to always get the latest version
......................................................................
Patch Set 2:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23610/2/testdata/bin/setup-mysql-env.sh
File testdata/bin/setup-mysql-env.sh:
http://gerrit.cloudera.org:8080/#/c/23610/2/testdata/bin/setup-mysql-env.sh@243
PS2, Line 243: LATEST=$(curl -s https://repo1.maven.org/maven2/com/mysql/mysql-connector-j/maven-metadata.xml | grep -oPm1 "(?<=<release>)[^<]+")
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/23610/2/testdata/bin/setup-mysql-env.sh@244
PS2, Line 244: wget "https://repo1.maven.org/maven2/com/mysql/mysql-connector-j/${LATEST}/mysql-connector-j-${LATEST}.tar.gz"
line too long (110 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/23610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f4881d31d46c381abc9cdbb0694bbbbeaa9ede2
Gerrit-Change-Number: 23610
Gerrit-PatchSet: 2
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 04:58:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14515: Update mysql-connector-j to always get the latest version
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/23610 )
Change subject: IMPALA-14515: Update mysql-connector-j to always get the latest version
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23610/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23610/2//COMMIT_MSG@11
PS2, Line 11: flagged by CVE scanners.
> What scanners are hitting this?
Agree. This mysql jdbc driver is used for unit-test only. It's not used for production. Latest version may make unit-test not stable.
--
To view, visit http://gerrit.cloudera.org:8080/23610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f4881d31d46c381abc9cdbb0694bbbbeaa9ede2
Gerrit-Change-Number: 23610
Gerrit-PatchSet: 2
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Nov 2025 22:35:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14515: Update mysql-connector-j to always get the latest version
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23610 )
Change subject: IMPALA-14515: Update mysql-connector-j to always get the latest version
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20785/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f4881d31d46c381abc9cdbb0694bbbbeaa9ede2
Gerrit-Change-Number: 23610
Gerrit-PatchSet: 2
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 05:23:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14515: Update mysql-connector-j to always get the latest version
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/23610 )
Change subject: IMPALA-14515: Update mysql-connector-j to always get the latest version
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23610/2/testdata/bin/setup-mysql-env.sh
File testdata/bin/setup-mysql-env.sh:
http://gerrit.cloudera.org:8080/#/c/23610/2/testdata/bin/setup-mysql-env.sh@248
PS2, Line 248: /tmp/mysql-connector-j-${LATEST}/mysql-connector-j-${LATEST}.jar \
> This is just for tests but regularly gets picked up by scanners scanning co
Use environment variable IMPALA_MYSQL_JDBC_DRIVER_VERSION which is defined in bin/impala-config.sh
--
To view, visit http://gerrit.cloudera.org:8080/23610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f4881d31d46c381abc9cdbb0694bbbbeaa9ede2
Gerrit-Change-Number: 23610
Gerrit-PatchSet: 2
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Nov 2025 18:30:43 +0000
Gerrit-HasComments: Yes