[GitHub] ctubbsii commented on a change in pull request #487: Inline inner Rfile classes and interfaces

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #487: Inline inner Rfile classes and interfaces
URL: https://github.com/apache/accumulo/pull/487#discussion_r188726897
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java
 ##########
 @@ -128,9 +129,9 @@ protected FileSKVWriter openWriter(OpenWriterOperation options) throws IOExcepti
       outputStream = fs.create(new Path(file), false, bufferSize, (short) rep, block);
     }
 
-    CachableBlockFile.Writer _cbw = new CachableBlockFile.Writer(
+    BCFile.Writer _cbw = new BCFile.Writer(
         new RateLimitedOutputStream(outputStream, options.getRateLimiter()), compression, conf,
-        acuconf);
+        false, acuconf);
 
 Review comment:
   What does this false parameter accomplish? Can we do it with an enum instead of a boolean?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services