[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #4652: ICEBERG-4346: Better handling of Orphan files

[GitBox <gi...@apache.org>]

RussellSpitzer commented on code in PR #4652:
URL: https://github.com/apache/iceberg/pull/4652#discussion_r889026042


##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -80,6 +81,28 @@ public interface DeleteOrphanFiles extends Action<DeleteOrphanFiles, DeleteOrpha
    */
   DeleteOrphanFiles executeDeleteWith(ExecutorService executorService);
 
+
+  /**
+   * Pass a mode for handling the files that cannot be determined if they are orphan
+   * @param mode mode for handling files that cannot be determined if they are orphan
+   * @return this for method chaining
+   */
+  DeleteOrphanFiles prefixMismatchMode(String mode);
+
+  /**
+   * Pass a list of schemes to be considered equivalent when finding orphan files
+   * @param equivalentSchemes list of equivalent schemes
+   * @return this for method chaining
+   */
+  DeleteOrphanFiles equivalentSchemes(List<String> equivalentSchemes);
+
+  /**
+   * Pass a list of authorities to be considered equivalent when finding orphan files

Review Comment:
   So this is the issue in which you have the same path in multiple authorities but only one authority is correct? BUT you are also passing in both authorities to Delete-orphans to search for file listing, I didn't think we could do this? Seems like a rare use case.
   
   Wouldn't a user either being using s3://bucket1 or s3://bucket2 as the root search path for removing files? If they are passing in bucket1 they probably shouldn't pass in bucket2 as an acceptable equivalent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org