You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by se...@apache.org on 2018/07/02 02:08:07 UTC
[19/20] hive git commit: HIVE-20034: Roll back MetaStore exception
handling changes for backward compatibility (Peter Vary,
reviewed by Sergey Shelukhin)
HIVE-20034: Roll back MetaStore exception handling changes for backward compatibility (Peter Vary, reviewed by Sergey Shelukhin)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/455b71e4
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/455b71e4
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/455b71e4
Branch: refs/heads/master-txnstats
Commit: 455b71e4a2a51838818b77786566297b1fabb233
Parents: 08eba3e
Author: Peter Vary <pv...@cloudera.com>
Authored: Sun Jul 1 22:27:37 2018 +0200
Committer: Peter Vary <pv...@cloudera.com>
Committed: Sun Jul 1 22:27:37 2018 +0200
----------------------------------------------------------------------
.../java/org/apache/hadoop/hive/metastore/HiveMetaStore.java | 5 +++++
.../metastore/client/TestTablesCreateDropAlterTruncate.java | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/455b71e4/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
----------------------------------------------------------------------
diff --git a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
index 5819a26..1327fa2 100644
--- a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
+++ b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
@@ -1774,6 +1774,11 @@ public class HiveMetaStore extends ThriftHiveMetastore {
List<SQLCheckConstraint> checkConstraints)
throws AlreadyExistsException, MetaException,
InvalidObjectException, NoSuchObjectException {
+ // To preserve backward compatibility throw MetaException in case of null database
+ if (tbl.getDbName() == null) {
+ throw new MetaException("Null database name is not allowed");
+ }
+
if (!MetaStoreUtils.validateName(tbl.getTableName(), conf)) {
throw new InvalidObjectException(tbl.getTableName()
+ " is not a valid object name");
http://git-wip-us.apache.org/repos/asf/hive/blob/455b71e4/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
----------------------------------------------------------------------
diff --git a/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java b/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
index c40b42a..efa3e7c 100644
--- a/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
+++ b/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
@@ -367,7 +367,7 @@ public class TestTablesCreateDropAlterTruncate extends MetaStoreClientTest {
createdTable.getSd().getLocation());
}
- @Test(expected = InvalidObjectException.class)
+ @Test(expected = MetaException.class)
public void testCreateTableNullDatabase() throws Exception {
Table table = testTables[0];
table.setDbName(null);