You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/17 12:50:49 UTC

[GitHub] [spark] zero323 opened a new pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

zero323 opened a new pull request #35554:
URL: https://github.com/apache/spark/pull/35554


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   Adds native implementation of `__repr__` to `pyspark.mllib.classification.LogisticRegressionModel`.  [Documentation example](https://spark.apache.org/docs/latest/mllib-linear-methods.html#logistic-regression) returns the following after this patch:
   
   ```python
   >>> model
   pyspark.mllib.LogisticRegressionModel: intercept = 0.0, numFeatures = 16, numClasses = 2, threshold = 0.5
   
   ```
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   Current implementation is copied from `pyspark.ml.classification` counterpart and fails with `AttributeError`.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   No.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   
   Manual testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zero323 commented on a change in pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #35554:
URL: https://github.com/apache/spark/pull/35554#discussion_r809276588



##########
File path: python/pyspark/mllib/classification.py
##########
@@ -278,7 +278,10 @@ def load(cls, sc, path):
         return model
 
     def __repr__(self):

Review comment:
       Strictly speaking, this should be `__str__` not `__repr__`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35554:
URL: https://github.com/apache/spark/pull/35554#issuecomment-1059998225


   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zero323 commented on a change in pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #35554:
URL: https://github.com/apache/spark/pull/35554#discussion_r809276588



##########
File path: python/pyspark/mllib/classification.py
##########
@@ -278,7 +278,10 @@ def load(cls, sc, path):
         return model
 
     def __repr__(self):

Review comment:
       Strictly speaking, this should be `__str__` not `__repr__`, unless we want to match constructor not JVM counterpart. Shall we change it? Diverge in ouput? 

##########
File path: python/pyspark/mllib/classification.py
##########
@@ -278,7 +278,10 @@ def load(cls, sc, path):
         return model
 
     def __repr__(self):

Review comment:
       Strictly speaking, this should be `__str__` not `__repr__`, unless we want to match constructor not JVM counterpart. Shall we change it? Diverge in output? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] codecov-commenter commented on pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #35554:
URL: https://github.com/apache/spark/pull/35554#issuecomment-1046763622


   # [Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#35554](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a750ca) into [master](https://codecov.io/gh/apache/spark/commit/25dd4254fed71923731fd59838875c0dd1ff665a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (25dd425) will **decrease** coverage by `10.38%`.
   > The diff coverage is `86.66%`.
   
   > :exclamation: Current head 3a750ca differs from pull request most recent head f7f9691. Consider uploading reports for the commit f7f9691 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/spark/pull/35554/graphs/tree.svg?width=650&height=150&src=pr&token=R9pHLWgWi8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #35554       +/-   ##
   ===========================================
   - Coverage   91.27%   80.89%   -10.39%     
   ===========================================
     Files         297      199       -98     
     Lines       64021    47851    -16170     
     Branches     9903     7464     -2439     
   ===========================================
   - Hits        58436    38708    -19728     
   - Misses       4233     7923     +3690     
   + Partials     1352     1220      -132     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `80.87% <86.66%> (-10.38%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [python/pyspark/context.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvY29udGV4dC5weQ==) | `86.27% <ø> (-0.70%)` | :arrow_down: |
   | [python/pyspark/ml/classification.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWwvY2xhc3NpZmljYXRpb24ucHk=) | `84.67% <ø> (ø)` | |
   | [python/pyspark/pandas/internal.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvcGFuZGFzL2ludGVybmFsLnB5) | `90.61% <ø> (-4.47%)` | :arrow_down: |
   | [python/pyspark/sql/catalog.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2NhdGFsb2cucHk=) | `43.42% <0.00%> (-48.03%)` | :arrow_down: |
   | [python/pyspark/sql/observation.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL29ic2VydmF0aW9uLnB5) | `26.08% <0.00%> (-69.57%)` | :arrow_down: |
   | [python/pyspark/sql/streaming.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3N0cmVhbWluZy5weQ==) | `27.03% <25.00%> (-54.95%)` | :arrow_down: |
   | [python/pyspark/sql/utils.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3V0aWxzLnB5) | `66.94% <25.00%> (-19.84%)` | :arrow_down: |
   | [python/pyspark/sql/context.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2NvbnRleHQucHk=) | `43.27% <31.57%> (-39.47%)` | :arrow_down: |
   | [python/pyspark/serializers.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc2VyaWFsaXplcnMucHk=) | `81.55% <50.00%> (-0.48%)` | :arrow_down: |
   | [python/pyspark/sql/pandas/group\_ops.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3BhbmRhcy9ncm91cF9vcHMucHk=) | `43.85% <50.00%> (-47.52%)` | :arrow_down: |
   | ... and [205 more](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [16b6686...f7f9691](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] codecov-commenter removed a comment on pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
codecov-commenter removed a comment on pull request #35554:
URL: https://github.com/apache/spark/pull/35554#issuecomment-1046763622


   # [Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#35554](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a750ca) into [master](https://codecov.io/gh/apache/spark/commit/25dd4254fed71923731fd59838875c0dd1ff665a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (25dd425) will **decrease** coverage by `10.38%`.
   > The diff coverage is `86.66%`.
   
   > :exclamation: Current head 3a750ca differs from pull request most recent head f7f9691. Consider uploading reports for the commit f7f9691 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/spark/pull/35554/graphs/tree.svg?width=650&height=150&src=pr&token=R9pHLWgWi8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #35554       +/-   ##
   ===========================================
   - Coverage   91.27%   80.89%   -10.39%     
   ===========================================
     Files         297      199       -98     
     Lines       64021    47851    -16170     
     Branches     9903     7464     -2439     
   ===========================================
   - Hits        58436    38708    -19728     
   - Misses       4233     7923     +3690     
   + Partials     1352     1220      -132     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `80.87% <86.66%> (-10.38%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [python/pyspark/context.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvY29udGV4dC5weQ==) | `86.27% <ø> (-0.70%)` | :arrow_down: |
   | [python/pyspark/ml/classification.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWwvY2xhc3NpZmljYXRpb24ucHk=) | `84.67% <ø> (ø)` | |
   | [python/pyspark/pandas/internal.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvcGFuZGFzL2ludGVybmFsLnB5) | `90.61% <ø> (-4.47%)` | :arrow_down: |
   | [python/pyspark/sql/catalog.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2NhdGFsb2cucHk=) | `43.42% <0.00%> (-48.03%)` | :arrow_down: |
   | [python/pyspark/sql/observation.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL29ic2VydmF0aW9uLnB5) | `26.08% <0.00%> (-69.57%)` | :arrow_down: |
   | [python/pyspark/sql/streaming.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3N0cmVhbWluZy5weQ==) | `27.03% <25.00%> (-54.95%)` | :arrow_down: |
   | [python/pyspark/sql/utils.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3V0aWxzLnB5) | `66.94% <25.00%> (-19.84%)` | :arrow_down: |
   | [python/pyspark/sql/context.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2NvbnRleHQucHk=) | `43.27% <31.57%> (-39.47%)` | :arrow_down: |
   | [python/pyspark/serializers.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc2VyaWFsaXplcnMucHk=) | `81.55% <50.00%> (-0.48%)` | :arrow_down: |
   | [python/pyspark/sql/pandas/group\_ops.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3BhbmRhcy9ncm91cF9vcHMucHk=) | `43.85% <50.00%> (-47.52%)` | :arrow_down: |
   | ... and [205 more](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [16b6686...f7f9691](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zero323 commented on a change in pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #35554:
URL: https://github.com/apache/spark/pull/35554#discussion_r809276588



##########
File path: python/pyspark/mllib/classification.py
##########
@@ -278,7 +278,10 @@ def load(cls, sc, path):
         return model
 
     def __repr__(self):

Review comment:
       Strictly speaking, this should be `__str__` not `__repr__`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35554:
URL: https://github.com/apache/spark/pull/35554#issuecomment-1046442340


   @zero323, quick question
   
   > Current implementation is copied from `pyspark.ml.classification` counterpart and fails with `AttributeError`.
   
   Do you know why it fails?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zero323 commented on pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #35554:
URL: https://github.com/apache/spark/pull/35554#issuecomment-1046701633


   @HyukjinKwon  There is simply no such method define. `_call_java` is part of the `pyspark.ml.wrapper.JavaWrapper` API, which is not used in `pyspark.mllib`. Also, JVM model is not captured in this (and most of the `pyspark.mllib` if I recall correctly), so there is no object on which such method could be invoked ‒ if there was, we'd use something like tree models:
   
   https://github.com/apache/spark/blob/3a750ca4686e85e715c48c688f48acf7851144ed/python/pyspark/mllib/tree.py#L76-L78
   
   In general, `mllib` models don't have consistent string representation ‒ some just use `object` implementation, some summary like this one, some show [coefficients](https://github.com/apache/spark/blob/3a750ca4686e85e715c48c688f48acf7851144ed/python/pyspark/mllib/regression.py#L110-L111), and every time we use `__repr__` instead of `__str__`. If API wasn't in maintenance mode, that be something to address I guess...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] codecov-commenter removed a comment on pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
codecov-commenter removed a comment on pull request #35554:
URL: https://github.com/apache/spark/pull/35554#issuecomment-1046752883


   # [Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#35554](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a750ca) into [master](https://codecov.io/gh/apache/spark/commit/25dd4254fed71923731fd59838875c0dd1ff665a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (25dd425) will **decrease** coverage by `16.57%`.
   > The diff coverage is `83.86%`.
   
   > :exclamation: Current head 3a750ca differs from pull request most recent head f7f9691. Consider uploading reports for the commit f7f9691 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/spark/pull/35554/graphs/tree.svg?width=650&height=150&src=pr&token=R9pHLWgWi8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #35554       +/-   ##
   ===========================================
   - Coverage   91.27%   74.70%   -16.58%     
   ===========================================
     Files         297      128      -169     
     Lines       64021    25124    -38897     
     Branches     9903     3641     -6262     
   ===========================================
   - Hits        58436    18769    -39667     
   - Misses       4233     5717     +1484     
   + Partials     1352      638      -714     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `74.70% <83.86%> (-16.55%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [python/pyspark/context.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvY29udGV4dC5weQ==) | `86.27% <ø> (-0.70%)` | :arrow_down: |
   | [python/pyspark/ml/classification.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWwvY2xhc3NpZmljYXRpb24ucHk=) | `84.67% <ø> (ø)` | |
   | [python/pyspark/sql/catalog.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2NhdGFsb2cucHk=) | `43.42% <0.00%> (-48.03%)` | :arrow_down: |
   | [python/pyspark/sql/functions.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2Z1bmN0aW9ucy5weQ==) | `46.97% <0.00%> (-41.61%)` | :arrow_down: |
   | [python/pyspark/sql/observation.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL29ic2VydmF0aW9uLnB5) | `26.08% <0.00%> (-69.57%)` | :arrow_down: |
   | [python/pyspark/sql/pandas/group\_ops.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3BhbmRhcy9ncm91cF9vcHMucHk=) | `29.82% <0.00%> (-61.56%)` | :arrow_down: |
   | [python/pyspark/sql/pandas/map\_ops.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3BhbmRhcy9tYXBfb3BzLnB5) | `21.62% <0.00%> (-64.87%)` | :arrow_down: |
   | [python/pyspark/sql/pandas/conversion.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3BhbmRhcy9jb252ZXJzaW9uLnB5) | `8.74% <6.25%> (-83.49%)` | :arrow_down: |
   | [python/pyspark/sql/streaming.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3N0cmVhbWluZy5weQ==) | `27.03% <25.00%> (-54.95%)` | :arrow_down: |
   | [python/pyspark/sql/utils.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3V0aWxzLnB5) | `60.33% <25.00%> (-26.45%)` | :arrow_down: |
   | ... and [223 more](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [16b6686...f7f9691](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] codecov-commenter commented on pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #35554:
URL: https://github.com/apache/spark/pull/35554#issuecomment-1046752883


   # [Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#35554](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a750ca) into [master](https://codecov.io/gh/apache/spark/commit/25dd4254fed71923731fd59838875c0dd1ff665a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (25dd425) will **decrease** coverage by `16.57%`.
   > The diff coverage is `83.86%`.
   
   > :exclamation: Current head 3a750ca differs from pull request most recent head f7f9691. Consider uploading reports for the commit f7f9691 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/spark/pull/35554/graphs/tree.svg?width=650&height=150&src=pr&token=R9pHLWgWi8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #35554       +/-   ##
   ===========================================
   - Coverage   91.27%   74.70%   -16.58%     
   ===========================================
     Files         297      128      -169     
     Lines       64021    25124    -38897     
     Branches     9903     3641     -6262     
   ===========================================
   - Hits        58436    18769    -39667     
   - Misses       4233     5717     +1484     
   + Partials     1352      638      -714     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `74.70% <83.86%> (-16.55%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [python/pyspark/context.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvY29udGV4dC5weQ==) | `86.27% <ø> (-0.70%)` | :arrow_down: |
   | [python/pyspark/ml/classification.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWwvY2xhc3NpZmljYXRpb24ucHk=) | `84.67% <ø> (ø)` | |
   | [python/pyspark/sql/catalog.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2NhdGFsb2cucHk=) | `43.42% <0.00%> (-48.03%)` | :arrow_down: |
   | [python/pyspark/sql/functions.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2Z1bmN0aW9ucy5weQ==) | `46.97% <0.00%> (-41.61%)` | :arrow_down: |
   | [python/pyspark/sql/observation.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL29ic2VydmF0aW9uLnB5) | `26.08% <0.00%> (-69.57%)` | :arrow_down: |
   | [python/pyspark/sql/pandas/group\_ops.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3BhbmRhcy9ncm91cF9vcHMucHk=) | `29.82% <0.00%> (-61.56%)` | :arrow_down: |
   | [python/pyspark/sql/pandas/map\_ops.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3BhbmRhcy9tYXBfb3BzLnB5) | `21.62% <0.00%> (-64.87%)` | :arrow_down: |
   | [python/pyspark/sql/pandas/conversion.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3BhbmRhcy9jb252ZXJzaW9uLnB5) | `8.74% <6.25%> (-83.49%)` | :arrow_down: |
   | [python/pyspark/sql/streaming.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3N0cmVhbWluZy5weQ==) | `27.03% <25.00%> (-54.95%)` | :arrow_down: |
   | [python/pyspark/sql/utils.py](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3V0aWxzLnB5) | `60.33% <25.00%> (-26.45%)` | :arrow_down: |
   | ... and [223 more](https://codecov.io/gh/apache/spark/pull/35554/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [16b6686...f7f9691](https://codecov.io/gh/apache/spark/pull/35554?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zero323 commented on pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #35554:
URL: https://github.com/apache/spark/pull/35554#issuecomment-1059971833


   > Are there others that need fixing too? or at least a subset that could use the same fix?
   
   Nope. This one is just one time copy-and-paste from `pyspark.ml`. Other models either have no `__repr__` or one that is part of the original implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35554:
URL: https://github.com/apache/spark/pull/35554#issuecomment-1046417699


   Looks making sense .. but @WeichenXu123 would you mind taking a look please? I don't have enough background on string representation of ML instances.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35554:
URL: https://github.com/apache/spark/pull/35554#issuecomment-1059970396


   Are there others that need fixing too? or at least a subset that could use the same fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #35554: [SPARK-38239][PYTHON][MLLIB] Fix pyspark.mllib.LogisticRegressionModel.__repr__

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #35554:
URL: https://github.com/apache/spark/pull/35554


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org