You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Marc Fichant (JIRA)" <ji...@apache.org> on 2011/01/20 16:49:44 UTC

[jira] Created: (SHINDIG-1491) hardcoded localhost in generated gadget's iframe

hardcoded localhost in generated gadget's iframe
------------------------------------------------

                 Key: SHINDIG-1491
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1491
             Project: Shindig
          Issue Type: Bug
    Affects Versions: 2.0.2, 2.0.0
         Environment: IBM WAS under Windows and Unix 
            Reporter: Marc Fichant
            Priority: Blocker


while trying to deploy shindig on a server, we still get references to localhost on generated gadget's iframe.

here is the offending URL : http://192.168.188.123:9080/gadgets/ifr?container=default&mid=0&nocache=1&country=ALL&lang=ALL&view=default&parent=http%3A%2F%2F192.168.188.123%3A9080%2FMitGui%2Fpage%2Fsearch%2Fassets%3A%2F%2F192.168.188.123%3A9080&st=john.doe:john.doe:appid:cont:url:0:default&url=http%3A%2F%2F192.168.188.56%3A9090%2FWebSpace%2FGadgetsRepository%2Fplayer#rpctoken=96870469

here is what this generate (only the first few lines since error is only in first line):
<html><head><style type="text/css">body,td,div,span,p{font-family:arial,sans-serif;}a {color:#0000cc;}a:visited {color:#551a8b;}a:active {color:#ff0000;}body{margin: 0px;padding: 0px;background-color:white;}</style><script>window['__isgadget']=true;</script><script src="http://localhost:9080/gadgets/js/core:rpc.js?container=default&amp;nocache=1&amp;debug=0&amp;c=0"></script><script>var opensocial=opensocial||{};
opensocial.requestSendMessage=function(A,D,B,C){return opensocial.Container.get().requestSendMessage(A,D,B,C)
};

You will notice the http://localhost:9080 in the src of script tag.

For information we have set the following :
added the -Dshindig.port=9080 and -Dshindig.host="192.168.188.123" to the JVM variables 
added the shindig.host=192.168.188.123 and shindig.port=9080 in the param-value of the config in web.xml
the war is named MitGuiShindig-V1L1.war

this has been tested against 2.0.0 and 2.0.2

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1491) hardcoded localhost in generated gadget's iframe

Posted by "Sergiy Shyrkov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006237#comment-13006237 ] 

Sergiy Shyrkov commented on SHINDIG-1491:
-----------------------------------------

Hello,

we are integrating Shindig 2.0.2 into our project and also seeing hardcoded "localhost:8080" in the generated references to:
   http://localhost:8080/gadgets/js/core:rpc.js?....
and
   http://localhost:8080/gadgets/proxy?...

although the server is accessed not via "localhost" and the port number is not "8080".

Is there any chance to improve detection of the "current" server host and port (using request.getServerName() and request.getSeverPort())?
Or get rid of the absolute URLs in such a case when Shindig container is running in the same Web application context?

Thank you in advance!

Kind regards
Sergiy

> hardcoded localhost in generated gadget's iframe
> ------------------------------------------------
>
>                 Key: SHINDIG-1491
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1491
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.0.2
>         Environment: IBM WAS under Windows and Unix 
>            Reporter: Marc Fichant
>            Priority: Blocker
>
> while trying to deploy shindig on a server, we still get references to localhost on generated gadget's iframe.
> here is the offending URL : http://192.168.188.123:9080/gadgets/ifr?container=default&mid=0&nocache=1&country=ALL&lang=ALL&view=default&parent=http%3A%2F%2F192.168.188.123%3A9080%2FMitGui%2Fpage%2Fsearch%2Fassets%3A%2F%2F192.168.188.123%3A9080&st=john.doe:john.doe:appid:cont:url:0:default&url=http%3A%2F%2F192.168.188.56%3A9090%2FWebSpace%2FGadgetsRepository%2Fplayer#rpctoken=96870469
> here is what this generate (only the first few lines since error is only in first line):
> <html><head><style type="text/css">body,td,div,span,p{font-family:arial,sans-serif;}a {color:#0000cc;}a:visited {color:#551a8b;}a:active {color:#ff0000;}body{margin: 0px;padding: 0px;background-color:white;}</style><script>window['__isgadget']=true;</script><script src="http://localhost:9080/gadgets/js/core:rpc.js?container=default&amp;nocache=1&amp;debug=0&amp;c=0"></script><script>var opensocial=opensocial||{};
> opensocial.requestSendMessage=function(A,D,B,C){return opensocial.Container.get().requestSendMessage(A,D,B,C)
> };
> You will notice the http://localhost:9080 in the src of script tag.
> This will cause the page to fail loading since there is no shindig server on the localhost of the webbrowser.
> For information we have set the following :
> added the -Dshindig.port=9080 and -Dshindig.host="192.168.188.123" to the JVM variables 
> added the shindig.host=192.168.188.123 and shindig.port=9080 in the param-value of the config in web.xml
> the war is named MitGuiShindig-V1L1.war
> this has been tested against 2.0.0 and 2.0.2

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (SHINDIG-1491) hardcoded localhost in generated gadget's iframe

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984983#action_12984983 ] 

Henry Saputra commented on SHINDIG-1491:
----------------------------------------

If you are using shindig-server project as base, could you check the web.xml and could you remove this section:

shindig.host=localhost

> hardcoded localhost in generated gadget's iframe
> ------------------------------------------------
>
>                 Key: SHINDIG-1491
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1491
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.0.2
>         Environment: IBM WAS under Windows and Unix 
>            Reporter: Marc Fichant
>            Priority: Blocker
>
> while trying to deploy shindig on a server, we still get references to localhost on generated gadget's iframe.
> here is the offending URL : http://192.168.188.123:9080/gadgets/ifr?container=default&mid=0&nocache=1&country=ALL&lang=ALL&view=default&parent=http%3A%2F%2F192.168.188.123%3A9080%2FMitGui%2Fpage%2Fsearch%2Fassets%3A%2F%2F192.168.188.123%3A9080&st=john.doe:john.doe:appid:cont:url:0:default&url=http%3A%2F%2F192.168.188.56%3A9090%2FWebSpace%2FGadgetsRepository%2Fplayer#rpctoken=96870469
> here is what this generate (only the first few lines since error is only in first line):
> <html><head><style type="text/css">body,td,div,span,p{font-family:arial,sans-serif;}a {color:#0000cc;}a:visited {color:#551a8b;}a:active {color:#ff0000;}body{margin: 0px;padding: 0px;background-color:white;}</style><script>window['__isgadget']=true;</script><script src="http://localhost:9080/gadgets/js/core:rpc.js?container=default&amp;nocache=1&amp;debug=0&amp;c=0"></script><script>var opensocial=opensocial||{};
> opensocial.requestSendMessage=function(A,D,B,C){return opensocial.Container.get().requestSendMessage(A,D,B,C)
> };
> You will notice the http://localhost:9080 in the src of script tag.
> This will cause the page to fail loading since there is no shindig server on the localhost of the webbrowser.
> For information we have set the following :
> added the -Dshindig.port=9080 and -Dshindig.host="192.168.188.123" to the JVM variables 
> added the shindig.host=192.168.188.123 and shindig.port=9080 in the param-value of the config in web.xml
> the war is named MitGuiShindig-V1L1.war
> this has been tested against 2.0.0 and 2.0.2

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Closed] (SHINDIG-1491) hardcoded localhost in generated gadget's iframe

Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saputra closed SHINDIG-1491.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.0

This should be fixed in latest code where hostname and port are configurable and the default provided from authority provider. 

> hardcoded localhost in generated gadget's iframe
> ------------------------------------------------
>
>                 Key: SHINDIG-1491
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1491
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.0.2
>         Environment: IBM WAS under Windows and Unix 
>            Reporter: Marc Fichant
>            Priority: Blocker
>             Fix For: 3.0.0
>
>
> while trying to deploy shindig on a server, we still get references to localhost on generated gadget's iframe.
> here is the offending URL : http://192.168.188.123:9080/gadgets/ifr?container=default&mid=0&nocache=1&country=ALL&lang=ALL&view=default&parent=http%3A%2F%2F192.168.188.123%3A9080%2FMitGui%2Fpage%2Fsearch%2Fassets%3A%2F%2F192.168.188.123%3A9080&st=john.doe:john.doe:appid:cont:url:0:default&url=http%3A%2F%2F192.168.188.56%3A9090%2FWebSpace%2FGadgetsRepository%2Fplayer#rpctoken=96870469
> here is what this generate (only the first few lines since error is only in first line):
> <html><head><style type="text/css">body,td,div,span,p{font-family:arial,sans-serif;}a {color:#0000cc;}a:visited {color:#551a8b;}a:active {color:#ff0000;}body{margin: 0px;padding: 0px;background-color:white;}</style><script>window['__isgadget']=true;</script><script src="http://localhost:9080/gadgets/js/core:rpc.js?container=default&amp;nocache=1&amp;debug=0&amp;c=0"></script><script>var opensocial=opensocial||{};
> opensocial.requestSendMessage=function(A,D,B,C){return opensocial.Container.get().requestSendMessage(A,D,B,C)
> };
> You will notice the http://localhost:9080 in the src of script tag.
> This will cause the page to fail loading since there is no shindig server on the localhost of the webbrowser.
> For information we have set the following :
> added the -Dshindig.port=9080 and -Dshindig.host="192.168.188.123" to the JVM variables 
> added the shindig.host=192.168.188.123 and shindig.port=9080 in the param-value of the config in web.xml
> the war is named MitGuiShindig-V1L1.war
> this has been tested against 2.0.0 and 2.0.2

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SHINDIG-1491) hardcoded localhost in generated gadget's iframe

Posted by "Marc Fichant (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marc Fichant updated SHINDIG-1491:
----------------------------------

    Description: 
while trying to deploy shindig on a server, we still get references to localhost on generated gadget's iframe.

here is the offending URL : http://192.168.188.123:9080/gadgets/ifr?container=default&mid=0&nocache=1&country=ALL&lang=ALL&view=default&parent=http%3A%2F%2F192.168.188.123%3A9080%2FMitGui%2Fpage%2Fsearch%2Fassets%3A%2F%2F192.168.188.123%3A9080&st=john.doe:john.doe:appid:cont:url:0:default&url=http%3A%2F%2F192.168.188.56%3A9090%2FWebSpace%2FGadgetsRepository%2Fplayer#rpctoken=96870469

here is what this generate (only the first few lines since error is only in first line):
<html><head><style type="text/css">body,td,div,span,p{font-family:arial,sans-serif;}a {color:#0000cc;}a:visited {color:#551a8b;}a:active {color:#ff0000;}body{margin: 0px;padding: 0px;background-color:white;}</style><script>window['__isgadget']=true;</script><script src="http://localhost:9080/gadgets/js/core:rpc.js?container=default&amp;nocache=1&amp;debug=0&amp;c=0"></script><script>var opensocial=opensocial||{};
opensocial.requestSendMessage=function(A,D,B,C){return opensocial.Container.get().requestSendMessage(A,D,B,C)
};

You will notice the http://localhost:9080 in the src of script tag.

This will cause the page to fail loading since there is no shindig server on the localhost of the webbrowser.

For information we have set the following :
added the -Dshindig.port=9080 and -Dshindig.host="192.168.188.123" to the JVM variables 
added the shindig.host=192.168.188.123 and shindig.port=9080 in the param-value of the config in web.xml
the war is named MitGuiShindig-V1L1.war

this has been tested against 2.0.0 and 2.0.2

  was:
while trying to deploy shindig on a server, we still get references to localhost on generated gadget's iframe.

here is the offending URL : http://192.168.188.123:9080/gadgets/ifr?container=default&mid=0&nocache=1&country=ALL&lang=ALL&view=default&parent=http%3A%2F%2F192.168.188.123%3A9080%2FMitGui%2Fpage%2Fsearch%2Fassets%3A%2F%2F192.168.188.123%3A9080&st=john.doe:john.doe:appid:cont:url:0:default&url=http%3A%2F%2F192.168.188.56%3A9090%2FWebSpace%2FGadgetsRepository%2Fplayer#rpctoken=96870469

here is what this generate (only the first few lines since error is only in first line):
<html><head><style type="text/css">body,td,div,span,p{font-family:arial,sans-serif;}a {color:#0000cc;}a:visited {color:#551a8b;}a:active {color:#ff0000;}body{margin: 0px;padding: 0px;background-color:white;}</style><script>window['__isgadget']=true;</script><script src="http://localhost:9080/gadgets/js/core:rpc.js?container=default&amp;nocache=1&amp;debug=0&amp;c=0"></script><script>var opensocial=opensocial||{};
opensocial.requestSendMessage=function(A,D,B,C){return opensocial.Container.get().requestSendMessage(A,D,B,C)
};

You will notice the http://localhost:9080 in the src of script tag.

For information we have set the following :
added the -Dshindig.port=9080 and -Dshindig.host="192.168.188.123" to the JVM variables 
added the shindig.host=192.168.188.123 and shindig.port=9080 in the param-value of the config in web.xml
the war is named MitGuiShindig-V1L1.war

this has been tested against 2.0.0 and 2.0.2


> hardcoded localhost in generated gadget's iframe
> ------------------------------------------------
>
>                 Key: SHINDIG-1491
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1491
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.0.2
>         Environment: IBM WAS under Windows and Unix 
>            Reporter: Marc Fichant
>            Priority: Blocker
>
> while trying to deploy shindig on a server, we still get references to localhost on generated gadget's iframe.
> here is the offending URL : http://192.168.188.123:9080/gadgets/ifr?container=default&mid=0&nocache=1&country=ALL&lang=ALL&view=default&parent=http%3A%2F%2F192.168.188.123%3A9080%2FMitGui%2Fpage%2Fsearch%2Fassets%3A%2F%2F192.168.188.123%3A9080&st=john.doe:john.doe:appid:cont:url:0:default&url=http%3A%2F%2F192.168.188.56%3A9090%2FWebSpace%2FGadgetsRepository%2Fplayer#rpctoken=96870469
> here is what this generate (only the first few lines since error is only in first line):
> <html><head><style type="text/css">body,td,div,span,p{font-family:arial,sans-serif;}a {color:#0000cc;}a:visited {color:#551a8b;}a:active {color:#ff0000;}body{margin: 0px;padding: 0px;background-color:white;}</style><script>window['__isgadget']=true;</script><script src="http://localhost:9080/gadgets/js/core:rpc.js?container=default&amp;nocache=1&amp;debug=0&amp;c=0"></script><script>var opensocial=opensocial||{};
> opensocial.requestSendMessage=function(A,D,B,C){return opensocial.Container.get().requestSendMessage(A,D,B,C)
> };
> You will notice the http://localhost:9080 in the src of script tag.
> This will cause the page to fail loading since there is no shindig server on the localhost of the webbrowser.
> For information we have set the following :
> added the -Dshindig.port=9080 and -Dshindig.host="192.168.188.123" to the JVM variables 
> added the shindig.host=192.168.188.123 and shindig.port=9080 in the param-value of the config in web.xml
> the war is named MitGuiShindig-V1L1.war
> this has been tested against 2.0.0 and 2.0.2

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.