You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by KanakaKumar <gi...@git.apache.org> on 2018/05/29 05:54:49 UTC

[GitHub] carbondata pull request #2347: [CARBONDATA-2554] Added support for logical t...

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2347#discussion_r191310013
  
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java ---
    @@ -88,9 +90,18 @@
       private Object avroFieldToObject(Schema.Field avroField, Object fieldValue) {
         Object out;
         Schema.Type type = avroField.schema().getType();
    +    LogicalType logicalType = avroField.schema().getLogicalType();
         switch (type) {
    -      case BOOLEAN:
           case INT:
    +        if (logicalType != null) {
    --- End diff --
    
    Consider to convert as date only if the logical type is Date


---