You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by audreyso <gi...@git.apache.org> on 2017/10/03 21:18:06 UTC
[GitHub] cordova-cli pull request #287: CB-13303 : added noprod/production as an opti...
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-cli/pull/287
CB-13303 : added noprod/production as an option, no prod turns off pr…
…oduction
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Added noprod/production as an option
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-cli CB-13303
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/287.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #287
----
commit 145c1e6acc9152e39aeb3d2ebae5a1d4d5843e43
Author: Audrey So <au...@apache.org>
Date: 2017-10-03T21:14:18Z
CB-13303 : added noprod/production as an option, no prod turns off production
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request #287: CB-13303 : added noprod/production as an opti...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/287#discussion_r142530184
--- Diff: src/cli.js ---
@@ -475,8 +491,11 @@ function cli (inputArgs) {
link: args.link || false,
save: args.save,
shrinkwrap: args.shrinkwrap || false,
- force: args.force || false
+ force: args.force || false,
+ production: args.production,
+ noprod: args.noprod || false
--- End diff --
no need to pass noprod, it is only used to figure out production. Which you do on L454
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request #287: CB-13303 : added noprod/production as an opti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/287
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request #287: CB-13303 : added noprod/production as an opti...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/287#discussion_r142529980
--- Diff: src/cli.js ---
@@ -465,6 +473,14 @@ function cli (inputArgs) {
// User explicitly did not pass in searchpath
args.searchpath = conf.get('searchpath');
}
+ if (args.production === undefined) {
+ // User explicitly did not pass in noprod
+ args.production = conf.get('production');
+ }
+ if (args.noprod === undefined) {
--- End diff --
lets not offer `noprod` in config. Just `args.production`. We only need noprod like you have in line 454. Used to figure out of args.production is true or false.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org