You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/01/16 15:54:07 UTC
Re: Review Request 69723: Enabled operation feedback on agent default
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69723/
-----------------------------------------------------------
(Updated Jan. 16, 2019, 3:54 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Changes
-------
Upgraded from WIP to actual review.
Summary (updated)
-----------------
Enabled operation feedback on agent default resources.
Bugs: MESOS-9472
https://issues.apache.org/jira/browse/MESOS-9472
Repository: mesos
Description (updated)
-------
Up to now, the master would validate that any operation
requesting operation feedback would only act on resources
belonging to a resource provider.
This patch removes this restriction and enables frameworks
to request operation feedback on an agent's default
resources.
Diffs (updated)
-----
src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2
src/master/validation.cpp a71edeb7827b534e27ad3e3398abe555bf36e741
src/slave/slave.cpp 10cbc190acc7eea5734efa0066541168545a66b6
src/tests/api_tests.cpp 79a2d2966ff6533629aeeefaaaf19e849b76e0e6
src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550
Diff: https://reviews.apache.org/r/69723/diff/2/
Changes: https://reviews.apache.org/r/69723/diff/1-2/
Testing
-------
./src/mesos-tests
Thanks,
Benno Evers
Re: Review Request 69723: Enabled operation feedback on agent default
resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69723/#review212076
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69669', '69723']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2792/mesos-review-69723
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2792/mesos-review-69723/logs/mesos-tests.log):
```
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_SkipRecoverMalformedUUID
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Logs
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Override
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Args
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhileFetching
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[ FAILED ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull
28 FAILED TESTS
YOU HAVE 231 DISABLED TESTS
116 17:02:32.902634 26872 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=10956 to peer '192.10.1.6:52006': IO failed with error code: The specified network name is no longer available.
W0116 17:02:32.902634 26872 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=7440 to peer '192.10.1.6:52005': IO failed with error code: The specified network name is no longer available.
I0116 17:02:32.910681 27316 containerizer.cpp:2975] Container b1dff0c7-6ce4-4557-aff8-7b4b44dcc13e has exited
I0116 17:02:32.938659 26864 master.cpp:1109] Master terminating
I0116 17:02:32.940645 24832 hierarchical.cpp:644] Removed agent cffb1eeb-6a1b-42c0-91be-416950fc5e76-S0
I0116 17:02:33.394681 26872 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Jan. 16, 2019, 7:54 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69723/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2019, 7:54 a.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9472
> https://issues.apache.org/jira/browse/MESOS-9472
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Up to now, the master would validate that any operation
> requesting operation feedback would only act on resources
> belonging to a resource provider.
>
> This patch removes this restriction and enables frameworks
> to request operation feedback on an agent's default
> resources.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2
> src/master/validation.cpp a71edeb7827b534e27ad3e3398abe555bf36e741
> src/slave/slave.cpp 10cbc190acc7eea5734efa0066541168545a66b6
> src/tests/api_tests.cpp 79a2d2966ff6533629aeeefaaaf19e849b76e0e6
> src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
> src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550
>
>
> Diff: https://reviews.apache.org/r/69723/diff/2/
>
>
> Testing
> -------
>
> ./src/mesos-tests
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69723: Enabled operation feedback on agent default
resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69723/#review212144
-----------------------------------------------------------
PASS: Mesos patch 69723 was successfully built and tested.
Reviews applied: `['69786', '69723']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2802/mesos-review-69723
- Mesos Reviewbot Windows
On Jan. 18, 2019, 9:45 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69723/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2019, 9:45 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9472
> https://issues.apache.org/jira/browse/MESOS-9472
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Up to now, the master would validate that any operation
> requesting operation feedback would only act on resources
> belonging to a resource provider.
>
> This patch removes this restriction and enables frameworks
> to request operation feedback on an agent's default
> resources.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2
> src/master/validation.cpp a71edeb7827b534e27ad3e3398abe555bf36e741
> src/slave/slave.cpp 10cbc190acc7eea5734efa0066541168545a66b6
> src/tests/api_tests.cpp 79a2d2966ff6533629aeeefaaaf19e849b76e0e6
> src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
> src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550
>
>
> Diff: https://reviews.apache.org/r/69723/diff/3/
>
>
> Testing
> -------
>
> ./src/mesos-tests
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69723: Enabled operation feedback on agent default
resources.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69723/#review212425
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Jan. 18, 2019, 1:45 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69723/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2019, 1:45 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9472
> https://issues.apache.org/jira/browse/MESOS-9472
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Up to now, the master would validate that any operation
> requesting operation feedback would only act on resources
> belonging to a resource provider.
>
> This patch removes this restriction and enables frameworks
> to request operation feedback on an agent's default
> resources.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2
> src/master/validation.cpp a71edeb7827b534e27ad3e3398abe555bf36e741
> src/slave/slave.cpp 10cbc190acc7eea5734efa0066541168545a66b6
> src/tests/api_tests.cpp 79a2d2966ff6533629aeeefaaaf19e849b76e0e6
> src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
> src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550
>
>
> Diff: https://reviews.apache.org/r/69723/diff/3/
>
>
> Testing
> -------
>
> ./src/mesos-tests
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69723: Enabled operation feedback on agent default
resources.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69723/
-----------------------------------------------------------
(Updated Jan. 18, 2019, 1:45 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Changes
-------
Used new `AGENT_OPERATION_UPDATE` capability.
Bugs: MESOS-9472
https://issues.apache.org/jira/browse/MESOS-9472
Repository: mesos
Description
-------
Up to now, the master would validate that any operation
requesting operation feedback would only act on resources
belonging to a resource provider.
This patch removes this restriction and enables frameworks
to request operation feedback on an agent's default
resources.
Diffs (updated)
-----
src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2
src/master/validation.cpp a71edeb7827b534e27ad3e3398abe555bf36e741
src/slave/slave.cpp 10cbc190acc7eea5734efa0066541168545a66b6
src/tests/api_tests.cpp 79a2d2966ff6533629aeeefaaaf19e849b76e0e6
src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550
Diff: https://reviews.apache.org/r/69723/diff/3/
Changes: https://reviews.apache.org/r/69723/diff/2-3/
Testing
-------
./src/mesos-tests
Thanks,
Benno Evers
Re: Review Request 69723: Enabled operation feedback on agent default
resources.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Jan. 18, 2019, 1:51 a.m., Greg Mann wrote:
> > src/tests/api_tests.cpp
> > Lines 5260 (patched)
> > <https://reviews.apache.org/r/69723/diff/2/?file=2120015#file2120015line5260>
> >
> > s/that the we/that schedulers/
We can fix this while committing.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69723/#review212119
-----------------------------------------------------------
On Jan. 18, 2019, 1:45 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69723/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2019, 1:45 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9472
> https://issues.apache.org/jira/browse/MESOS-9472
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Up to now, the master would validate that any operation
> requesting operation feedback would only act on resources
> belonging to a resource provider.
>
> This patch removes this restriction and enables frameworks
> to request operation feedback on an agent's default
> resources.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2
> src/master/validation.cpp a71edeb7827b534e27ad3e3398abe555bf36e741
> src/slave/slave.cpp 10cbc190acc7eea5734efa0066541168545a66b6
> src/tests/api_tests.cpp 79a2d2966ff6533629aeeefaaaf19e849b76e0e6
> src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
> src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550
>
>
> Diff: https://reviews.apache.org/r/69723/diff/3/
>
>
> Testing
> -------
>
> ./src/mesos-tests
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 69723: Enabled operation feedback on agent default
resources.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69723/#review212119
-----------------------------------------------------------
This patch LGTM, modulo the note below regarding the extra capability check, once we have that in place. Thanks Benno!!
src/master/master.cpp
Lines 4367-4374 (original), 4359-4366 (patched)
<https://reviews.apache.org/r/69723/#comment297731>
As we discussed elsewhere, we need to perform a similar check for the case where `(!slave->capabilities.agentOperationFeedback && !operation.has_resource_provider_id())` once we have the new capability in place.
src/tests/api_tests.cpp
Lines 5260 (patched)
<https://reviews.apache.org/r/69723/#comment297732>
s/that the we/that schedulers/
- Greg Mann
On Jan. 16, 2019, 3:54 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69723/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2019, 3:54 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9472
> https://issues.apache.org/jira/browse/MESOS-9472
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Up to now, the master would validate that any operation
> requesting operation feedback would only act on resources
> belonging to a resource provider.
>
> This patch removes this restriction and enables frameworks
> to request operation feedback on an agent's default
> resources.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2
> src/master/validation.cpp a71edeb7827b534e27ad3e3398abe555bf36e741
> src/slave/slave.cpp 10cbc190acc7eea5734efa0066541168545a66b6
> src/tests/api_tests.cpp 79a2d2966ff6533629aeeefaaaf19e849b76e0e6
> src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
> src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550
>
>
> Diff: https://reviews.apache.org/r/69723/diff/2/
>
>
> Testing
> -------
>
> ./src/mesos-tests
>
>
> Thanks,
>
> Benno Evers
>
>