You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@gmail.com> on 2015/06/05 17:45:24 UTC
Re: [pool] JMX question
On 4/28/15 6:20 AM, Phil Steitz wrote:
> On 4/26/15 9:23 PM, Gary Gregory wrote:
>> In I see:
>>
>> private String jmxNameBase = DEFAULT_JMX_NAME_PREFIX;
>>
>> Shouldn;t that be:
>>
>> private String jmxNameBase = DEFAULT_JMX_NAME_BASE;
>>
>> ?
>>
> There is a comment in the code indicating that we may want to
> combine these two properties in 3.x. The RHS that looks more
> natural would assign null, which I don't think we want to do. It
> would be good to document a little more fully exactly how these
> properties work from public API standpoint. The idea is to allow
> the pool to self-register with default name if it is configured to
> register itself and the user has not supplied naming info.
See POOL-298. I am inclined to agree now with Gary and the OP on
that issue. Any objections to the change in that ticket?
Phil
>
> Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [pool] JMX question
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Jun 5, 2015 at 8:45 AM, Phil Steitz <ph...@gmail.com> wrote:
> On 4/28/15 6:20 AM, Phil Steitz wrote:
> > On 4/26/15 9:23 PM, Gary Gregory wrote:
> >> In I see:
> >>
> >> private String jmxNameBase = DEFAULT_JMX_NAME_PREFIX;
> >>
> >> Shouldn;t that be:
> >>
> >> private String jmxNameBase = DEFAULT_JMX_NAME_BASE;
> >>
> >> ?
> >>
> > There is a comment in the code indicating that we may want to
> > combine these two properties in 3.x. The RHS that looks more
> > natural would assign null, which I don't think we want to do. It
> > would be good to document a little more fully exactly how these
> > properties work from public API standpoint. The idea is to allow
> > the pool to self-register with default name if it is configured to
> > register itself and the user has not supplied naming info.
>
> See POOL-298. I am inclined to agree now with Gary and the OP on
> that issue. Any objections to the change in that ticket?
>
Go for it. RERO!
Gary
>
> Phil
> >
> > Phil
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory