You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2021/10/07 21:23:18 UTC

[GitHub] [celix] pnoltes opened a new pull request #371: Feature/remove psa versions v1

pnoltes opened a new pull request #371:
URL: https://github.com/apache/celix/pull/371


   This RP removes the old pubsub admin v1 versions. 
   
   The TCP, ZMQ and websocket pubsub admins are updated (v2 versions) so that they can handle pubsub message serialization services and this was done next to the "old" versions to enable a smooth transition.
   
   This transition is now done and the old pubsub admins can be removed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] codecov-commenter commented on pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #371:
URL: https://github.com/apache/celix/pull/371#issuecomment-938170680


   # [Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#371](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1efeac) into [master](https://codecov.io/gh/apache/celix/commit/7c785c54cffccf6c5c36fda3afed4f74a61c88a4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c785c5) will **increase** coverage by `0.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/celix/pull/371/graphs/tree.svg?width=650&height=150&src=pr&token=JdsiThga8P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #371      +/-   ##
   ==========================================
   + Coverage   71.72%   72.17%   +0.45%     
   ==========================================
     Files         206      191      -15     
     Lines       35277    30866    -4411     
   ==========================================
   - Hits        25301    22279    -3022     
   + Misses       9976     8587    -1389     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...undles/pubsub/pubsub\_admin\_tcp/src/psa\_activator.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHNhX2FjdGl2YXRvci5j) | `100.00% <ø> (ø)` | |
   | [...les/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_admin.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9hZG1pbi5j) | `50.50% <ø> (ø)` | |
   | [...es/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_common.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9jb21tb24uYw==) | `0.00% <ø> (ø)` | |
   | [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `78.19% <ø> (ø)` | |
   | [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `70.42% <ø> (ø)` | |
   | [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `84.88% <ø> (ø)` | |
   | [.../pubsub/pubsub\_admin\_websocket/src/psa\_activator.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHNhX2FjdGl2YXRvci5j) | `100.00% <ø> (ø)` | |
   | [...ubsub\_admin\_websocket/src/pubsub\_websocket\_admin.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF9hZG1pbi5j) | `42.47% <ø> (ø)` | |
   | [...bsub\_admin\_websocket/src/pubsub\_websocket\_common.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF9jb21tb24uYw==) | `59.25% <ø> (ø)` | |
   | [...in\_websocket/src/pubsub\_websocket\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF90b3BpY19yZWNlaXZlci5j) | `68.28% <ø> (ø)` | |
   | ... and [9 more](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c785c5...f1efeac](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] pnoltes commented on a change in pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #371:
URL: https://github.com/apache/celix/pull/371#discussion_r745880304



##########
File path: bundles/pubsub/pubsub_admin_zmq/CMakeLists.txt
##########
@@ -45,17 +42,32 @@ add_celix_bundle(celix_pubsub_admin_zmq
         ${ZMQ_CRYPTO_C}
 )
 
-set_target_properties(celix_pubsub_admin_zmq PROPERTIES INSTALL_RPATH "$ORIGIN")
 target_link_libraries(celix_pubsub_admin_zmq PRIVATE
-
         Celix::framework Celix::dfi Celix::log_helper Celix::utils
-        ZMQ::lib CZMQ::lib ${OPTIONAL_OPENSSL_LIB}
-)
+        ZMQ::lib CZMQ::lib ${OPTIONAL_OPENSSL_LIB})
+target_link_libraries(celix_pubsub_admin_zmq PRIVATE Celix::shell_api)
 target_link_libraries(celix_pubsub_admin_zmq PRIVATE Celix::pubsub_spi Celix::pubsub_utils )
-target_include_directories(celix_pubsub_admin_zmq PRIVATE
-    src
-)
-
+target_include_directories(celix_pubsub_admin_zmq PRIVATE src)
 install_celix_bundle(celix_pubsub_admin_zmq EXPORT celix COMPONENT pubsub)
-target_link_libraries(celix_pubsub_admin_zmq PRIVATE Celix::shell_api)
 add_library(Celix::celix_pubsub_admin_zmq ALIAS celix_pubsub_admin_zmq)
+
+
+#Tmp psa zmq _v2 target

Review comment:
       removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] rlenferink commented on a change in pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
rlenferink commented on a change in pull request #371:
URL: https://github.com/apache/celix/pull/371#discussion_r725207812



##########
File path: bundles/pubsub/examples/CMakeLists.txt
##########
@@ -147,7 +147,7 @@ if (BUILD_PUBSUB_PSA_TCP)
                 Celix::celix_pubsub_serializer_json
                 Celix::celix_pubsub_discovery_etcd
                 Celix::celix_pubsub_topology_manager
-                Celix::celix_pubsub_admin_tcp
+                Celix::celix_pubsub_admin_tcp_v2

Review comment:
       I noticed the directory names are reverted back to their original names (e.g. `pubsub_admin_zmq`, without the `v1` or `v2`). Should that also be done for the target names to possibly remain backwards compatible (I don't know if that's even possible)? Or is this an intentional breaking chance?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] pnoltes commented on a change in pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #371:
URL: https://github.com/apache/celix/pull/371#discussion_r745880562



##########
File path: bundles/pubsub/pubsub_admin_tcp/CMakeLists.txt
##########
@@ -32,15 +30,37 @@ add_celix_bundle(celix_pubsub_admin_tcp
         src/pubsub_tcp_common.c
 )
 
-set_target_properties(celix_pubsub_admin_tcp PROPERTIES INSTALL_RPATH "$ORIGIN")
 target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::pubsub_spi Celix::pubsub_utils)
-target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::framework Celix::dfi Celix::log_helper)
+target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::framework Celix::log_helper)
+target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::shell_api)
 target_include_directories(celix_pubsub_admin_tcp PRIVATE src)
 # cmake find package UUID set the wrong include dir for OSX
 if (NOT APPLE)
     target_link_libraries(celix_pubsub_admin_tcp PRIVATE UUID::lib)
 endif()
 
 install_celix_bundle(celix_pubsub_admin_tcp EXPORT celix COMPONENT pubsub)
-target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::shell_api)
 add_library(Celix::celix_pubsub_admin_tcp ALIAS celix_pubsub_admin_tcp)
+
+
+#Tmp psa tcp _v2 target
+add_celix_bundle(celix_pubsub_admin_tcp_v2
+    BUNDLE_SYMBOLICNAME "apache_celix_pubsub_admin_tcp_v2"
+    VERSION "2.0.0"
+    GROUP "Celix/PubSub"
+    SOURCES
+        src/psa_activator.c
+        src/pubsub_tcp_admin.c
+        src/pubsub_tcp_topic_sender.c
+        src/pubsub_tcp_topic_receiver.c
+        src/pubsub_tcp_handler.c
+        src/pubsub_tcp_common.c
+)
+target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE Celix::pubsub_spi Celix::pubsub_utils)
+target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE Celix::framework Celix::log_helper)
+target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE Celix::shell_api)
+target_include_directories(celix_pubsub_admin_tcp_v2 PRIVATE src)
+if (NOT APPLE)
+    target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE UUID::lib)
+endif()
+install_celix_bundle(celix_pubsub_admin_tcp_v2 EXPORT celix COMPONENT pubsub)

Review comment:
       removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] codecov-commenter edited a comment on pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #371:
URL: https://github.com/apache/celix/pull/371#issuecomment-938170680


   # [Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#371](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3e6db25) into [master](https://codecov.io/gh/apache/celix/commit/7c785c54cffccf6c5c36fda3afed4f74a61c88a4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c785c5) will **increase** coverage by `0.46%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/celix/pull/371/graphs/tree.svg?width=650&height=150&src=pr&token=JdsiThga8P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #371      +/-   ##
   ==========================================
   + Coverage   71.72%   72.18%   +0.46%     
   ==========================================
     Files         206      191      -15     
     Lines       35277    30866    -4411     
   ==========================================
   - Hits        25301    22282    -3019     
   + Misses       9976     8584    -1392     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...undles/pubsub/pubsub\_admin\_tcp/src/psa\_activator.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHNhX2FjdGl2YXRvci5j) | `100.00% <ø> (ø)` | |
   | [...les/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_admin.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9hZG1pbi5j) | `50.50% <ø> (ø)` | |
   | [...es/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_common.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9jb21tb24uYw==) | `0.00% <ø> (ø)` | |
   | [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `78.19% <ø> (ø)` | |
   | [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `70.14% <ø> (ø)` | |
   | [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `85.77% <ø> (ø)` | |
   | [.../pubsub/pubsub\_admin\_websocket/src/psa\_activator.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHNhX2FjdGl2YXRvci5j) | `100.00% <ø> (ø)` | |
   | [...ubsub\_admin\_websocket/src/pubsub\_websocket\_admin.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF9hZG1pbi5j) | `42.47% <ø> (ø)` | |
   | [...bsub\_admin\_websocket/src/pubsub\_websocket\_common.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF9jb21tb24uYw==) | `59.25% <ø> (ø)` | |
   | [...in\_websocket/src/pubsub\_websocket\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF90b3BpY19yZWNlaXZlci5j) | `68.28% <0.00%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c785c5...3e6db25](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] rlenferink commented on a change in pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
rlenferink commented on a change in pull request #371:
URL: https://github.com/apache/celix/pull/371#discussion_r744272616



##########
File path: bundles/pubsub/pubsub_admin_zmq/CMakeLists.txt
##########
@@ -45,17 +42,32 @@ add_celix_bundle(celix_pubsub_admin_zmq
         ${ZMQ_CRYPTO_C}
 )
 
-set_target_properties(celix_pubsub_admin_zmq PROPERTIES INSTALL_RPATH "$ORIGIN")
 target_link_libraries(celix_pubsub_admin_zmq PRIVATE
-
         Celix::framework Celix::dfi Celix::log_helper Celix::utils
-        ZMQ::lib CZMQ::lib ${OPTIONAL_OPENSSL_LIB}
-)
+        ZMQ::lib CZMQ::lib ${OPTIONAL_OPENSSL_LIB})
+target_link_libraries(celix_pubsub_admin_zmq PRIVATE Celix::shell_api)
 target_link_libraries(celix_pubsub_admin_zmq PRIVATE Celix::pubsub_spi Celix::pubsub_utils )
-target_include_directories(celix_pubsub_admin_zmq PRIVATE
-    src
-)
-
+target_include_directories(celix_pubsub_admin_zmq PRIVATE src)
 install_celix_bundle(celix_pubsub_admin_zmq EXPORT celix COMPONENT pubsub)
-target_link_libraries(celix_pubsub_admin_zmq PRIVATE Celix::shell_api)
 add_library(Celix::celix_pubsub_admin_zmq ALIAS celix_pubsub_admin_zmq)
+
+
+#Tmp psa zmq _v2 target

Review comment:
       `Tmp`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] pnoltes commented on a change in pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #371:
URL: https://github.com/apache/celix/pull/371#discussion_r745880231



##########
File path: bundles/pubsub/pubsub_admin_websocket/CMakeLists.txt
##########
@@ -18,9 +18,34 @@
 find_package(Jansson REQUIRED)
 find_package(UUID REQUIRED)
 
+add_celix_bundle(celix_pubsub_admin_websocket
+    BUNDLE_SYMBOLICNAME "apache_celix_pubsub_admin_websocket"
+    VERSION "2.0.0"
+    GROUP "Celix/PubSub"
+    SOURCES
+        src/psa_activator.c
+        src/pubsub_websocket_admin.c
+        src/pubsub_websocket_topic_sender.c
+        src/pubsub_websocket_topic_receiver.c
+        src/pubsub_websocket_common.c
+)
+
+target_link_libraries(celix_pubsub_admin_websocket PRIVATE
+        Celix::framework Celix::log_helper Celix::utils
+        Celix::http_admin_api
+)
+target_link_libraries(celix_pubsub_admin_websocket PRIVATE Celix::pubsub_spi Celix::pubsub_utils)
+target_link_libraries(celix_pubsub_admin_websocket PRIVATE Celix::shell_api)
+target_include_directories(celix_pubsub_admin_websocket PRIVATE src)
+
+install_celix_bundle(celix_pubsub_admin_websocket EXPORT celix COMPONENT pubsub)
+add_library(Celix::celix_pubsub_admin_websocket ALIAS celix_pubsub_admin_websocket)
+
+
+#Tmp psa websocket _v2 target

Review comment:
       No, I removed this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] codecov-commenter edited a comment on pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #371:
URL: https://github.com/apache/celix/pull/371#issuecomment-938170680


   # [Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#371](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3e6db25) into [master](https://codecov.io/gh/apache/celix/commit/7c785c54cffccf6c5c36fda3afed4f74a61c88a4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c785c5) will **increase** coverage by `0.90%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/celix/pull/371/graphs/tree.svg?width=650&height=150&src=pr&token=JdsiThga8P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #371      +/-   ##
   ==========================================
   + Coverage   71.72%   72.62%   +0.90%     
   ==========================================
     Files         206      204       -2     
     Lines       35277    31321    -3956     
   ==========================================
   - Hits        25301    22747    -2554     
   + Misses       9976     8574    -1402     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...undles/pubsub/pubsub\_admin\_tcp/src/psa\_activator.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHNhX2FjdGl2YXRvci5j) | `100.00% <ø> (ø)` | |
   | [...les/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_admin.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9hZG1pbi5j) | `50.50% <ø> (ø)` | |
   | [...es/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_common.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9jb21tb24uYw==) | `0.00% <ø> (ø)` | |
   | [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `78.19% <ø> (ø)` | |
   | [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `72.11% <ø> (ø)` | |
   | [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `85.77% <ø> (ø)` | |
   | [.../pubsub/pubsub\_admin\_websocket/src/psa\_activator.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHNhX2FjdGl2YXRvci5j) | `100.00% <ø> (ø)` | |
   | [...ubsub\_admin\_websocket/src/pubsub\_websocket\_admin.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF9hZG1pbi5j) | `42.47% <ø> (ø)` | |
   | [...bsub\_admin\_websocket/src/pubsub\_websocket\_common.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF9jb21tb24uYw==) | `59.25% <ø> (ø)` | |
   | [...in\_websocket/src/pubsub\_websocket\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF90b3BpY19yZWNlaXZlci5j) | `68.28% <0.00%> (ø)` | |
   | ... and [31 more](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c785c5...3e6db25](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] codecov-commenter commented on pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #371:
URL: https://github.com/apache/celix/pull/371#issuecomment-938170680


   # [Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#371](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1efeac) into [master](https://codecov.io/gh/apache/celix/commit/7c785c54cffccf6c5c36fda3afed4f74a61c88a4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c785c5) will **increase** coverage by `0.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/celix/pull/371/graphs/tree.svg?width=650&height=150&src=pr&token=JdsiThga8P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #371      +/-   ##
   ==========================================
   + Coverage   71.72%   72.17%   +0.45%     
   ==========================================
     Files         206      191      -15     
     Lines       35277    30866    -4411     
   ==========================================
   - Hits        25301    22279    -3022     
   + Misses       9976     8587    -1389     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...undles/pubsub/pubsub\_admin\_tcp/src/psa\_activator.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHNhX2FjdGl2YXRvci5j) | `100.00% <ø> (ø)` | |
   | [...les/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_admin.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9hZG1pbi5j) | `50.50% <ø> (ø)` | |
   | [...es/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_common.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9jb21tb24uYw==) | `0.00% <ø> (ø)` | |
   | [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `78.19% <ø> (ø)` | |
   | [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `70.42% <ø> (ø)` | |
   | [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `84.88% <ø> (ø)` | |
   | [.../pubsub/pubsub\_admin\_websocket/src/psa\_activator.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHNhX2FjdGl2YXRvci5j) | `100.00% <ø> (ø)` | |
   | [...ubsub\_admin\_websocket/src/pubsub\_websocket\_admin.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF9hZG1pbi5j) | `42.47% <ø> (ø)` | |
   | [...bsub\_admin\_websocket/src/pubsub\_websocket\_common.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF9jb21tb24uYw==) | `59.25% <ø> (ø)` | |
   | [...in\_websocket/src/pubsub\_websocket\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF90b3BpY19yZWNlaXZlci5j) | `68.28% <ø> (ø)` | |
   | ... and [9 more](https://codecov.io/gh/apache/celix/pull/371/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c785c5...f1efeac](https://codecov.io/gh/apache/celix/pull/371?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] pnoltes commented on a change in pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #371:
URL: https://github.com/apache/celix/pull/371#discussion_r725608132



##########
File path: bundles/pubsub/examples/CMakeLists.txt
##########
@@ -147,7 +147,7 @@ if (BUILD_PUBSUB_PSA_TCP)
                 Celix::celix_pubsub_serializer_json
                 Celix::celix_pubsub_discovery_etcd
                 Celix::celix_pubsub_topology_manager
-                Celix::celix_pubsub_admin_tcp
+                Celix::celix_pubsub_admin_tcp_v2

Review comment:
       Yes, you have a point. I will think about removing _v2 postfix.
   Note that we need to align this also internally at our company, but indeed the added _v2 postfix is now a backwards incompatible compared with the last release.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] rlenferink commented on a change in pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
rlenferink commented on a change in pull request #371:
URL: https://github.com/apache/celix/pull/371#discussion_r744272425



##########
File path: bundles/pubsub/pubsub_admin_tcp/CMakeLists.txt
##########
@@ -32,15 +30,37 @@ add_celix_bundle(celix_pubsub_admin_tcp
         src/pubsub_tcp_common.c
 )
 
-set_target_properties(celix_pubsub_admin_tcp PROPERTIES INSTALL_RPATH "$ORIGIN")
 target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::pubsub_spi Celix::pubsub_utils)
-target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::framework Celix::dfi Celix::log_helper)
+target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::framework Celix::log_helper)
+target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::shell_api)
 target_include_directories(celix_pubsub_admin_tcp PRIVATE src)
 # cmake find package UUID set the wrong include dir for OSX
 if (NOT APPLE)
     target_link_libraries(celix_pubsub_admin_tcp PRIVATE UUID::lib)
 endif()
 
 install_celix_bundle(celix_pubsub_admin_tcp EXPORT celix COMPONENT pubsub)
-target_link_libraries(celix_pubsub_admin_tcp PRIVATE Celix::shell_api)
 add_library(Celix::celix_pubsub_admin_tcp ALIAS celix_pubsub_admin_tcp)
+
+
+#Tmp psa tcp _v2 target
+add_celix_bundle(celix_pubsub_admin_tcp_v2
+    BUNDLE_SYMBOLICNAME "apache_celix_pubsub_admin_tcp_v2"
+    VERSION "2.0.0"
+    GROUP "Celix/PubSub"
+    SOURCES
+        src/psa_activator.c
+        src/pubsub_tcp_admin.c
+        src/pubsub_tcp_topic_sender.c
+        src/pubsub_tcp_topic_receiver.c
+        src/pubsub_tcp_handler.c
+        src/pubsub_tcp_common.c
+)
+target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE Celix::pubsub_spi Celix::pubsub_utils)
+target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE Celix::framework Celix::log_helper)
+target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE Celix::shell_api)
+target_include_directories(celix_pubsub_admin_tcp_v2 PRIVATE src)
+if (NOT APPLE)
+    target_link_libraries(celix_pubsub_admin_tcp_v2 PRIVATE UUID::lib)
+endif()
+install_celix_bundle(celix_pubsub_admin_tcp_v2 EXPORT celix COMPONENT pubsub)

Review comment:
       This can be removed, right (it probably is the same as the `celix_pubsub_admin_tcp` target) ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] rlenferink commented on a change in pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
rlenferink commented on a change in pull request #371:
URL: https://github.com/apache/celix/pull/371#discussion_r744272598



##########
File path: bundles/pubsub/pubsub_admin_websocket/CMakeLists.txt
##########
@@ -18,9 +18,34 @@
 find_package(Jansson REQUIRED)
 find_package(UUID REQUIRED)
 
+add_celix_bundle(celix_pubsub_admin_websocket
+    BUNDLE_SYMBOLICNAME "apache_celix_pubsub_admin_websocket"
+    VERSION "2.0.0"
+    GROUP "Celix/PubSub"
+    SOURCES
+        src/psa_activator.c
+        src/pubsub_websocket_admin.c
+        src/pubsub_websocket_topic_sender.c
+        src/pubsub_websocket_topic_receiver.c
+        src/pubsub_websocket_common.c
+)
+
+target_link_libraries(celix_pubsub_admin_websocket PRIVATE
+        Celix::framework Celix::log_helper Celix::utils
+        Celix::http_admin_api
+)
+target_link_libraries(celix_pubsub_admin_websocket PRIVATE Celix::pubsub_spi Celix::pubsub_utils)
+target_link_libraries(celix_pubsub_admin_websocket PRIVATE Celix::shell_api)
+target_include_directories(celix_pubsub_admin_websocket PRIVATE src)
+
+install_celix_bundle(celix_pubsub_admin_websocket EXPORT celix COMPONENT pubsub)
+add_library(Celix::celix_pubsub_admin_websocket ALIAS celix_pubsub_admin_websocket)
+
+
+#Tmp psa websocket _v2 target

Review comment:
       is this still needed (the `Tmp` suggests otherwise) ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] pnoltes merged pull request #371: Feature/remove psa versions v1

Posted by GitBox <gi...@apache.org>.
pnoltes merged pull request #371:
URL: https://github.com/apache/celix/pull/371


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org