You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/09 21:22:24 UTC

[GitHub] [arrow] kszucs opened a new pull request #10692: [CI] Validate docker compose configuration

kszucs opened a new pull request #10692:
URL: https://github.com/apache/arrow/pull/10692


   Will create a JIRA for it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10692: ARROW-13323: [Archery] Validate docker compose configuration

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10692:
URL: https://github.com/apache/arrow/pull/10692#issuecomment-879068234


   https://issues.apache.org/jira/browse/ARROW-13323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on a change in pull request #10692: [Archery] Validate docker compose configuration

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10692:
URL: https://github.com/apache/arrow/pull/10692#discussion_r667218230



##########
File path: .github/workflows/archery.yml
##########
@@ -62,7 +62,7 @@ jobs:
         working-directory: dev/archery
         run: pytest -v archery
       - name: Archery Docker Validation
-        run: archery docker
+        run: archery docker validate-config

Review comment:
       Click hasn't been executing the command initialization with a subcommand, effectively omitting the validation.
   
   Although it have not caused any problems since the docker build and run commands verify the configuration.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on a change in pull request #10692: [Archery] Validate docker compose configuration

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10692:
URL: https://github.com/apache/arrow/pull/10692#discussion_r667218230



##########
File path: .github/workflows/archery.yml
##########
@@ -62,7 +62,7 @@ jobs:
         working-directory: dev/archery
         run: pytest -v archery
       - name: Archery Docker Validation
-        run: archery docker
+        run: archery docker validate-config

Review comment:
       Click hasn't been executing the command initialization with a subcommand, effectively omitting the validation.
   
   Although it has not caused any problems since the docker build and run commands verify the configuration.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10692: [Archery] Validate docker compose configuration

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10692:
URL: https://github.com/apache/arrow/pull/10692#issuecomment-877463451


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on a change in pull request #10692: ARROW-13323: [Archery] Validate docker compose configuration

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10692:
URL: https://github.com/apache/arrow/pull/10692#discussion_r668741682



##########
File path: .github/workflows/archery.yml
##########
@@ -62,7 +62,7 @@ jobs:
         working-directory: dev/archery
         run: pytest -v archery
       - name: Archery Docker Validation
-        run: archery docker
+        run: archery docker validate-config

Review comment:
       Should rename to check-config similarly to the crossbow config check command.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs closed pull request #10692: ARROW-13323: [Archery] Validate docker compose configuration

Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10692:
URL: https://github.com/apache/arrow/pull/10692


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org