You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2020/01/10 01:43:04 UTC
Re: Review Request 71816: Added domain socket-related flags to Mesos
agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71816/
-----------------------------------------------------------
(Updated Jan. 10, 2020, 1:43 a.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Various bugfixes.
Summary (updated)
-----------------
Added domain socket-related flags to Mesos agent.
Bugs: MESOS-10035
https://issues.apache.org/jira/browse/MESOS-10035
Repository: mesos
Description
-------
Added two new flags 'http_executor_domain_sockets' and
'domain_socket_location' to the agent, along with minimal
logic to pass the relevant values on to executors.
They are used to control whether the agent should
provide a domain socket to HTTP executors and the
location of the socket on the host filesystem, respectively.
Diffs (updated)
-----
src/slave/constants.hpp 721afe13ff590122878a8ead62c66f89e8549e91
src/slave/flags.hpp 3c5ffca62454c340656cfc89c53a198757815794
src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222
src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7
src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002
Diff: https://reviews.apache.org/r/71816/diff/3/
Changes: https://reviews.apache.org/r/71816/diff/2-3/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71816: Added domain socket-related flags to Mesos
agent.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71816/#review219210
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/main.cpp
Lines 348 (patched)
<https://reviews.apache.org/r/71816/#comment307319>
`domain_socket_location` is an `Option<string>` and this does not compile.
src/slave/main.cpp
Lines 352 (patched)
<https://reviews.apache.org/r/71816/#comment307320>
Ditto.
src/slave/main.cpp
Lines 354 (patched)
<https://reviews.apache.org/r/71816/#comment307321>
Ditto.
- Benjamin Bannier
On Jan. 10, 2020, 2:43 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71816/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2020, 2:43 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-10035
> https://issues.apache.org/jira/browse/MESOS-10035
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added two new flags 'http_executor_domain_sockets' and
> 'domain_socket_location' to the agent, along with minimal
> logic to pass the relevant values on to executors.
>
> They are used to control whether the agent should
> provide a domain socket to HTTP executors and the
> location of the socket on the host filesystem, respectively.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp 721afe13ff590122878a8ead62c66f89e8549e91
> src/slave/flags.hpp 3c5ffca62454c340656cfc89c53a198757815794
> src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222
> src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7
> src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002
>
>
> Diff: https://reviews.apache.org/r/71816/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71816: Added domain socket-related flags to Mesos
agent.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71816/#review219212
-----------------------------------------------------------
Fix it, then Ship it!
Forgot to attach these comments to my latest FixIt/ShipIt.
src/slave/flags.cpp
Lines 991 (patched)
<https://reviews.apache.org/r/71816/#comment307323>
Can you put the e.g., single quotes?
src/slave/flags.cpp
Lines 995 (patched)
<https://reviews.apache.org/r/71816/#comment307322>
Use the constant introduced elsewhere here as well.
src/slave/slave.cpp
Lines 11095 (patched)
<https://reviews.apache.org/r/71816/#comment307324>
Ditto.
- Benjamin Bannier
On Jan. 10, 2020, 2:43 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71816/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2020, 2:43 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-10035
> https://issues.apache.org/jira/browse/MESOS-10035
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added two new flags 'http_executor_domain_sockets' and
> 'domain_socket_location' to the agent, along with minimal
> logic to pass the relevant values on to executors.
>
> They are used to control whether the agent should
> provide a domain socket to HTTP executors and the
> location of the socket on the host filesystem, respectively.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp 721afe13ff590122878a8ead62c66f89e8549e91
> src/slave/flags.hpp 3c5ffca62454c340656cfc89c53a198757815794
> src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222
> src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7
> src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002
>
>
> Diff: https://reviews.apache.org/r/71816/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71816: Added domain socket-related flags to Mesos
agent.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71816/#review219223
-----------------------------------------------------------
src/slave/flags.hpp
Lines 185-186 (patched)
<https://reviews.apache.org/r/71816/#comment307381>
Let's also document these flags in `docs/configuration/agent.md`.
- Benjamin Bannier
On Jan. 10, 2020, 2:43 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71816/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2020, 2:43 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-10035
> https://issues.apache.org/jira/browse/MESOS-10035
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added two new flags 'http_executor_domain_sockets' and
> 'domain_socket_location' to the agent, along with minimal
> logic to pass the relevant values on to executors.
>
> They are used to control whether the agent should
> provide a domain socket to HTTP executors and the
> location of the socket on the host filesystem, respectively.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp 721afe13ff590122878a8ead62c66f89e8549e91
> src/slave/flags.hpp 3c5ffca62454c340656cfc89c53a198757815794
> src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222
> src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7
> src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002
>
>
> Diff: https://reviews.apache.org/r/71816/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>