[GitHub] [couchdb] kocolosk commented on issue #2368: Does smoosh take DB param revs_limit into account ?

[GitBox <gi...@apache.org>]

kocolosk commented on issue #2368: Does smoosh take DB param revs_limit into account ?
URL: https://github.com/apache/couchdb/issues/2368#issuecomment-566731879
 
 
   Hi @creativityjuice, thanks! A couple of comments from my end on this topic:
   
   * The `revs_limit` setting doesn't control how many document bodies are kept, only how many revision *identifiers*. This is important when you have a frequently updated document and a replication peer that only checks in periodically. If the document is updated more than `revs_limit` times in between replications it will look like a new conflict from the perspective of the replication peer (as the peer won't be able to join up edit histories).
   * There is no setting to control how many document bodies are preserved; compaction (whether automatic or manually triggered) always removes the body of any revision for which a descendant exists in the edit history.
   
   If I understand your situation correctly what you're really asking for is the ability for compaction to preserve some number of older edits, and then for a flag to have smoosh use that configuration. Unfortunately, that'd be a relatively sophisticated patch; a lot of the codebase is organized around the notion that "leafs" of the revision tree are special. I should also point out that in the 4.0 release there won't be a compaction process at all -- old document revisions will be removed immediately when the new update is committed.
   
   As an aside, if I take the question "Does smoosh take `_revs_limit` into account?" literally the answer is **yes** -- smoosh will honor a database's configured revision stemming limit. It's just that this setting doesn't do what you're looking for it to do.
   
   I'm going to close this issue but happy to hear your thoughts on the above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services